From: Vadim Fedorenko <vadim.fedorenko@linux.dev>
To: xu.xin.sc@gmail.com
Cc: dsahern@kernel.org, kuba@kernel.org, pabeni@redhat.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
xu xin <xu.xin16@zte.com.cn>, Yang Yang <yang.yang29@zte.com.cn>,
Si Hao <si.hao@zte.com.cn>,
davem@davemloft.net
Subject: Re: [PATCH linux-next v2] net/ipv4: return the real errno instead of -EINVAL
Date: Tue, 8 Aug 2023 14:11:19 +0100 [thread overview]
Message-ID: <1591f6c8-f346-83da-f4f5-abdd7d0c0bd4@linux.dev> (raw)
In-Reply-To: <20230807015408.248237-1-xu.xin16@zte.com.cn>
On 07/08/2023 02:54, xu.xin.sc@gmail.com wrote:
> From: xu xin <xu.xin16@zte.com.cn>
>
> For now, No matter what error pointer ip_neigh_for_gw() returns,
> ip_finish_output2() always return -EINVAL, which may mislead the upper
> users.
>
> For exemple, an application uses sendto to send an UDP packet, but when the
> neighbor table overflows, sendto() will get a value of -EINVAL, and it will
> cause users to waste a lot of time checking parameters for errors.
>
> Return the real errno instead of -EINVAL.
>
> Signed-off-by: xu xin <xu.xin16@zte.com.cn>
> Reviewed-by: Yang Yang <yang.yang29@zte.com.cn>
> Cc: Si Hao <si.hao@zte.com.cn>
> ---
Reviewed-by: Vadim Fedorenko <vadim.fedorenko@linux.dev>
next prev parent reply other threads:[~2023-08-08 16:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-07 1:54 xu.xin.sc
2023-08-07 20:17 ` Kuniyuki Iwashima
2023-08-08 13:11 ` Vadim Fedorenko [this message]
2023-08-08 23:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1591f6c8-f346-83da-f4f5-abdd7d0c0bd4@linux.dev \
--to=vadim.fedorenko@linux.dev \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=si.hao@zte.com.cn \
--cc=xu.xin.sc@gmail.com \
--cc=xu.xin16@zte.com.cn \
--cc=yang.yang29@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome