From: <sean.wang@mediatek.com>
To: <andy.shevchenko@gmail.com>
Cc: <andriy.shevchenko@linux.intel.com>, <gregkh@linuxfoundation.org>,
<steven.liu@mediatek.com>, <arnd@arndb.de>,
<linux-kernel@vger.kernel.org>,
<linux-mediatek@lists.infradead.org>, <Ryder.Lee@mediatek.com>,
<sean.wang@mediatek.com>, <tthayer@opensource.altera.com>,
<linux-serial@vger.kernel.org>, <jslaby@suse.com>,
<matthias.bgg@gmail.com>, <sr@denx.de>,
<mika.westerberg@linux.intel.com>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v3] tty: serial: don't do termios for BTIF
Date: Wed, 17 Jun 2020 11:58:20 +0800 [thread overview]
Message-ID: <1592366300-29503-1-git-send-email-sean.wang@mediatek.com> (raw)
In-Reply-To: <CAHp75VdSvE9RPq3V8LTVX7OjaYs1PThVi2f1roh3p5EY_k0ANA@mail.gmail.com>
From: Sean Wang <sean.wang@mediatek.com>
>>
>> From: Sean Wang <sean.wang@mediatek.com>
>>
>> Bluetooth Interface (BTIF) is designed dedicatedly for MediaTek SOC
>> with BT in order to be instead of the UART interface between BT module
>> and Host CPU, and not exported to user space to access.
>>
>> As the UART design, BTIF will be an APB slave and can transmit or
>> receive data by MCU access, but doesn't provide termios function like
>> baudrate and flow control setup.
>>
>> Even LCR on offset 0xC that is just a FAKELCR a. If FAKELCR[7] is
>> equaled to 1, RBR(0x00), THR(0x00), IER(0x04)
>> will not be readable/writable.
>>
>> b. If FAKELCR is equaled to 0xBF, RBR(0x00), THR(0x00), IER(0x04),
>> IIR(0x08), and LSR(0x14) will not be readable/writable.
>>
>> So adding a new capability 'UART_CAP_NTIO' for the unusual unsupported
>> case.
>>
>> Fixes: 1c16ae65e250 ("serial: 8250: of: Add new port type for MediaTek
>> BTIF controller on MT7622/23 SoC")
>> Cc: Steven Liu <steven.liu@mediatek.com>
>
>> Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
>I didn't suggest this change. I only commented on the name of the macro.
my fault. i will remove the tag from next version.
>
>> Signed-off-by: Sean Wang <sean.wang@mediatek.com>
>> Signed-off-by: Ryder Lee <ryder.lee@mediatek.com>
>>
>> --
prev parent reply other threads:[~2020-06-17 3:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-22 18:02 sean.wang
2020-04-22 18:09 ` Greg KH
2020-05-05 11:10 ` Greg KH
2020-06-17 3:50 ` sean.wang
2020-04-22 19:20 ` Andy Shevchenko
2020-06-17 3:58 ` sean.wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1592366300-29503-1-git-send-email-sean.wang@mediatek.com \
--to=sean.wang@mediatek.com \
--cc=Ryder.Lee@mediatek.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=mika.westerberg@linux.intel.com \
--cc=sr@denx.de \
--cc=steven.liu@mediatek.com \
--cc=tthayer@opensource.altera.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®