mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Antoine Tenart <antoine.tenart@bootlin.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: davem@davemloft.net, f.fainelli@gmail.com, hkallweit1@gmail.com,
	richardcochran@gmail.com, alexandre.belloni@bootlin.com,
	UNGLinuxDriver@microchip.com, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com,
	allan.nielsen@microchip.com, foss@0leil.net
Subject: Re: [PATCH net-next v3 5/8] net: phy: mscc: 1588 block initialization
Date: Mon, 22 Jun 2020 15:07:05 +0200	[thread overview]
Message-ID: <159283122502.1456598.2577905456018345790@kwain> (raw)
In-Reply-To: <20200620151001.GL304147@lunn.ch>

Hi Andrew,

Quoting Andrew Lunn (2020-06-20 17:10:01)
> On Fri, Jun 19, 2020 at 02:22:57PM +0200, Antoine Tenart wrote:
> > From: Quentin Schulz <quentin.schulz@bootlin.com>
> > 
> > This patch adds the first parts of the 1588 support in the MSCC PHY,
> > with registers definition and the 1588 block initialization.
> > 
> > Those PHYs are distributed in hardware packages containing multiple
> > times the PHY. The VSC8584 for example is composed of 4 PHYs. With
> > hardware packages, parts of the logic is usually common and one of the
> > PHY has to be used for some parts of the initialization. Following this
> > logic, the 1588 blocks of those PHYs are shared between two PHYs and
> > accessing the registers has to be done using the "base" PHY of the
> > group. This is handled thanks to helpers in the PTP code (and locks).
> > We also need the MDIO bus lock while performing a single read or write
> > to the 1588 registers as the read/write are composed of multiple MDIO
> > transactions (and we don't want other threads updating the page).
> 
> Locking sounds complex. I assume LOCKDEP was your friend in getting
> this correct and deadlock free.

I agree, locking is not straight forward. But it's actually not that
complex:

- The MDIO bus lock is used for all TS/PHC register access.
- There is one lock for PHC operations and one for timestamping
  operations. The two are never used in the same function. We could use
  the same lock; introducing more waiting.
- There is one shared lock for GPIO operations. It is only used in
  PHC functions, in two places.

And I realized I can remove the locks from vsc8584_ptp_init, as PHC/TS
helpers are not registered until the PHY is initialized.

Thanks,
Antoine

-- 
Antoine Ténart, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2020-06-22 13:07 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-19 12:22 [PATCH net-next v3 0/8] net: phy: mscc: PHC and timestamping support Antoine Tenart
2020-06-19 12:22 ` [PATCH net-next v3 1/8] net: phy: add support for a common probe between shared PHYs Antoine Tenart
2020-06-20 14:49   ` Andrew Lunn
2020-06-19 12:22 ` [PATCH net-next v3 2/8] net: phy: mscc: fix copyright and author information in MACsec Antoine Tenart
2020-06-20 14:50   ` Andrew Lunn
2020-06-19 12:22 ` [PATCH net-next v3 3/8] net: phy: mscc: remove the TR CLK disable magic value Antoine Tenart
2020-06-20 14:52   ` Andrew Lunn
2020-06-22 12:49     ` Antoine Tenart
2020-06-19 12:22 ` [PATCH net-next v3 4/8] net: phy: mscc: take into account the 1588 block in MACsec init Antoine Tenart
2020-06-21 15:38   ` Quentin Schulz
2020-06-22 14:25     ` Antoine Tenart
2020-06-19 12:22 ` [PATCH net-next v3 5/8] net: phy: mscc: 1588 block initialization Antoine Tenart
2020-06-20 15:10   ` Andrew Lunn
2020-06-22 13:07     ` Antoine Tenart [this message]
2020-06-21 16:57   ` Quentin Schulz
2020-06-22 15:26     ` Antoine Tenart
2020-06-19 12:22 ` [PATCH net-next v3 6/8] net: phy: mscc: timestamping and PHC support Antoine Tenart
2020-06-20 15:00   ` Richard Cochran
2020-06-22 13:09     ` Antoine Tenart
2020-06-20 15:16   ` Andrew Lunn
2020-06-20 15:21   ` Andrew Lunn
2020-06-22 13:31     ` Antoine Tenart
2020-06-20 15:40   ` Andrew Lunn
2020-06-22 13:26     ` Antoine Tenart
2020-06-21 17:35   ` Quentin Schulz
2020-06-22 15:35     ` Antoine Tenart
2020-06-19 12:22 ` [PATCH net-next v3 7/8] dt-bindings: net: phy: vsc8531: document the load/save GPIO Antoine Tenart
2020-06-19 12:23 ` [PATCH net-next v3 8/8] MIPS: dts: ocelot: describe " Antoine Tenart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=159283122502.1456598.2577905456018345790@kwain \
    --to=antoine.tenart@bootlin.com \
    --cc=UNGLinuxDriver@microchip.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=allan.nielsen@microchip.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=foss@0leil.net \
    --cc=hkallweit1@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=richardcochran@gmail.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®