mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Lu Wei <luwei32@huawei.com>
To: <alex.hung@canonical.com>, <dvhart@infradead.org>,
	<andy@infradead.org>, <platform-driver-x86@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <acelan.kao@canonical.com>,
	<andy.shevchenko@gmail.com>, <luwei32@huawei.com>
Subject: [PATCH v3 2/2] intel-vbtn: Fix return value check in check_acpi_dev()
Date: Fri, 10 Jul 2020 17:04:23 +0800	[thread overview]
Message-ID: <1594371863-20827-3-git-send-email-luwei32@huawei.com> (raw)
In-Reply-To: <1594371863-20827-1-git-send-email-luwei32@huawei.com>

In the function check_acpi_dev(), if it fails to create
platform device, the return value is ERR_PTR() or NULL.
Thus it must use IS_ERR_OR_NULL to check return value.

Fixes: 332e0812 ("intel-vbtn: new driver for Intel Virtual Button")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Lu Wei <luwei32@huawei.com>
---
v2->v3
- Modify format

 drivers/platform/x86/intel-vbtn.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/platform/x86/intel-vbtn.c b/drivers/platform/x86/intel-vbtn.c
index b588093..e1aa526 100644
--- a/drivers/platform/x86/intel-vbtn.c
+++ b/drivers/platform/x86/intel-vbtn.c
@@ -251,7 +251,7 @@ check_acpi_dev(acpi_handle handle, u32 lvl, void *context, void **rv)
 		return AE_OK;

 	if (acpi_match_device_ids(dev, ids) == 0)
-		if (acpi_create_platform_device(dev, NULL))
+		if (!IS_ERR_OR_NULL(acpi_create_platform_device(dev, NULL)))
 			dev_info(&dev->dev,
 				 "intel-vbtn: created platform device\n");

--
2.7.4


  parent reply	other threads:[~2020-07-10  9:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-10  9:04 [PATCH v3 0/2] Fix return value check Lu Wei
2020-07-10  9:04 ` [PATCH v3 1/2] intel-hid: Fix return value check in check_acpi_dev() Lu Wei
2020-07-10  9:04 ` Lu Wei [this message]
2020-07-10  9:30 [PATCH v3 0/2] Fix return value check Lu Wei
2020-07-10  9:30 ` [PATCH v3 2/2] intel-vbtn: Fix return value check in check_acpi_dev() Lu Wei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1594371863-20827-3-git-send-email-luwei32@huawei.com \
    --to=luwei32@huawei.com \
    --cc=acelan.kao@canonical.com \
    --cc=alex.hung@canonical.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=andy@infradead.org \
    --cc=dvhart@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®