From: "Stephan Müller" <smueller@chronox.de>
To: Corentin Labbe <clabbe.montjoie@gmail.com>
Cc: herbert@gondor.apana.org.au, davem@davemloft.net,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] crypto: engine - Permit to enqueue skcipher request
Date: Tue, 06 Jun 2017 16:07:25 +0200 [thread overview]
Message-ID: <1595132.gd3LNaoxir@tauon.chronox.de> (raw)
In-Reply-To: <20170606134417.18850-3-clabbe.montjoie@gmail.com>
Am Dienstag, 6. Juni 2017, 15:44:17 CEST schrieb Corentin Labbe:
Hi Corentin,
> The crypto engine could actually only enqueue hash and ablkcipher request.
> This patch permit it to enqueue skcipher requets by adding all necessary
> functions.
> The only problem is that ablkcipher and skcipher id are the same, so
> only one cipher type is usable on the same crypto engine.
Why do you think this is needed? I thought that skcipher is the successor to
ablkcipher AND blkcipher. I.e. ablkcipher and blkcipher should be phased out.
Thus, I would infer that any ablkcipher support should or could be dropped.
Ciao
Stephan
next prev parent reply other threads:[~2017-06-06 14:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-06 13:44 [PATCH v2 0/2] " Corentin Labbe
2017-06-06 13:44 ` [PATCH v2 1/2] crypto: engine - replace pr_xxx by dev_xxx Corentin Labbe
2017-06-19 6:46 ` Herbert Xu
2017-06-06 13:44 ` [PATCH v2 2/2] crypto: engine - Permit to enqueue skcipher request Corentin Labbe
2017-06-06 14:07 ` Stephan Müller [this message]
2017-06-06 14:24 ` Corentin Labbe
2017-06-19 5:27 ` Herbert Xu
2017-06-19 7:55 ` Corentin Labbe
2017-06-23 6:48 ` Herbert Xu
2017-07-14 11:15 ` Corentin Labbe
2017-07-28 13:52 ` Herbert Xu
2017-07-28 15:01 ` Corentin Labbe
2017-08-09 9:40 ` Corentin Labbe
2017-08-21 15:07 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1595132.gd3LNaoxir@tauon.chronox.de \
--to=smueller@chronox.de \
--cc=clabbe.montjoie@gmail.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®