From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7E35C433DF for ; Tue, 28 Jul 2020 11:15:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BD43C20775 for ; Tue, 28 Jul 2020 11:15:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728991AbgG1LP1 (ORCPT ); Tue, 28 Jul 2020 07:15:27 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:8291 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728946AbgG1LP1 (ORCPT ); Tue, 28 Jul 2020 07:15:27 -0400 Received: from DGGEMS407-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 1965B9CA871939C9FC9A; Tue, 28 Jul 2020 19:15:23 +0800 (CST) Received: from huawei.com (10.175.101.6) by DGGEMS407-HUB.china.huawei.com (10.3.19.207) with Microsoft SMTP Server id 14.3.487.0; Tue, 28 Jul 2020 19:15:15 +0800 From: linmiaohe To: , , , , , , , CC: , Subject: [PATCH] sched: remove duplicated tick_nohz_full_enabled() check Date: Tue, 28 Jul 2020 19:17:55 +0800 Message-ID: <1595935075-14223-1-git-send-email-linmiaohe@huawei.com> X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.175.101.6] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Miaohe Lin The func tick_nohz_full_enabled() is also called by tick_nohz_full_cpu(). So this one is duplicated and should be removed. Signed-off-by: Miaohe Lin --- kernel/sched/sched.h | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h index 877fb08eb1b0..02028f785f87 100644 --- a/kernel/sched/sched.h +++ b/kernel/sched/sched.h @@ -1930,12 +1930,7 @@ extern int __init sched_tick_offload_init(void); */ static inline void sched_update_tick_dependency(struct rq *rq) { - int cpu; - - if (!tick_nohz_full_enabled()) - return; - - cpu = cpu_of(rq); + int cpu = cpu_of(rq); if (!tick_nohz_full_cpu(cpu)) return; -- 2.19.1