From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 68DBF1DF736 for ; Tue, 30 Dec 2025 13:07:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767100050; cv=none; b=fOemoEPulvm1dVh03gCz+nGubsg9lJFjRcNBbyellqwN2NPMmdYrr9eOme/1nEH1lWYZlrwIQPoF+n/o1yA+CX6fiGC1xLjbeFEFLWQtbbhceetGjGAuQbs5CB5iKu3vEqBGzPzKHcgeeQsSQYk27eeYG3INxToSniWI/fPPinw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767100050; c=relaxed/simple; bh=iH/SbC54DyFXpS+l6/ahq2usVBBuh9pGr9vAucj2Qrs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=LE/iRJCb/mKZO3w0sRPJqHFJrWBCQQnb7iJJeQwNrNlZ1+fG9s8xC9rPq0PffdEQK8q2J//pcsMdTHVyZAsXha/CGQ9SjUJVkZwzF4WvYrNIEOGWsKpUW7/YiD80X7xx43gG0M5qaIoCWd1nIFIUmyhoZhgrQb4m3d90KCf9z+M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=P0YidpJT; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Qvch7YAL; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="P0YidpJT"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Qvch7YAL" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BUB8lTw3971121 for ; Tue, 30 Dec 2025 13:07:28 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= XXMK/KNvJokGpNJ7WsGLfHm1jgTz/TRZoqblIdgBKBY=; b=P0YidpJT4tLlg6y7 PnA04i18vBaavxnKVzvUJdDuzv0H6Mi2JnpON8mr5bI8EWM1qVGu7xpp0dAe9WTg GJZF4wcz99Hm4e819Fl5KJQ/qgGs0G6cWJJjG76SnLbzul33lt4X/u9oflQL80ik l+UXgpOza6on2uXXPY9o5bvovYwtY/vcTo7IKXUVlrk3DQmmBZtBK0BpCMUj/LUf exQyjqe8iEJONZzmdT1xGbQko6e0tRRQlTo6ekLr612ZCm2COd9U7nAlCu9Ooiux wNE9YjVn2pBF88/VcrOnJPZHX8SHA/YRB4a+nrxICPWGJdz3LZG+SPQ+DC6UBhU+ SXCd1w== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bcdky080c-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 30 Dec 2025 13:07:28 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-4edaa289e0dso33508521cf.3 for ; Tue, 30 Dec 2025 05:07:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1767100047; x=1767704847; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=XXMK/KNvJokGpNJ7WsGLfHm1jgTz/TRZoqblIdgBKBY=; b=Qvch7YALTMOYC5n3Ltidcq7efMYaQSE6z3u6ScjH2DEiSPcb/3ic0FcaUIKM+ItfUb Y8XlTynOLeHsmqg5Jb5Uo6OwnwNgmBsBWJEcbiYC+MjB2MnH1a4zAROnuweanz9JDHjC ocUPwf7b6szjDDajRNQvBdVWKyBrv2wLD4Ze9FkrAOexmvdN5t0keJh9O3RxW6XA69VJ hXibCmRl/XbrJ8Mi1xULv+TSRjIl/WC7nA1DuakhUI4bEYtr1Pl1vo0nOnqW8A/lU2pd idQRJJEDcKuRUMFQSO221PWUgDCW/6XVeOGmXrZHR//idX4b5eYWwWy2bJBDMvH/GUUD 1ouA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767100047; x=1767704847; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=XXMK/KNvJokGpNJ7WsGLfHm1jgTz/TRZoqblIdgBKBY=; b=RH9Pjl3N+X0sEa/qOPaMTjcPW9Iu9Aveec7+Fb6h9E6XwJANLk3TCjk/3tNAQjXEmJ mBqY4eTdL500wTfboDpXawYw68+rQcqo99+9QTwBLsrtjshbclwTITJNeuwry06X0hbj OsyiIv4nn4SFwHAh+dbpKaksNdIBe4nrEGRQRpnRaGiZo7Xdxh6HvxcuRMh3vOQK/ZCB K6i31khyctoKjliZryusXLygcRjs7nM8YgQe3dxX1RAF5ICy7GPtwUoNNPTCSohrqGG4 Wks9dpZW6BG3v6/NDzCikPq3B/CxIIrSbMmzZidIxFc5M258H/obGCinAqMNDzeGh/ka LNtg== X-Forwarded-Encrypted: i=1; AJvYcCWKbzY0t++78xzJ0lsrtIsACxR5rjd28kIuO9wkB6ed5pypqeBmGcOEYpOaI4v72nB/buOjdkPodZ/Ztdw=@vger.kernel.org X-Gm-Message-State: AOJu0YxT/PJAaJ69NB73tw/unfBWuJYIHTE01ROQCu5+ajjG3IumNdz7 7zslQPwrJzNvudgRpMb59lm+Kfsrf18hUNq3U2yl4FG9zYIXkRjMTcA+h0brn//mn1lSMV28FK5 2pr1LsNvkZteovCQdZNN5EhCX1yQLpr73qgO1jnN7OfJHVhffs+zK0wveY6ugvR3mI6M= X-Gm-Gg: AY/fxX7AWJHHb0HpuyMb5WNCjx0SkY54JjPEdHMs6VaxcW+ur2BCt7/vaQyfDRMOmta 1LlJh9nv1aGkqO+m9a1cTiA1p8jUoENy8Ca6APXuq75nYmqweVVzSvgvH0NfiPnOeypE+eZBPnn AOMTsKO8fftzF6MzmU7q9fnRaUcKK8DEZ/nKDlW3AXId3LCp+OQs90FfSiS7sF8gQC1rftQsxLJ DdqvgxC27gK9oMHcw7rEnl49+oU1PyWo+T7GVv82Wja+O1p+32KQPotm0LJyq98jOgaIn25++8g rL0/u1dbNkcpU/TbEN4ZATZpSaapIStVJykl0Wyn1e7F8Hc+zKNp9nRsYh+AZviaYIct2rNEfbp zJiGc7QxlHBGY2fycr7cnkKUoqA7fRVtpDsd9RReclNIXD4IbCWUYn+ImWqUNx8y1ow== X-Received: by 2002:a05:622a:249:b0:4ee:1e33:bc45 with SMTP id d75a77b69052e-4f4abd3d611mr408882131cf.5.1767100047448; Tue, 30 Dec 2025 05:07:27 -0800 (PST) X-Google-Smtp-Source: AGHT+IHo+d4CC+cCCHywIIG3f9F/agTV5zHZGmRFIXu9W9+iV1sfY0qOVbKgOX04sqcJnmja84Syiw== X-Received: by 2002:a05:622a:249:b0:4ee:1e33:bc45 with SMTP id d75a77b69052e-4f4abd3d611mr408881301cf.5.1767100046874; Tue, 30 Dec 2025 05:07:26 -0800 (PST) Received: from [192.168.119.72] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8037f512e3sm3625336666b.67.2025.12.30.05.07.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Dec 2025 05:07:26 -0800 (PST) Message-ID: <1595f84b-91d0-4369-b1ff-713cf21472b1@oss.qualcomm.com> Date: Tue, 30 Dec 2025 14:07:23 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] arm64: dts: qcom: agatti: Address Gunyah memory alignment needs To: Sumit Garg Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, andersson@kernel.org, konradybcio@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, akhilpo@oss.qualcomm.com, vikash.garodia@oss.qualcomm.com, dikshita.agarwal@oss.qualcomm.com, robin.clark@oss.qualcomm.com, lumag@kernel.org, linux-kernel@vger.kernel.org, Sumit Garg References: <20251229071258.456254-1-sumit.garg@kernel.org> <20251229071258.456254-2-sumit.garg@kernel.org> <90264256-f53d-4a12-9b37-4cc43720c181@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjMwMDExOCBTYWx0ZWRfX2VLfs1WxxMRG ouyiXcuoHMGbpdjQE0aKqxY+Ty8uawQjpYJazzw7yaXrI6tJRvrpK6zs1/FbmX/pn3UDF84YrZJ XVn6xJGt1vroR7+kfFMdXG8ECpLJIMobMWfnp+0RJBqROxEE0mUYRRJtU03+GB8yktsAF2Tw+ij ef6qlqiXBponX5asJW0YW9Tj2BYRJOVSx2M8IUxSk+Kbv/vlwzCA9Mfhbz6OsPnqLCslPNQPulx bUr/yj4XZMzbRe+b1lcAhITro/O7bihvmCHY3oBa+q8z4cVmnVxKYw85aPMdGmwB837XfIl9crW VjW13g+PCFPjZUqO0BvrB1GPX/f4qBY/cNXFFYGJ/Q6wkHydgJ5AZBFDfcSb6kh3qtrBBEne6Qu PP1fm5yZV84NSfM4pyDovnsl8t4w/ERs7OUCdatlqKFqryxBiByDismfgnRwutBSxi1HGd4yQng /tCv8dKw3FDctLMKODw== X-Authority-Analysis: v=2.4 cv=Wskm8Nfv c=1 sm=1 tr=0 ts=6953ce90 cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=lTImZTorwxYyWPzu4DUA:9 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 X-Proofpoint-GUID: QtCdHN-04PLlWwQi7rbtOn9eABeEe4N6 X-Proofpoint-ORIG-GUID: QtCdHN-04PLlWwQi7rbtOn9eABeEe4N6 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-30_01,2025-12-30_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 spamscore=0 lowpriorityscore=0 priorityscore=1501 impostorscore=0 clxscore=1015 adultscore=0 bulkscore=0 phishscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512300118 On 12/30/25 5:46 AM, Sumit Garg wrote: > On Mon, Dec 29, 2025 at 01:43:18PM +0100, Konrad Dybcio wrote: >> On 12/29/25 8:12 AM, Sumit Garg wrote: >>> From: Sumit Garg >>> >>> Gunyah hypervisor requires it's memory start address to be 2MB aligned. >>> So the address map for Agatti is updated to incorporate that requirement. >>> This should be a backwards compatible DT change which should work with >>> legacy QHEE based firmware stack too. >>> >>> Signed-off-by: Sumit Garg >>> --- >>> arch/arm64/boot/dts/qcom/agatti.dtsi | 4 ++-- >>> 1 file changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/arch/arm64/boot/dts/qcom/agatti.dtsi b/arch/arm64/boot/dts/qcom/agatti.dtsi >>> index e705eb24160a..153916980ac0 100644 >>> --- a/arch/arm64/boot/dts/qcom/agatti.dtsi >>> +++ b/arch/arm64/boot/dts/qcom/agatti.dtsi >>> @@ -298,8 +298,8 @@ reserved_memory: reserved-memory { >>> #size-cells = <2>; >>> ranges; >>> >>> - hyp_mem: hyp@45700000 { >>> - reg = <0x0 0x45700000 0x0 0x600000>; >>> + hyp_mem: hyp@45600000 { >>> + reg = <0x0 0x45600000 0x0 0x700000>; >> >> On a second thought, please add a comment like: >> >> /* Gunyah requires the start of the region to be 2MiB-aligned, QHEE doesn't care */ >> >> to prevent someone "fixing" it in the future > > Sounds reasonable, I will add this comment on the next spin. I hope that > I can keep you review tag with comment added. Yeah, although as pointed out by the bot you'll need some bindings updates to match Konrad