From: Jiri Slaby <jslaby@suse.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Petr Mladek <pmladek@suse.com>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Steven Rostedt <rostedt@goodmis.org>,
linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-serial@vger.kernel.org
Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Subject: Re: [PATCH v1 1/6] mips: Return proper error code from console ->setup() hook
Date: Mon, 22 Jun 2020 06:50:57 +0200 [thread overview]
Message-ID: <15960896-3874-599c-6304-18b01ffd5c94@suse.com> (raw)
In-Reply-To: <20200618164751.56828-2-andriy.shevchenko@linux.intel.com>
On 18. 06. 20, 18:47, Andy Shevchenko wrote:
> For unifying console ->setup() handling, which is pure documented,
Did you mean s/pure/poorly/ in all the patches? Or purely? But then where?
> return error code, rather than non-zero arbitrary number.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
thanks,
--
js
suse labs
next prev parent reply other threads:[~2020-06-22 14:26 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-18 16:47 [PATCH v1 0/6] console: unify return codes from " Andy Shevchenko
2020-06-18 16:47 ` [PATCH v1 1/6] mips: Return proper error code from console " Andy Shevchenko
2020-06-19 8:37 ` Thomas Bogendoerfer
2020-06-22 4:50 ` Jiri Slaby [this message]
2020-06-22 14:36 ` Andy Shevchenko
2020-06-18 16:47 ` [PATCH v1 2/6] serial: sunsab: " Andy Shevchenko
2020-06-19 2:50 ` David Miller
2020-06-18 16:47 ` [PATCH v1 3/6] serial: sunzilog: " Andy Shevchenko
2020-06-19 2:50 ` David Miller
2020-06-18 16:47 ` [PATCH v1 4/6] tty: hvc: " Andy Shevchenko
2020-06-18 16:47 ` [PATCH v1 5/6] console: Propagate error code from console ->setup() Andy Shevchenko
2020-06-19 3:17 ` Benjamin Herrenschmidt
2020-06-18 16:47 ` [PATCH v1 6/6] console: Fix trivia typo 'change' -> 'chance' Andy Shevchenko
2020-06-19 3:17 ` Benjamin Herrenschmidt
2020-06-19 2:28 ` [PATCH v1 0/6] console: unify return codes from ->setup() hook Sergey Senozhatsky
2020-06-19 9:39 ` Petr Mladek
2020-06-19 9:47 ` Andy Shevchenko
2020-06-19 10:21 ` Sergey Senozhatsky
2020-06-19 11:26 ` Petr Mladek
2020-06-19 17:25 ` Sergey Senozhatsky
2020-06-25 13:41 ` Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15960896-3874-599c-6304-18b01ffd5c94@suse.com \
--to=jslaby@suse.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®