From: Trond Myklebust <trond.myklebust@fys.uio.no>
To: maneesh@in.ibm.com
Cc: Janet Morgan <janetmor@us.ibm.com>, linux-kernel@vger.kernel.org
Subject: Re: 2.5.62 Oops during nfs mount
Date: Mon, 24 Feb 2003 18:09:25 +0100 [thread overview]
Message-ID: <15962.20933.457919.169668@charged.uio.no> (raw)
In-Reply-To: <20030224123622.GB1103@in.ibm.com>
>>>>> " " == Maneesh Soni <maneesh@in.ibm.com> writes:
> Hi Janet,
> Following patch should fix this problem. I think Trond can say
> whether it is correct or not. In my opinion rpc_rmdir should
> test for negative dentry after lookup_hash() returns, like
> rpc_unlink() does.
No. You are 'fixing' a symptom of a more fundamental
bug/misunderstanding: lookup_path("") returns no error, and is
sometimes causing us to remove the top level directory.
See the 2-line patch I posted yesterday. It should fix the Oops you
are reporting.
Cheers,
Trond
next prev parent reply other threads:[~2003-02-24 16:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-02-22 2:50 Janet Morgan
2003-02-24 12:36 ` Maneesh Soni
2003-02-24 17:09 ` Trond Myklebust [this message]
2003-02-26 20:09 ` Janet Morgan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15962.20933.457919.169668@charged.uio.no \
--to=trond.myklebust@fys.uio.no \
--cc=janetmor@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maneesh@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®