mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Nikita Danilov <Nikita@Namesys.COM>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Oleg Drokin <green@namesys.com>, Andrew Morton <akpm@digeo.com>,
	mason@suse.com, trond.myklebust@fys.uio.no, jaharkes@cs.cmu.edu,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: 2.4 iget5_locked port attempt to 2.4
Date: Mon, 3 Mar 2003 18:35:53 +0300	[thread overview]
Message-ID: <15971.30297.165727.589583@laputa.namesys.com> (raw)
In-Reply-To: <1046708741.6509.5.camel@irongate.swansea.linux.org.uk>

Alan Cox writes:
 > On Mon, 2003-03-03 at 14:09, Oleg Drokin wrote:
 > > Hello!
 > > 
 > >    It's me again, I basically got no reply for this iget5_locked patch
 > >    I have now. Would there be any objections if I try push it to Marcelo
 > >    tomorrow? ;)
 > 
 > I just binned it. Certainly its not the kind of stuff I want to test in -ac, 
 > too many VFS changes outside reiserfs

In 2.4 there is a race when find_actor is used in conjunction with
->read_inode2, because inode_lock is released before calling
->read_inode2 and hence, find_actor cannot safely rely on
initialisations of inode's private part done in ->read_inode2. This is
why in 2.5 iget5_locked takes special "set" callback that is called from
under inode_lock. It so happened that reiserfs is the only (is it?) file
system that used both find_actor and ->read_inode2, but whole API is
just broken and should be fixed.

 > 

Nikita.

  reply	other threads:[~2003-03-03 15:25 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20030220175309.A23616@namesys.com>
     [not found] ` <20030220154924.7171cbd7.akpm@digeo.com>
2003-02-21 19:03   ` Oleg Drokin
2003-02-21 20:04     ` Jan Harkes
2003-02-22  9:29       ` Oleg Drokin
2003-02-24 10:21       ` 2.4 iget5_locked port attempt to 2.4 (supposedly fixed NFS version this time) Oleg Drokin
2003-02-24 16:50         ` Trond Myklebust
2003-02-24 17:02           ` Trond Myklebust
2003-02-24 17:03           ` Oleg Drokin
2003-02-24 17:17             ` Trond Myklebust
2003-02-24 17:26               ` Oleg Drokin
2003-02-24 17:33                 ` Trond Myklebust
2003-02-24 17:38                   ` Oleg Drokin
2003-03-03 14:09       ` 2.4 iget5_locked port attempt to 2.4 Oleg Drokin
2003-03-03 16:25         ` Alan Cox
2003-03-03 15:35           ` Nikita Danilov [this message]
2003-03-03 15:38           ` Oleg Drokin
2003-03-03 15:57             ` Anton Altaparmakov
2003-03-03 16:04               ` Oleg Drokin
2003-03-03 16:27                 ` Anton Altaparmakov
2003-03-03 16:45                   ` Oleg Drokin
2003-03-03 16:50             ` Jan Harkes
2003-03-03 16:57               ` Oleg Drokin
2003-03-03 17:23               ` Jan Harkes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=15971.30297.165727.589583@laputa.namesys.com \
    --to=nikita@namesys.com \
    --cc=akpm@digeo.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=green@namesys.com \
    --cc=jaharkes@cs.cmu.edu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mason@suse.com \
    --cc=trond.myklebust@fys.uio.no \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®