From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42236C433E3 for ; Wed, 12 Aug 2020 07:55:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1D47F206B5 for ; Wed, 12 Aug 2020 07:55:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597218911; bh=P6v+unw8+Cq8ugJxHQzeI6KhK1z9BDyKTl+itDIq89k=; h=In-Reply-To:References:Subject:From:Cc:To:Date:List-ID:From; b=o9TWoPxg1+OFl0S0FTjzhZ9nTGeyfYk3vx2cnrHv1NBX6jpfTxqN4yEbZeQfxHi/i pL0fBm3TwNnKp5hnMvHC1c8S2EBFNNqxNprpC/i5rq0VkEPr+gz8CwhEjLAB7bfEg4 7+DTsJ/niNlRYsySq0w6vX/cmJ0m47J1xqEKs83A= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726891AbgHLHzK (ORCPT ); Wed, 12 Aug 2020 03:55:10 -0400 Received: from mail.kernel.org ([198.145.29.99]:36684 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726572AbgHLHzI (ORCPT ); Wed, 12 Aug 2020 03:55:08 -0400 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 24422206B5; Wed, 12 Aug 2020 07:55:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597218908; bh=P6v+unw8+Cq8ugJxHQzeI6KhK1z9BDyKTl+itDIq89k=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=eOxt9MNuhj1cKk0d5xTG90fjv0Ctty4ZGqOeO2Uh8PQvh/gnvfwuoW182bRg4EhJx FQBDOXTBDiSwUYMd0LkjiKTbvaeBUQ0tKBnrBuZgzho8dt4Pjd+ybugBmm+8dR20uS PHHnlfiCpdWDRX9zIYK6HhKBPLdPuD54Vw9CGdXU= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20200806182059.2431-6-krzk@kernel.org> References: <20200806181932.2253-1-krzk@kernel.org> <20200806182059.2431-6-krzk@kernel.org> Subject: Re: [PATCH v2 06/41] ARM: s3c24xx: pass pointer to clk driver via platform data From: Stephen Boyd Cc: Arnd Bergmann , Krzysztof Kozlowski , Russell King , Sylwester Nawrocki , Tomasz Figa , Chanwoo Choi , Michael Turquette , Kukjin Kim , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org To: Krzysztof Kozlowski , linux-kernel@vger.kernel.org Date: Wed, 12 Aug 2020 00:55:07 -0700 Message-ID: <159721890703.33733.8378221902467604348@swboyd.mtv.corp.google.com> User-Agent: alot/0.9.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Krzysztof Kozlowski (2020-08-06 11:20:23) > Passing pointers directly as platform data is fragile and undocumented. > Better to create a platform data structure which explicitly documents > what is passed to the driver. >=20 > Suggested-by: Tomasz Figa > [krzk: Update maintainer's entry] > Signed-off-by: Krzysztof Kozlowski >=20 > --- Ok. Reviewed-by: Stephen Boyd