From: "tip-bot2 for Chris Down" <tip-bot2@linutronix.de>
To: linux-tip-commits@vger.kernel.org
Cc: Chris Down <chris@chrisdown.name>, Borislav Petkov <bp@suse.de>,
x86 <x86@kernel.org>, LKML <linux-kernel@vger.kernel.org>
Subject: [tip: x86/misc] x86/msr: Make source of unrecognised MSR writes unambiguous
Date: Sat, 22 Aug 2020 09:42:41 -0000 [thread overview]
Message-ID: <159808936198.3192.9491971431453881525.tip-bot2@tip-bot2> (raw)
In-Reply-To: =?utf-8?q?=3C6f6fbd0ee6c99bc5e47910db700a6642159db01b=2E15980?= =?utf-8?q?11595=2Egit=2Echris=40chrisdown=2Ename=3E?=
The following commit has been merged into the x86/misc branch of tip:
Commit-ID: c31feed8461fb8648075ba9b53d9e527d530972f
Gitweb: https://git.kernel.org/tip/c31feed8461fb8648075ba9b53d9e527d530972f
Author: Chris Down <chris@chrisdown.name>
AuthorDate: Fri, 21 Aug 2020 13:10:35 +01:00
Committer: Borislav Petkov <bp@suse.de>
CommitterDate: Sat, 22 Aug 2020 11:40:38 +02:00
x86/msr: Make source of unrecognised MSR writes unambiguous
In many cases, task_struct.comm isn't enough to distinguish the
offender, since for interpreted languages it's likely just going to be
"python3" or whatever. Add the pid to make it unambiguous.
[ bp: Make the printk string a single line for easier grepping. ]
Signed-off-by: Chris Down <chris@chrisdown.name>
Signed-off-by: Borislav Petkov <bp@suse.de>
Link: https://lkml.kernel.org/r/6f6fbd0ee6c99bc5e47910db700a6642159db01b.1598011595.git.chris@chrisdown.name
---
arch/x86/kernel/msr.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/x86/kernel/msr.c b/arch/x86/kernel/msr.c
index b03001d..c0d4098 100644
--- a/arch/x86/kernel/msr.c
+++ b/arch/x86/kernel/msr.c
@@ -102,8 +102,8 @@ static int filter_write(u32 reg)
if (reg == MSR_IA32_ENERGY_PERF_BIAS)
return 0;
- pr_err("Write to unrecognized MSR 0x%x by %s\n"
- "Please report to x86@kernel.org\n", reg, current->comm);
+ pr_err("Write to unrecognized MSR 0x%x by %s (pid: %d). Please report to x86@kernel.org.\n",
+ reg, current->comm, current->pid);
return 0;
}
reply other threads:[~2020-08-22 9:42 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=159808936198.3192.9491971431453881525.tip-bot2@tip-bot2 \
--to=tip-bot2@linutronix.de \
--cc=bp@suse.de \
--cc=chris@chrisdown.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®