mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Yang Shen <shenyang39@huawei.com>
To: <herbert@gondor.apana.org.au>, <davem@davemloft.net>
Cc: <linux-kernel@vger.kernel.org>, <linux-crypto@vger.kernel.org>,
	<xuzaibo@huawei.com>, <wangzhou1@hisilicon.com>
Subject: [PATCH v2 04/10] crypto: hisilicon/zip - replace 'sprintf' with 'scnprintf'
Date: Mon, 7 Sep 2020 16:21:56 +0800	[thread overview]
Message-ID: <1599466922-10323-5-git-send-email-shenyang39@huawei.com> (raw)
In-Reply-To: <1599466922-10323-1-git-send-email-shenyang39@huawei.com>

Replace 'sprintf' with 'scnprintf' to avoid overrun.

Signed-off-by: Yang Shen <shenyang39@huawei.com>
Reviewed-by: Zhou Wang <wangzhou1@hisilicon.com>
---
 drivers/crypto/hisilicon/zip/zip_main.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/crypto/hisilicon/zip/zip_main.c b/drivers/crypto/hisilicon/zip/zip_main.c
index df1a16f..dd2c326 100644
--- a/drivers/crypto/hisilicon/zip/zip_main.c
+++ b/drivers/crypto/hisilicon/zip/zip_main.c
@@ -428,7 +428,7 @@ static ssize_t hisi_zip_ctrl_debug_read(struct file *filp, char __user *buf,
 		return -EINVAL;
 	}
 	spin_unlock_irq(&file->lock);
-	ret = sprintf(tbuf, "%u\n", val);
+	ret = scnprintf(tbuf, sizeof(tbuf), "%u\n", val);
 	return simple_read_from_buffer(buf, count, pos, tbuf, ret);
 }
 
@@ -518,9 +518,10 @@ static int hisi_zip_core_debug_init(struct hisi_qm *qm)
 
 	for (i = 0; i < HZIP_CORE_NUM; i++) {
 		if (i < HZIP_COMP_CORE_NUM)
-			sprintf(buf, "comp_core%d", i);
+			scnprintf(buf, sizeof(buf), "comp_core%d", i);
 		else
-			sprintf(buf, "decomp_core%d", i - HZIP_COMP_CORE_NUM);
+			scnprintf(buf, sizeof(buf), "decomp_core%d",
+				  i - HZIP_COMP_CORE_NUM);
 
 		regset = devm_kzalloc(dev, sizeof(*regset), GFP_KERNEL);
 		if (!regset)
-- 
2.7.4


  parent reply	other threads:[~2020-09-07  8:25 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-07  8:21 [PATCH v2 00/10] crypto: hisilicon/zip - misc clean up Yang Shen
2020-09-07  8:21 ` [PATCH v2 01/10] crypto: hisilicon/zip - remove some useless parameters Yang Shen
2020-09-07  8:21 ` [PATCH v2 02/10] crypto: hisilicon/zip - unify naming style for functions and macros Yang Shen
2020-09-07  8:21 ` [PATCH v2 03/10] crypto: hisilicon/zip - modify debugfs interface parameters Yang Shen
2020-09-07  8:21 ` Yang Shen [this message]
2020-09-07  8:21 ` [PATCH v2 05/10] crypto: hisilicon/zip - use a enum parameter instead of some macros Yang Shen
2020-09-07  8:21 ` [PATCH v2 06/10] crypto: hisilicon/zip - add print for error branch Yang Shen
2020-09-07  8:21 ` [PATCH v2 07/10] crypto: hisilicon/zip - fix static check warning Yang Shen
2020-09-07  8:22 ` [PATCH v2 08/10] crypto: hisilicon/zip - move some private macros from 'zip.h' to 'zip_crypto.c' Yang Shen
2020-09-07  8:22 ` [PATCH v2 09/10] crypto: hisilicon/zip - supplement some comments Yang Shen
2020-09-07  8:22 ` [PATCH v2 10/10] crypto: hisilicon/zip - fix some coding styles Yang Shen
2020-09-18  7:28 ` [PATCH v2 00/10] crypto: hisilicon/zip - misc clean up Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1599466922-10323-5-git-send-email-shenyang39@huawei.com \
    --to=shenyang39@huawei.com \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=wangzhou1@hisilicon.com \
    --cc=xuzaibo@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®