From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=205.220.180.131 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794540905; b=Jwt0doP8/x6+fRTbIXYhJ6P1gs31LAsufZZAL7+1VUU7IOnhinvnMI+FsboMht+2E8h9 Jrhe/Ot9AcBjPFSXay0tMO2zxLo95NAGD7DIKPeWQBRk+ehfXrx72krrZWRbDr5SlwaIt ZUTL6228oKMbbGE/B8BsG13rjwHO6FsSr7lnmfAJeP0xH5a58WxyoKlu0IsDAOVPD/c2i BKMzPIAmZjkC1dU601qN4apSTN4/Yg2yjHXM9RYTsdwbpDbAY2i3wdNAvLhxUhd5fuASR c/s5C2c/RS5vLnMlfSUMVlXRfQHWdTx/Ht62z7vu/VSkM3tUQFZFj8BMo69fiZYROXQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794540905; h=DMARC-Filter:Received:DKIM-Signature:Received:Received: DKIM-Signature:X-Google-DKIM-Signature:X-Forwarded-Encrypted: X-Gm-Message-State:X-Gm-Gg:X-Received:X-Received:Received:Message-ID: Date:MIME-Version:User-Agent:Subject:To:Cc:References: Content-Language:From:In-Reply-To:Content-Type: Content-Transfer-Encoding:X-Proofpoint-GUID:X-Proofpoint-Spam-Info: X-Proofpoint-Spam-Details-Enc:X-Proofpoint-ORIG-GUID: X-Authority-Analysis:X-Proofpoint-Virus-Version: X-Proofpoint-Spam-Details; bh=IPZ3HOktLUKO7C6+7rK8PWwT7CibQnKEc7TizM3393o=; b=WRpf7gtkNYEoNUR/Ph8nzxOyhsmpgUTm0YJKXFX3RjD0rVeJfy9dlSFqPTM960/++QF2 hgAVF8Xpuzx5NoZI6jLIeU8D7bWjV163KRGReLrI07HRU3kO8c5/0GJ4bzQsnrjVtOAKy RYxSBwh6rYeob9yVUbjVnvYBXE889FKa7t3pITMuERhv1++Wq9YAxEMCTzVrX3uhhPkbA KrRdjMwppE1AehbQpZowRTrdj2urEHOpiQa1YnsIJFiL4TWhWpEF8iryMEZa7aajMi4Yw LvZz6IzC9nQEbVAt6rmbuZNxl5b0rW/i+UxQGBy4RcUgrNbpN/6QKxLMDnri8+wCzCA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=gRnXIVRB; dkim=pass header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=PTaLV2oO; arc=none smtp.remote-ip=205.220.180.131 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0FD95606A31C for ; Fri, 13 Nov 2026 03:35:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 0FD95606A31C Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=gRnXIVRB; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=PTaLV2oO Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6AD2K6Rv2843412 for ; Fri, 13 Nov 2026 03:35:04 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= IPZ3HOktLUKO7C6+7rK8PWwT7CibQnKEc7TizM3393o=; b=gRnXIVRBJDeM8ySw aPNieEiH7Q31za35m7BrDXSXEwzVomjsjQmGkm4/SgoUxgWkcCtfB99OQ5Wlez8X p9Avu5YAaCgt5F/3mUxfJKrMz3MVgU3cglt6YLqxcYi4++JGPGeE1Y+eNB1RfbiF IldTPCGIsLsb0GZL+cK3UUv/y2gmhXNyhvVqhhvROtlbLIONAp/gGQOABiUI4+ly +eSxZJxnhnrFlgzT2lAyrrN7M8gC+r7K873liA/SHsrV+fN8oTsW70bHscT1jGgG Jav1fzcVOB5XlpJ6DVvZSPVnbZv+aDbbCyjNq3plOrf3KVAuTOtJFOQCjQQRstLe 8ppyDA== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4hwan4uf7s-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 13 Nov 2026 03:35:03 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2eddadcce7cso3397135ad.2 for ; Thu, 12 Nov 2026 19:35:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1794540903; x=1795145703; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=IPZ3HOktLUKO7C6+7rK8PWwT7CibQnKEc7TizM3393o=; b=PTaLV2oOe3UKjSpdSc2iI73FcRNBDEWGiPqwIg+uPoJjTj9JmjbHf5BccxN3dpSgDK YRQYmJ3P9kZDUMYkZG/JBG6UB9Mg8M/B2qJGCP3PvORsfJOcPknJEn7hYwiTDYz00RS8 GcBCrI/eGVqXgJa41vBvnvnrVqUdHHl5tdKQgO62tbZ7zaGjCXG8jRLY2KXpEg9Cafyi F3rRyqiIzDyJ7lXZmhRFwkkTFH1ZNEB2Fx26g9t7Z56eLx1hthODRXG69Ro6i97bEMCk TtXb9CZ1Vi+AD1Mj88XbivvmOrKeaVTVudNJpl9Cn8tEA7Zu66pEIXMWu/1+8VUyuAtr NWKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794540903; x=1795145703; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=IPZ3HOktLUKO7C6+7rK8PWwT7CibQnKEc7TizM3393o=; b=QSrmMAWhHNi5Ul5QHmi1ThxOO9DfsawV/DBWn1QWxsfQcggzlKCR7riq0lEtcg2YOk pGtDoG6bmWlyoD3Le2EySubPfLpKHnnE2dbjGrHpL3Fr8uA7h/K6RqzU3AZh9dJqRk4Y MyO5LlRJ/FLHjl6prSwupZDY+8uukD5BLR6k6Vx1JcXSO9qJOWvOrCB1nJF7BTifZtLP +ezzpJPfGG7oaVnvsO5ixmek/ermys74vTNsKdFV+4yLhKX9w8VDueLcPipkMLQEaZ7m k2F7Emh7H14l7yRj2IQmgV143/lXtYzwBBIL+rxexPxiuVCKhtgksxVXwhXIrlWJukeG d5yw== X-Forwarded-Encrypted: i=1; AL+hErH7kibsZXzWsg2BBm6d4hlIcOJI4mForQGaD3jEksOZAqzbjCF6icSDVI6SdZfJ06telok14FPgz+1mQ/E=@vger.kernel.org X-Gm-Message-State: APuU4Z+7DZJQyZzSzRkaOvDl5RA2ro2/clfVecEQAo+cw5hrHK7ZyXD2 krfl6+DUrM+Ww/PLyNuDgAsTOfsImBXYvnloL001rt97n6JkelrmmF1phfyTML+1qpWuvJe1fPU U3xh4jAOV79YGnv/0OKyLntaqIeJE2gJroCbL5hzi4/h/K7MdIj5uQgCnEY8t2l7kGGA= X-Gm-Gg: AYBFou1j4Jc9rxO4ajXYuqcKnsZcJS9/SKaAD3HNMigk59V+2BI5hPuuTaEVGaoj1xu VLQ/iLanDhXxMemKUg0aJNdMhluD4yPo1fRY2kbKG14Kv0Vx5uI8wjg0ScSLVu5Je6MIQRSff7G ruehzNRFe1SSMIWKHJZ+WFPLhwThVRfYtflxnLgH6MdYsdb9MKMJ0BulhEewtvFjLZpnXh0H04O 8UTBFMpgbTKZOIoDlP5CeJhVRfjsX1H+wfDMtd95hqQI9pbut8JG4zatU5Xz+GHq4mpunm5X1Cz IxIQLBvtdss7VqByCYIh40F33Q9B42kbj9rYXACBgO5ptX4gbHzMNqikaR3TM3aM46Ev5+XgF+D 331kTTHcdMGg2XMfV9QfbVuJF741xSRVryPMQnGpYafNFwHm8vh1Nt/I1EDt/mRcX3ydu9Q== X-Received: by 2002:a17:902:e882:b0:2e8:3d48:4d88 with SMTP id d9443c01a7336-2ee0da31ea2mr13290395ad.7.1794540902804; Thu, 12 Nov 2026 19:35:02 -0800 (PST) X-Received: by 2002:a17:902:e882:b0:2e8:3d48:4d88 with SMTP id d9443c01a7336-2ee0da31ea2mr13290065ad.7.1794540902273; Thu, 12 Nov 2026 19:35:02 -0800 (PST) Received: from [10.235.8.108] ([114.94.8.21]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ee0f7e4e47sm3464175ad.38.2026.11.12.19.34.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Nov 2026 19:35:01 -0800 (PST) Message-ID: <15996045-3f5e-4680-95f9-925c97301ab0@oss.qualcomm.com> Date: Fri, 13 Nov 2026 11:34:53 +0800 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/3] dt-bindings: clock: qcom: Add NSS clock controller for IPQ5210 SoC To: Krzysztof Kozlowski Cc: Bjorn Andersson , Abel Vesa , Stephen Boyd , Brian Masney , Jerome Brunet , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Georgi Djakov , Philipp Zabel , Richard Cochran , Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, netdev@vger.kernel.org, quic_kkumarcs@quicinc.com, quic_linchen@quicinc.com, quic_leiwei@quicinc.com References: <20261111-qcom_ipq5210_nsscc-v2-0-7e2c1dda3ed2@oss.qualcomm.com> <20261111-qcom_ipq5210_nsscc-v2-1-7e2c1dda3ed2@oss.qualcomm.com> <20261112-wild-accurate-cockatrice-a80efa@quoll> Content-Language: en-US From: Jie Luo In-Reply-To: <20261112-wild-accurate-cockatrice-a80efa@quoll> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: ShUKz1TRVBTcf_Gx_PvCaG3eMffuaFyM X-Proofpoint-Spam-Info: AW1haW4tMjYxMTEzMDAxNCBTYWx0ZWRfX5s1DOHC5koLb Xr4l3zJTSA50YpW6d8HB/K6fQL3BaQJUOyKYTD09X+qFP+ag94h4zfHZY3gvaJXlrRsZmCZEOI0 onY8TxLglQVv0mfKoeP+XOn9x/72fYc= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMTEzMDAxNCBTYWx0ZWRfX0adgelVI8uuJ RauvZtoQd5ZTg3g7LRwOzEfVhulmEZNumoElWoH6WKNdJu5cm7G6DxwmH2IJK6LvZFFbTkUoL0a F+WHhQadfqsZAIpgMuvPhCbTNXfvKoTbNTc1pEq5/7waqGinFftXxkVrr5KccR4psv553XcTDuv 9NG/U4we+ZB/MCK2esk9PleX6Qfcwgf8d9l9PzfZ6pAg1j7jrgZhOqYYERPIedbDHVxT55oWGQS ZSmOX3LKVo3Jo/YLJzf3uj11GAyJ7Xh0uTvbdi0Y4ikHNgMuBNMJbmL/jBCB04uweFItvzvh/qT gEQZda3hMq6AoaAiSOyS/j8EVq5p2miGM9PnEqtngGA0yLjBWV7xD8GRpc4CLfDGB+rWd38cHVT b7yO+jeweJYsDg00qpWquM9uSTI94juPijOcHWZSm8zdh8YIShQPTM5YT/J1k9AyKYAFzhVDzey NWAneT1WjPIyFxI+RDw== X-Proofpoint-ORIG-GUID: ShUKz1TRVBTcf_Gx_PvCaG3eMffuaFyM X-Authority-Analysis: v=2.4 cv=Gd+CDgXL c=1 sm=1 tr=0 ts=6af68567 cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=Uz3yg00KUFJ2y2WijEJ4bw==:17 a=IkcTkHD0fZMA:10 a=zJRp6_cAMcgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=gEfo2CItAAAA:8 a=EUspDBNiAAAA:8 a=VwQbUJbxAAAA:8 a=vjzNbMJ68Ufz2hOSJBcA:9 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 a=sptkURWiP4Gy88Gu7hUp:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.138,FMLib:17.12.100.49 definitions=2026-11-13_01,2026-11-11_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 lowpriorityscore=0 priorityscore=1501 spamscore=0 clxscore=1015 malwarescore=0 phishscore=0 suspectscore=0 impostorscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2611040001 definitions=main-2611130014 On 11/12/2026 6:57 PM, Krzysztof Kozlowski wrote: > On Wed, Nov 11, 2026 at 02:00:55AM -0800, Luo Jie wrote: >> NSS clock controller provides the clocks and resets to the networking >> blocks such as PPE (Packet Process Engine), UNIPHY (PCS) and EPHY on >> IPQ5210 devices. >> >> Add support for the compatible string "qcom,ipq5210-nsscc" based on the >> existing IPQ9574/IPQ5424 NSS clock controller Device Tree binding. IPQ5210 >> additionally exposes a pair of EPHY-RAW Rx/Tx clock sources used to derive >> the clocks for its integrated 2.5G Ethernet PHY, so extend the clocks and >> clock-names lists with "ephy_rx" and "ephy_tx". >> >> Also add master/slave ids for IPQ5210 networking interfaces, which are used >> by the nsscc-ipq5210 driver for providing interconnect services using the >> icc-clk framework. >> >> Signed-off-by: Luo Jie >> --- >> .../bindings/clock/qcom,ipq9574-nsscc.yaml | 47 ++++++++- >> include/dt-bindings/clock/qcom,ipq5210-nsscc.h | 106 +++++++++++++++++++++ >> include/dt-bindings/interconnect/qcom,ipq5210.h | 18 ++++ >> include/dt-bindings/reset/qcom,ipq5210-nsscc.h | 60 ++++++++++++ >> 4 files changed, 228 insertions(+), 3 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/clock/qcom,ipq9574-nsscc.yaml b/Documentation/devicetree/bindings/clock/qcom,ipq9574-nsscc.yaml >> index a35bbc7b1924..dc7d90a99dc7 100644 >> --- a/Documentation/devicetree/bindings/clock/qcom,ipq9574-nsscc.yaml >> +++ b/Documentation/devicetree/bindings/clock/qcom,ipq9574-nsscc.yaml >> @@ -4,24 +4,28 @@ >> $id: http://devicetree.org/schemas/clock/qcom,ipq9574-nsscc.yaml# >> $schema: http://devicetree.org/meta-schemas/core.yaml# >> >> -title: Qualcomm Networking Sub System Clock & Reset Controller on IPQ9574 and IPQ5424 >> +title: Qualcomm Networking Sub System Clock & Reset Controller on IPQ SoCs >> >> maintainers: >> - Bjorn Andersson >> + - Luo Jie >> >> description: | >> Qualcomm networking sub system clock control module provides the clocks, >> - resets on IPQ9574 and IPQ5424 >> + resets on IPQ9574, IPQ5424 and IPQ5210 >> >> See also: >> + include/dt-bindings/clock/qcom,ipq5210-nsscc.h >> include/dt-bindings/clock/qcom,ipq5424-nsscc.h >> include/dt-bindings/clock/qcom,ipq9574-nsscc.h >> + include/dt-bindings/reset/qcom,ipq5210-nsscc.h >> include/dt-bindings/reset/qcom,ipq5424-nsscc.h >> include/dt-bindings/reset/qcom,ipq9574-nsscc.h >> >> properties: >> compatible: >> enum: >> + - qcom,ipq5210-nsscc >> - qcom,ipq5424-nsscc >> - qcom,ipq9574-nsscc >> >> @@ -42,6 +46,9 @@ properties: >> - description: Uniphy2 NSS Rx clock source >> - description: Uniphy2 NSS Tx clock source >> - description: GCC NSSCC clock source >> + - description: CMN_PLL EPHY-RAW Rx clock source >> + - description: CMN_PLL EPHY-RAW Tx clock source >> + minItems: 11 > > Please place minItems at the beginning, before "items:". Thanks, I will move minItems before "items:" in the next version. > >> >> '#interconnect-cells': >> const: 1 >> @@ -63,6 +70,9 @@ properties: >> - const: uniphy2_rx >> - const: uniphy2_tx >> - const: bus >> + - const: ephy_rx >> + - const: ephy_tx >> + minItems: 11 > > Same here OK. > > Reviewed-by: Krzysztof Kozlowski > > Best regards, > Krzysztof >