From: "Drokin, Oleg" <oleg.drokin@intel.com>
To: Tal Shorer <tal.shorer@gmail.com>
Cc: "<linux-kernel@vger.kernel.org>" <linux-kernel@vger.kernel.org>,
"Dilger, Andreas" <andreas.dilger@intel.com>,
"<gregkh@linuxfoundation.org>" <gregkh@linuxfoundation.org>,
"<dan.carpenter@oracle.com>" <dan.carpenter@oracle.com>,
"<luca@lucaceresoli.net>" <luca@lucaceresoli.net>,
"<clabbe.montjoie@gmail.com>" <clabbe.montjoie@gmail.com>,
"<PDD-discuss@lists.01.org>" <PDD-discuss@ml01.01.org>,
"<devel@driverdev.osuosl.org>" <devel@driverdev.osuosl.org>
Subject: Re: [PATCH] staging: lustre: fix coding style errors in drivers/staging/lustre/lustre/libcfs/linux/linux-proc.c
Date: Thu, 5 Feb 2015 22:28:16 +0000 [thread overview]
Message-ID: <159DFFC6-C7C3-4A11-9612-595984C9F4C3@intel.com> (raw)
In-Reply-To: <1423174065-10829-1-git-send-email-tal.shorer@gmail.com>
On Feb 5, 2015, at 5:07 PM, Tal Shorer wrote:
> Signed-off-by: Tal Shorer <tal.shorer@gmail.com>
> ---
> drivers/staging/lustre/lustre/libcfs/linux/linux-proc.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/lustre/lustre/libcfs/linux/linux-proc.c b/drivers/staging/lustre/lustre/libcfs/linux/linux-proc.c
> index c539e37..acc2e10 100644
> --- a/drivers/staging/lustre/lustre/libcfs/linux/linux-proc.c
> +++ b/drivers/staging/lustre/lustre/libcfs/linux/linux-proc.c
> @@ -65,7 +65,7 @@
> #include <asm/div64.h>
> #include "../tracefile.h"
>
> -static struct ctl_table_header *lnet_table_header = NULL;
> +static struct ctl_table_header *lnet_table_header;
> extern char lnet_upcall[1024];
> /**
> * The path of debug log dump upcall script.
> @@ -165,7 +165,7 @@ static int proc_dobitmasks(struct ctl_table *table, int write,
> __proc_dobitmasks);
> }
>
> -static int min_watchdog_ratelimit = 0; /* disable ratelimiting */
> +static int min_watchdog_ratelimit; /* disable ratelimiting */
I think you just made this comment nonsensical by this change.
= 0 is explained as that disables the rate limiting. With no assignment (I know it's a noop)
it's now unclear what does the comment says and possibly needs to be expanded to
say something like "0 to disable ratelimiting" or the like, but it's less readable.
> static int max_watchdog_ratelimit = (24*60*60); /* limit to once per day */
In reality these two "variables" are nothing more than constants, they are never changed too.
Their only purpose is to be fed into procfs code (proc_dointvec_minmax) to know the range
of values to accepted.
As such spelling them out makes the most sense in my view.
The rest of the patch I think is good.
Thanks.
> static int __proc_dump_kernel(void *data, int write,
> @@ -308,7 +308,7 @@ static int proc_console_backoff(struct ctl_table *table, int write,
> dummy.proc_handler = &proc_dointvec;
>
> if (!write) { /* read */
> - backoff= libcfs_console_backoff;
> + backoff = libcfs_console_backoff;
> rc = proc_dointvec(&dummy, write, buffer, lenp, ppos);
> return rc;
> }
> --
> 2.2.2
>
prev parent reply other threads:[~2015-02-05 22:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-05 22:07 Tal Shorer
2015-02-05 22:28 ` Drokin, Oleg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=159DFFC6-C7C3-4A11-9612-595984C9F4C3@intel.com \
--to=oleg.drokin@intel.com \
--cc=PDD-discuss@ml01.01.org \
--cc=andreas.dilger@intel.com \
--cc=clabbe.montjoie@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca@lucaceresoli.net \
--cc=tal.shorer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®