From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2BF3CE7A81 for ; Mon, 25 Sep 2023 14:14:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232251AbjIYOPE (ORCPT ); Mon, 25 Sep 2023 10:15:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59844 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232223AbjIYOPB (ORCPT ); Mon, 25 Sep 2023 10:15:01 -0400 Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [IPv6:2a00:1450:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9F1D2107 for ; Mon, 25 Sep 2023 07:14:54 -0700 (PDT) Received: by mail-ej1-x635.google.com with SMTP id a640c23a62f3a-98377c5d53eso782989266b.0 for ; Mon, 25 Sep 2023 07:14:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1695651293; x=1696256093; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=MKU4CV4EpJVB4FTlihc7/XBzOgjH8T7yUhxDn98BGzs=; b=J8bQqgnUDZIAw+6W2oNNin+HUsDZioo/sPQIrbjJyr2DgbRdKd1/JVSz7yPwtG6IPc xt6dG1XsfGjcSW6Yzkz/XlaSrnWBiDccUHuBDtlOylbkSL/yD65hLmPvPmpvDjpqEL/J zN7gZ+yyctQNFYL34L995tO3X7BBJaohpEh3MienPyYt0HZFos1zS38SAIqM9/t6zCsD LTtBCbNcTtsVX5PKHeO8t3J+APIin1LyDvkH5I/4Peq0dxdA6GgQr5jJIYePGYBPHrRN qaoai8vKkeGRY5LeiznjurNfMhaL11xgFUlKUn92oVrlZG2EPxMsOdaFAVw4/kLiDvGA QbkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695651293; x=1696256093; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=MKU4CV4EpJVB4FTlihc7/XBzOgjH8T7yUhxDn98BGzs=; b=X96MdjbCa9ggfNjOuOq7EVZbsy0h0LcY2licAcUJ3fI60IyV4TD2Ny1Zkf//aX98xs +UI2/NNRx4Un2Kyxf1oqRf2dXCizYao0Bu0MTVUAh3amDy7xi7y/KzAUigdAhEjcjGAv TQoxQfXkVkqKGa6Dl4rsEXGjRa24oNt9/8jj4M6mUX47i/+1ff3H/FaTF4Z3lWGRafNg kxYf5nrKW/0bnraNKH0Wcn3m0u5Pbyt6+P3HoLDRg4wU6U4e/SQB+KPoQkxannTnr+Ug 55yoC+SPIJDk5cVmwx/R6xSWKVoOcpRd1W7D/M5oC6gei2B5foJT9wUOVItBbHudc0js WUFw== X-Gm-Message-State: AOJu0Ywk1YGcP+FhfhsSVtKlI74Gj2W2ytx1BVaQeKtB/OEQj2QeLpoi 1y+51oVyKwFBRk0wJbPlL0d/Qg== X-Google-Smtp-Source: AGHT+IHx36NilNjcQj0V/DwreT87OC3NaWjFtiASBdZXA0fTzY+Qsmkg+s/l/6AD0q46Qe+poFx12Q== X-Received: by 2002:a17:906:3089:b0:9ae:70b7:bc9f with SMTP id 9-20020a170906308900b009ae70b7bc9fmr6261797ejv.2.1695651293161; Mon, 25 Sep 2023 07:14:53 -0700 (PDT) Received: from [192.168.50.4] ([82.78.167.177]) by smtp.gmail.com with ESMTPSA id p20-20020a1709060e9400b009ae587ce135sm6350301ejf.223.2023.09.25.07.14.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 25 Sep 2023 07:14:52 -0700 (PDT) Message-ID: <159b7f6f-fe82-cc31-0629-2b2fbd7340b9@tuxon.dev> Date: Mon, 25 Sep 2023 17:14:50 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH v5 4/8] drm: atmel-hlcdc: Define SAM9X7 SoC XLCDC specific registers Content-Language: en-US To: Manikandan Muralidharan , sam@ravnborg.org, bbrezillon@kernel.org, airlied@gmail.com, daniel@ffwll.ch, nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com, lee@kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Hari.PrasathGE@microchip.com, Balamanikandan.Gunasundar@microchip.com, Durai.ManickamKR@microchip.com, Nayabbasha.Sayed@microchip.com, Dharma.B@microchip.com, Varshini.Rajendran@microchip.com, Balakrishnan.S@microchip.com References: <20230915104849.187146-1-manikandan.m@microchip.com> <20230915104849.187146-5-manikandan.m@microchip.com> From: claudiu beznea In-Reply-To: <20230915104849.187146-5-manikandan.m@microchip.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15.09.2023 13:48, Manikandan Muralidharan wrote: > From: Durai Manickam KR > > The register address of the XLCDC IP used in SAM9X7 SoC family > are different from the previous HLCDC.Defining those address Add a space after . > space with valid macros. > > Signed-off-by: Durai Manickam KR > [manikandan.m@microchip.com: Remove unused macro definitions] > Signed-off-by: Manikandan Muralidharan > --- > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.h | 42 ++++++++++++++++++++ > include/linux/mfd/atmel-hlcdc.h | 10 +++++ > 2 files changed, 52 insertions(+) > > diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.h b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.h > index c61fa1733da4..9965c7cc5bf8 100644 > --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.h > +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.h > @@ -15,6 +15,7 @@ > > #include > > +/* LCD controller common registers */ > #define ATMEL_HLCDC_LAYER_CHER 0x0 > #define ATMEL_HLCDC_LAYER_CHDR 0x4 > #define ATMEL_HLCDC_LAYER_CHSR 0x8 > @@ -128,6 +129,47 @@ > > #define ATMEL_HLCDC_MAX_LAYERS 6 > > +/* XLCDC controller specific registers */ > +#define ATMEL_XLCDC_LAYER_ENR 0x10 > +#define ATMEL_XLCDC_LAYER_EN BIT(0) > + > +#define ATMEL_XLCDC_LAYER_IER 0x0 > +#define ATMEL_XLCDC_LAYER_IDR 0x4 > +#define ATMEL_XLCDC_LAYER_ISR 0xc > +#define ATMEL_XLCDC_LAYER_OVR_IRQ(p) BIT(2 + (8 * (p))) > + > +#define ATMEL_XLCDC_LAYER_PLANE_ADDR(p) (((p) * 0x4) + 0x18) > + > +#define ATMEL_XLCDC_LAYER_DMA_CFG 0 > + > +#define ATMEL_XLCDC_LAYER_DMA BIT(0) > +#define ATMEL_XLCDC_LAYER_REP BIT(1) > +#define ATMEL_XLCDC_LAYER_DISCEN BIT(4) > + > +#define ATMEL_XLCDC_LAYER_SFACTC_A0_MULT_AS (4 << 6) > +#define ATMEL_XLCDC_LAYER_SFACTA_ONE BIT(9) > +#define ATMEL_XLCDC_LAYER_DFACTC_M_A0_MULT_AS (6 << 11) > +#define ATMEL_XLCDC_LAYER_DFACTA_ONE BIT(14) > + > +#define ATMEL_XLCDC_LAYER_A0_SHIFT 16 > +#define ATMEL_XLCDC_LAYER_A0(x) \ > + ((x) << ATMEL_XLCDC_LAYER_A0_SHIFT) > + > +#define ATMEL_XLCDC_LAYER_VSCALER_LUMA_ENABLE BIT(0) > +#define ATMEL_XLCDC_LAYER_VSCALER_CHROMA_ENABLE BIT(1) > +#define ATMEL_XLCDC_LAYER_HSCALER_LUMA_ENABLE BIT(4) > +#define ATMEL_XLCDC_LAYER_HSCALER_CHROMA_ENABLE BIT(5) > + > +#define ATMEL_XLCDC_LAYER_VXSYCFG_ONE BIT(0) > +#define ATMEL_XLCDC_LAYER_VXSYTAP2_ENABLE BIT(4) > +#define ATMEL_XLCDC_LAYER_VXSCCFG_ONE BIT(16) > +#define ATMEL_XLCDC_LAYER_VXSCTAP2_ENABLE BIT(20) > + > +#define ATMEL_XLCDC_LAYER_HXSYCFG_ONE BIT(0) > +#define ATMEL_XLCDC_LAYER_HXSYTAP2_ENABLE BIT(4) > +#define ATMEL_XLCDC_LAYER_HXSCCFG_ONE BIT(16) > +#define ATMEL_XLCDC_LAYER_HXSCTAP2_ENABLE BIT(20) > + > /** > * Atmel HLCDC Layer registers layout structure > * > diff --git a/include/linux/mfd/atmel-hlcdc.h b/include/linux/mfd/atmel-hlcdc.h > index a186119a49b5..80d675a03b39 100644 > --- a/include/linux/mfd/atmel-hlcdc.h > +++ b/include/linux/mfd/atmel-hlcdc.h > @@ -22,6 +22,8 @@ > #define ATMEL_HLCDC_DITHER BIT(6) > #define ATMEL_HLCDC_DISPDLY BIT(7) > #define ATMEL_HLCDC_MODE_MASK GENMASK(9, 8) > +#define ATMEL_XLCDC_MODE_MASK GENMASK(10, 8) > +#define ATMEL_XLCDC_DPI BIT(11) > #define ATMEL_HLCDC_PP BIT(10) > #define ATMEL_HLCDC_VSPSU BIT(12) > #define ATMEL_HLCDC_VSPHO BIT(13) > @@ -34,6 +36,12 @@ > #define ATMEL_HLCDC_IDR 0x30 > #define ATMEL_HLCDC_IMR 0x34 > #define ATMEL_HLCDC_ISR 0x38 > +#define ATMEL_XLCDC_ATTRE 0x3c > + > +#define ATMEL_XLCDC_BASE_UPDATE BIT(0) > +#define ATMEL_XLCDC_OVR1_UPDATE BIT(1) > +#define ATMEL_XLCDC_OVR3_UPDATE BIT(2) > +#define ATMEL_XLCDC_HEO_UPDATE BIT(3) > > #define ATMEL_HLCDC_CLKPOL BIT(0) > #define ATMEL_HLCDC_CLKSEL BIT(2) > @@ -48,6 +56,8 @@ > #define ATMEL_HLCDC_DISP BIT(2) > #define ATMEL_HLCDC_PWM BIT(3) > #define ATMEL_HLCDC_SIP BIT(4) > +#define ATMEL_XLCDC_SD BIT(5) > +#define ATMEL_XLCDC_CM BIT(6) > > #define ATMEL_HLCDC_SOF BIT(0) > #define ATMEL_HLCDC_SYNCDIS BIT(1)