From: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
To: Hans Verkuil <hverkuil@xs4all.nl>, Cai Huoqing <caihuoqing@baidu.com>
Cc: Fabrizio Castro <fabrizio.castro.jz@renesas.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: rcar_drif: Make use of the helper function devm_platform_ioremap_resource()
Date: Wed, 1 Sep 2021 12:03:27 +0100 [thread overview]
Message-ID: <15a77d3a-0e2f-89e7-8d72-61856087602d@ideasonboard.com> (raw)
In-Reply-To: <fe294624-3ad4-2f4e-7a1f-cd4ac3d6b387@xs4all.nl>
On 01/09/2021 09:19, Hans Verkuil wrote:
> On 01/09/2021 07:55, Cai Huoqing wrote:
>> Use the devm_platform_ioremap_resource() helper instead of
>> calling platform_get_resource() and devm_ioremap_resource()
>> separately
>>
>> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
>> ---
>> drivers/media/platform/rcar_drif.c | 4 +---
>> 1 file changed, 1 insertion(+), 3 deletions(-)
>>
>> diff --git a/drivers/media/platform/rcar_drif.c b/drivers/media/platform/rcar_drif.c
>> index a505d991548b..f0a1edb57841 100644
>> --- a/drivers/media/platform/rcar_drif.c
>> +++ b/drivers/media/platform/rcar_drif.c
>> @@ -1376,7 +1376,6 @@ static int rcar_drif_probe(struct platform_device *pdev)
>> struct rcar_drif_sdr *sdr;
>> struct device_node *np;
>> struct rcar_drif *ch;
>> - struct resource *res;
>> int ret;
>>
>> /* Reserve memory for enabled channel */
>> @@ -1395,8 +1394,7 @@ static int rcar_drif_probe(struct platform_device *pdev)
>> }
>>
>> /* Register map */
>> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>> - ch->base = devm_ioremap_resource(&pdev->dev, res);
>> + ch->base = devm_platform_ioremap_resource(pdev, 0);
This could keep struct resource *res above and use:
ch->base = devm_platform_get_and_ioremap_resource(pdev, 0, &res)
With that, (and the commit message / subject updated accordingly):
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
>> if (IS_ERR(ch->base))
>> return PTR_ERR(ch->base);
>>
>>
>
> Compile error:
>
> drivers/media/platform/rcar_drif.c: In function ‘rcar_drif_probe’:
> drivers/media/platform/rcar_drif.c:1401:14: error: ‘res’ undeclared (first use in this function); did you mean ‘ret’?
> 1401 | ch->start = res->start;
> | ^~~
> | ret
> drivers/media/platform/rcar_drif.c:1401:14: note: each undeclared identifier is reported only once for each function it appears in
>
> Regards,
>
> Hans
>
prev parent reply other threads:[~2021-09-01 11:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-01 5:55 Cai Huoqing
2021-09-01 8:19 ` Hans Verkuil
2021-09-01 11:03 ` Kieran Bingham [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15a77d3a-0e2f-89e7-8d72-61856087602d@ideasonboard.com \
--to=kieran.bingham+renesas@ideasonboard.com \
--cc=caihuoqing@baidu.com \
--cc=fabrizio.castro.jz@renesas.com \
--cc=hverkuil@xs4all.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®