From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 586FC28371 for ; Fri, 15 Aug 2025 19:15:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755285350; cv=none; b=HhN3NVhlodN2YIB+yZ9JCufPB+4jhSzVJJu5ugExeH9MDIlPxPfGNAq/Jgs9oSHProXGl9DtgBjhjLfHIuPD6bTONnJLB/Gpu5VF5jOP1xg682nLfQcU1/dxI6Q/SiiMpPoEoU3CDjViMUYLADSKQDwPNESc/khXe7TkOSdoefI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755285350; c=relaxed/simple; bh=lSj71HO5GzYbckw7cBnMW50k4sxnSp1OOCtqeugcrA8=; h=From:Message-ID:Date:MIME-Version:Subject:To:Cc:References: In-Reply-To:Content-Type; b=JUrJ8rYYHv4mPiO+1FntjAmwdToaecAJug7tCPXQmCfeub19eW9BRRKfrSqeZP2oU0I54qxMDgD5gfzLM+JuVHoPcxoomUovxHK7PuKj7TyXsOeV01ZeecwKrZ9dZoNQJEFddnXzLlQc7TYNLb8gWKC9EcVKqDqap3IyzFjhNT4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Qam94Wjc; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Qam94Wjc" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1755285348; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=INM/nkZzXvOTsRuMaWEN8yu2b6nIHVl1/NxBWD2ETvA=; b=Qam94Wjc0kKcWVxlBxWki5maei5bjgh3EVtNFUy9ZSpSII3yABaCU6Lkomer9rzoVfI0P7 DtY5AhaF8s+sXc3UGn58jb7qs5DZzOBfKK8n77wT5S12Um37zB61K55uG57Ss6TTzHSs4J 9I+BTMSEVjZnes0I6iZCeAbZq4RC0fE= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-148-P8C_OyasPvijGQvNAqVjXA-1; Fri, 15 Aug 2025 15:15:47 -0400 X-MC-Unique: P8C_OyasPvijGQvNAqVjXA-1 X-Mimecast-MFC-AGG-ID: P8C_OyasPvijGQvNAqVjXA_1755285346 Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-70a92827a70so48479866d6.1 for ; Fri, 15 Aug 2025 12:15:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755285346; x=1755890146; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=INM/nkZzXvOTsRuMaWEN8yu2b6nIHVl1/NxBWD2ETvA=; b=Ykn+2XSvflmE5jG/w/M+uJEaRe0naNwwgglvyKTyTkEUss3TZBJ5lFO9A3VgnTlPM8 SfToOZbNu6tREHIUGUBA55vNpTvpJLN0iuQwhP5x4ApIvAzpIUT/6iHj1T1KoIqpmvIF ZoyWdDL0Vct6xrgSKd713Ps5aNSalzGtke178EWjUjEQllr0B+s2WGXISCVGLDyGZA34 z4cbNTJwVU0KBrMM+UbCJBpgtPanNQMS/S8h5hc1w5EajRoed3ZRSncQfyv0Q6amKd1U giJ9l57K8xjFeB0J98nn9I2eJvuMNXi3fDidGVlNfYFnKcFBVzqteP9j/Ksor1LCvyO2 17Ig== X-Forwarded-Encrypted: i=1; AJvYcCXKa4NdwCRl8/iVe+wb4dVCUoZkSJ7DFOVfTICs7yaS72tKz4r8vEY8zhOQBz9UcHlYOIwW2UwuUw+Gz90=@vger.kernel.org X-Gm-Message-State: AOJu0Yy9JL6qGwjG0oqcySq3nxIk67j02DRdt6AohTv6AaP28N+if56K 1j/MH5Vz22FIT7g4+ftJ7Z9CmRi0Yfrt0A8f3l+tO5ct9pI+GSxYtOm7X9bLUn0i0dGkB7mX5Q2 oDXwF4n5muqmnmvu8IMG4JJ0hhucjEEgcmKYNyFAr+xVf2kL5V7DriMNb/PvE3Kk5bw== X-Gm-Gg: ASbGncvk7GhdlZdXxRKjCuw2D02rHsdQUlHMlkkKWpn3CciJjHng1UShQWQit2uQZ+N BnsFFwqiRJmlT25nac2N9cxhWYMp4NaklMZx6R9vQKmuTS0rhqbIylaYDHcR9SAXNq8u3el8crP hy1ylFgIQDACe4KSncO9ZnNmPRRjNx8qm7ZN0GxljEFPfnNQgfUX1rN4udOQ7pNX4clTKIMdRSH uM64AiQe3iLxOhimyPklJerkSdnPOE/3lzsi04+d3YSa+5DQCVf7SRDvbP9dZLRAnJLO7sz79As zCRTUnR9lQhg1OS5QRERPaTduAZ/FFDc7L585SSv9Us80jag4ssY60Npbo1jPB5WHjbQKlvNhDJ EF9HVqmGC8Q== X-Received: by 2002:a05:6214:2522:b0:707:48b3:132 with SMTP id 6a1803df08f44-70bb04c04femr2029856d6.0.1755285346253; Fri, 15 Aug 2025 12:15:46 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG6iyDjW6RyozXA8YvlziiALssSDGwSrln6G47qwGj99VGsN/w0n7YA7sGWwplO+Ka5maXxjQ== X-Received: by 2002:a05:6214:2522:b0:707:48b3:132 with SMTP id 6a1803df08f44-70bb04c04femr2029486d6.0.1755285345832; Fri, 15 Aug 2025 12:15:45 -0700 (PDT) Received: from ?IPV6:2601:188:c180:4250:ecbe:130d:668d:951d? ([2601:188:c180:4250:ecbe:130d:668d:951d]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-70bae08c0f9sm7904296d6.11.2025.08.15.12.15.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 15 Aug 2025 12:15:45 -0700 (PDT) From: Waiman Long X-Google-Original-From: Waiman Long Message-ID: <15b47a34-ea8a-4a07-bc1e-5ba886010721@redhat.com> Date: Fri, 15 Aug 2025 15:15:44 -0400 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [-next v2 3/4] cpuset: separate tmpmasks and cpuset allocation logic To: Chen Ridong , kernel test robot , tj@kernel.org, hannes@cmpxchg.org, mkoutny@suse.com Cc: oe-kbuild-all@lists.linux.dev, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, lujialin4@huawei.com, chenridong@huawei.com, christophe.jaillet@wanadoo.fr References: <20250813082904.1091651-4-chenridong@huaweicloud.com> <202508140524.S2O4D57k-lkp@intel.com> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 8/14/25 8:44 PM, Chen Ridong wrote: > > On 2025/8/14 5:28, kernel test robot wrote: >> Hi Chen, >> >> kernel test robot noticed the following build warnings: >> >> [auto build test WARNING on tj-cgroup/for-next] >> [also build test WARNING on linus/master v6.17-rc1 next-20250813] >> [If your patch is applied to the wrong git tree, kindly drop us a note. >> And when submitting patch, we suggest to use '--base' as documented in >> https://git-scm.com/docs/git-format-patch#_base_tree_information] >> >> url: https://github.com/intel-lab-lkp/linux/commits/Chen-Ridong/cpuset-remove-redundant-CS_ONLINE-flag/20250813-164651 >> base: https://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup.git for-next >> patch link: https://lore.kernel.org/r/20250813082904.1091651-4-chenridong%40huaweicloud.com >> patch subject: [-next v2 3/4] cpuset: separate tmpmasks and cpuset allocation logic >> config: x86_64-defconfig (https://download.01.org/0day-ci/archive/20250814/202508140524.S2O4D57k-lkp@intel.com/config) >> compiler: gcc-11 (Debian 11.3.0-12) 11.3.0 >> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250814/202508140524.S2O4D57k-lkp@intel.com/reproduce) >> >> If you fix the issue in a separate patch/commit (i.e. not just a new version of >> the same patch/commit), kindly add following tags >> | Reported-by: kernel test robot >> | Closes: https://lore.kernel.org/oe-kbuild-all/202508140524.S2O4D57k-lkp@intel.com/ >> >> All warnings (new ones prefixed by >>): >> >>>> Warning: kernel/cgroup/cpuset.c:422 function parameter 'pmasks' not described in 'alloc_cpumasks' > Hi all, > > Thank you for the warning about the comment issue - I will fix it in the next version. > > I will be appreciate if you can review this patch. If you have any feedback, I can update the entire > series together. > Sorry for not responding to this patch. It looked reasonable to me. I did miss the error in the comment though. Fortunately it was caught by the test robot. Cheers, Longman