From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 504181DDD6 for ; Wed, 3 Jul 2024 14:00:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720015236; cv=none; b=LXHz6qEfyPoOEPTMC/iMr/ALpzBr+sO+yzfhSt/5YmXEFQ65h+SvKsLwi2LDcEidXx1Qfr1k6I7ScVHFWP25KxFyP+fJD9jc5SyGVT5Rr5ZM96PLA41lS9guiZSs2hUiDqMKBs8+EyQZUYBajm3CHsJk0kBi40l2y6HzSRjC5Gg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720015236; c=relaxed/simple; bh=gtHg+fhWTCT5t00ym5mQRgobrrouh6//u8ADJqModEI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Ldf+hMbqmoJOIW8t/9oynIyqs6s+yAVp5w+O2k2erb2etHzBFIv6kr9Wjb+eHNs/a8FtNV98oUWjDT/7vNDO5HTCmggLgrKYhWk+HTn3ZFkDm8lLSbVBK5Cs48I37pfuT0kHb+57F30g77/qWgRrEpkRaI+lmWIHWzfho7oXyLc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=w1o63krl; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="w1o63krl" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-42565670e20so4520475e9.0 for ; Wed, 03 Jul 2024 07:00:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1720015234; x=1720620034; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Umv9yiRU+omL+0ilB9pN8nKbjgKXfIcuYwrR5A3ZEYc=; b=w1o63krlvTm/JG9KTaGNTeIyYlEWaFFpMSxLsGZRh64YuDC0UBJRi80+wYJ5HrgQOO QraLHQkVWFA2OZlILXXnOkjlEX2FPRX0D0SM/ThGuuHvaKsODr+j751AXpc+hurIehKC J0II9MJMY/URFxJ+tEb0SEISwXCnD24+OJp+n0fCYJ+9gbbIu0AnwrffPbNC5d7Rh8Om hKEdP2t7DSWVGGLmWshyvLqfhwqH7cR/J1OwqsA61W1xwXQqUcmrxe5m8F6HBQzwISOJ UsTmvTJuiE6wLoUn3Cwi09m8k7j0wslf0QNpKmIO/ptUNDA5J4iYofdBShMQGGpBEhDb /Tsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720015234; x=1720620034; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Umv9yiRU+omL+0ilB9pN8nKbjgKXfIcuYwrR5A3ZEYc=; b=VVvA7mD8DZsI3iAJBdRtnHTpHGmTsxuG7Z/8QwjlnM987qfA8wbmMgwgjJR8SaqzdY 1XobgpI4CsAwLT40WkF4TXkyz7pBursqrUCPtnI9pj8R8+x6QvUl4CDcUiVw4a2bz5SL waEhujkQl7nX61CkfSGOdIDztyMBhhhbtB0wIo9oHCIAKs68V9vVoxKBvAmVxsq9t2Zw m3vB5blK+v+/ZKo9bOZfN3apPRHuL1x5ykzaRgKrx1cItVTP/n51HDtQ9z1aIzI7pzu0 RRzZGUjaoxFbRF6lWdZtB3bPuSYjusSIxpVhjP7ZFMVLAd9zBGbCM95CBqai+Mxi3xXt QBgg== X-Gm-Message-State: AOJu0Yy2khO5/7VzxxRT5RztGkOWsv8LCbel3WULfUzrzUP0GsXttwiP Q2zIglRzFHrbKmAx/xzW3sYkmlRqRULH6zpT+Cxd94KFepZsyGelV8X/ULlnFPk= X-Google-Smtp-Source: AGHT+IGMQ9qtNvPvtq/beeHsghJ67tCO2WfXdsV6AnqIVKFFGTng3VkPBI3s0SPGnhqQieqd24h1WA== X-Received: by 2002:a5d:4705:0:b0:367:9048:e952 with SMTP id ffacd0b85a97d-367947a3744mr1454176f8f.18.1720015233635; Wed, 03 Jul 2024 07:00:33 -0700 (PDT) Received: from ?IPV6:2a05:6e02:1041:c10:c49e:e1a5:3210:b8c0? ([2a05:6e02:1041:c10:c49e:e1a5:3210:b8c0]) by smtp.googlemail.com with ESMTPSA id ffacd0b85a97d-3675a0cd6e5sm16003812f8f.4.2024.07.03.07.00.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 03 Jul 2024 07:00:33 -0700 (PDT) Message-ID: <15b67ce6-3238-435d-ad28-7c06efbe9153@linaro.org> Date: Wed, 3 Jul 2024 16:00:32 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] thermal: core: Call monitor_thermal_zone() if zone temperature is invalid To: neil.armstrong@linaro.org, "Rafael J. Wysocki" , Linux PM Cc: LKML , Lukasz Luba , Srinivas Pandruvada , Zhang Rui , linux-arm-msm References: <2764814.mvXUDI8C0e@rjwysocki.net> <2ed4c630-204a-4f80-a37f-f2ca838eb455@linaro.org> <8d91a3c1-018f-495b-83be-979b795b5548@linaro.org> <12c5c133-9519-4a26-b9a3-2da1d3466e94@linaro.org> Content-Language: en-US From: Daniel Lezcano In-Reply-To: <12c5c133-9519-4a26-b9a3-2da1d3466e94@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 03/07/2024 14:43, neil.armstrong@linaro.org wrote: > Hi, > > On 03/07/2024 14:25, Daniel Lezcano wrote: >> >> Hi Neil, >> >> it seems there is something wrong with the driver actually. >> >> There can be a moment where the sensor is not yet initialized for >> different reason, so reading the temperature fails. The routine will >> just retry until the sensor gets ready. >> >> Having these errors seem to me that the sensor for this specific >> thermal zone is never ready which may be the root cause of your issue. >> The change is spotting this problem IMO. > > Probably, but it gets printed every second until system shutdown, but > only for a single thermal_zone. > > Using v1 of Rafael's patch makes the message disappear completely. Yes, because you have probably the thermal zone polling delay set to zero, thus it fails the first time and does no longer try to set it up again. The V1 is an incomplete fix. Very likely the problem is in the sensor platform driver, or in the thermal zone description in the device tree which describes a non functional thermal zone. -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog