From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFD31C433EF for ; Tue, 5 Oct 2021 16:50:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A51BA61506 for ; Tue, 5 Oct 2021 16:50:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236483AbhJEQwn (ORCPT ); Tue, 5 Oct 2021 12:52:43 -0400 Received: from relay02.th.seeweb.it ([5.144.164.163]:50095 "EHLO relay02.th.seeweb.it" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233896AbhJEQwj (ORCPT ); Tue, 5 Oct 2021 12:52:39 -0400 Received: from [192.168.31.208] (riviera.nat.ds.pw.edu.pl [194.29.137.1]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by m-r1.th.seeweb.it (Postfix) with ESMTPSA id 361721F564; Tue, 5 Oct 2021 18:50:46 +0200 (CEST) Message-ID: <15b74129-111f-a43e-ad10-36722fe86e2e@somainline.org> Date: Tue, 5 Oct 2021 18:50:45 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.1.2 Subject: Re: [PATCH 05/10] backlight: qcom-wled: Fix off-by-one maximum with default num_strings To: Daniel Thompson , Marijn Suijten , phone-devel@vger.kernel.org, Andy Gross , Bjorn Andersson , Lee Jones , Jingoo Han , ~postmarketos/upstreaming@lists.sr.ht, AngeloGioacchino Del Regno , Martin Botka , Jami Kettunen , Pavel Dubrova , Kiran Gunda , Courtney Cavin , Bryan Wu , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20211004192741.621870-1-marijn.suijten@somainline.org> <20211004192741.621870-6-marijn.suijten@somainline.org> <20211005091947.7msztp5l554c7cy4@maple.lan> <20211005100606.faxra73mzkvjd4f6@SoMainline.org> <20211005103843.heufyonycnudxnzd@maple.lan> <20211005105312.kqiyzoqtzzjxayhg@maple.lan> <20211005114435.phyq2jsbdyroa6kn@SoMainline.org> <20211005140349.kefi26yev3gy3zhv@maple.lan> <20211005152326.5k5cb53ajqnactrg@SoMainline.org> <20211005162453.ozckxhm47jcarsza@maple.lan> From: Konrad Dybcio In-Reply-To: <20211005162453.ozckxhm47jcarsza@maple.lan> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [snipping to not have the entire thread here] > I've no objections to seeing the DT updated. However I don't really see > what benefit we get from breaking existing DTs in order to do so. > > "Cleaning up annoying legacy" is seldom a good reason to break existing > DTs since, if we could break DTs whenever we choose, there would never > be any annoying legacy to worry about. When conflicting properties > result in uninterpretable DTs then a break may be justified but that is > not the case here. > > > Daniel. The only true user of wled as of right now is Xperia Tone platform, which does not yet have display support upstream, so unless one classifies lighting up an otherwise black display a dealbreaker, I think it'd be fine to bend the rules this time. Konrad