From: Vineet Gupta <Vineet.Gupta1@synopsys.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>
Cc: "robh@kernel.org" <robh@kernel.org>,
"Nelson.Pereira@synopsys.com" <Nelson.Pereira@synopsys.com>,
"vinod.koul@intel.com" <vinod.koul@intel.com>,
"viresh.kumar@linaro.org" <viresh.kumar@linaro.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
"linux-snps-arc@lists.infradead.org"
<linux-snps-arc@lists.infradead.org>
Subject: Re: [PATCH] DW: Read "is_memcpy" and "is_nollp" property from device tree.
Date: Tue, 23 Aug 2016 10:14:52 -0700 [thread overview]
Message-ID: <15b77367-2f95-deb2-a4dc-c47730bdb939@synopsys.com> (raw)
In-Reply-To: <1471971704.4887.247.camel@linux.intel.com>
On 08/23/2016 10:02 AM, Andy Shevchenko wrote:
> On Tue, 2016-08-23 at 15:14 +0000, Eugeniy Paltsev wrote:
>
>> DW DMAC on ARC SDP became broken after df5c7386 ("dmaengine: dw:
>>>> some Intel devices has no memcpy support") and 30cb2639
>>>> ("dmaengine: dw: don't override platform data with autocfg")
>>>> commits.
>>> I'm not sure that word 'broken' is a correct one here. Is the
>>> platform
>>> code using this driver in the upstream already? If so, where is it
>>> located?
>>>
>> I'm not sure is it, but, at least, it changed driver behavior for ARC
>> SDP boards.
> The rule of common sense here: if it was never upstreamed it has never
> been broken.
Right !
> I hardly remember any user of DW DMAC by ARC architecture in upstream.
The ARC SDP platform is provided by arch/arc/plat-axs and arch/arc/boot/ax*
The IP Proto-typing kit folks here would just add a DT binding in there and things
would just work out of the box - and that stopped recently - hence the notion of
broken. But I agree one can't fix what can't be seen as broken. I just intervened
to make this comment - I'm sure you and Eugeniy can agree on a workable solution.
Thx,
-Vineet
prev parent reply other threads:[~2016-08-23 17:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-16 11:31 Eugeniy Paltsev
2016-08-16 12:19 ` kbuild test robot
2016-08-19 14:39 ` Andy Shevchenko
2016-08-23 15:14 ` Eugeniy Paltsev
2016-08-23 17:01 ` Andy Shevchenko
2016-08-23 17:14 ` Vineet Gupta [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15b77367-2f95-deb2-a4dc-c47730bdb939@synopsys.com \
--to=vineet.gupta1@synopsys.com \
--cc=Eugeniy.Paltsev@synopsys.com \
--cc=Nelson.Pereira@synopsys.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=robh@kernel.org \
--cc=vinod.koul@intel.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®