From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7035133554C for ; Tue, 10 Feb 2026 09:32:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770715971; cv=none; b=op1ycLm8C9VZ0qDrWO0CpBuF6nIiClhUwppYtjg1gHQlcY5VimbVbT5fIRbcXH1GVML/bPGPhozR/aWqGO28HXl4cYjHv7NfwwQc1EVMNiql+0UffCna/4YR1zMN4s1Sp6qpQXRbV9Dv5smtYhuUWd9lqVbVFeaa3MZ2pT53sk0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770715971; c=relaxed/simple; bh=lYXkrcgF/gfCqHIjWikYj3wuxE8pK3C+vUdP+nhK84M=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ZTNlhWAlp6okz8iegWhMj4cC3tBwarpwulowSiI0dwh9X8aDQcEs4xvvMkncn7t2yVmc+Ck79JGT4CZADJrGMIU8hTnYBS4wR+d1om93SYgXPOeLrZrZs0uxh2eyYCgIYOkhYFU/72sHCCCE7kdyEAMDY/OqZ39H+cpn/G7zqaY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=gyN0gdRF; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=YdEpLmsA; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="gyN0gdRF"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="YdEpLmsA" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61A7UEqo1419490 for ; Tue, 10 Feb 2026 09:32:48 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= rLgXJquVUyBesXKA8dBPnaFYAdLbpSuCrTyxZs6wRLQ=; b=gyN0gdRFUJ97s+ng w9doHsRyEqEf4htP5kOOfdDEkdnknJuhCgyZofYt3++5xG6Q2jj+j80gvIrXZXq7 rIGMjNBgpOy8+qvhQgro+ixrsVEdGl6ypCUHzgLTqBXvlmMV6JFqr3H+YYUFpKhc XpzWvOy1t+q3Pi34ZcxXG5ZTPwpCVPW3UntEPew9+94OHzMQ+1IB4P0U2UcilQ+r AOhWY7sX/DOyNWmZ9U067LepU7sqIUhxVLjBiUkhqABGxIUriGFKhN9yW2dO7Jbi c2tYVWDQw60hbqFST2xrQEGMlUmq2PI66KzRdyxQDtqBepaFU1klhTEE525WgIR7 BGn/uw== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c7rpvswdm-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 10 Feb 2026 09:32:48 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-8c6a182d4e1so95754585a.0 for ; Tue, 10 Feb 2026 01:32:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1770715968; x=1771320768; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=rLgXJquVUyBesXKA8dBPnaFYAdLbpSuCrTyxZs6wRLQ=; b=YdEpLmsALwtK6Pa72IecphXXMk4NG/g9EeFodmwCoRne0USv7T8S/0ZrlwnXtdLRb8 eWrKxCfpYFZSw6Lc5XI8ljOTOK+JkOCZh5Spyb4Sm58jeXn6GimUGrDSHslF4amjxRy8 Skz8+XMYcYNkLQ8Odc2aolxnqg2uTY1AodPL0Vadf0yMs1+c35OGNwW1YILT1+KkrRCz vCoqizHUumiXo1zkt8ah3b4r1G4DBAaIxyLqXkgBCRUze/WNiHmuzmKRrjLvSnvxFb5Y E4/Dkcqo2Oe74/oIOIy8Onk8Fuq2hA6PJnRQvXKxatvQuwCDa7JkMJHV3eNunEajVx76 Nw9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770715968; x=1771320768; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=rLgXJquVUyBesXKA8dBPnaFYAdLbpSuCrTyxZs6wRLQ=; b=rTwfMs64WBb7rUyhnntXTqf4oFBSWcIisR8Ek/S/vvqvOUj2AQoIC8uHknBgsT6HcG 3S1xE8gwltoDeENWpgiGVRL384LKqrZ7Lib4wBfZqf9b0eOyfUmyhn+o8BsQ9krN3m/g TRqHwfYonrWESychgRA+wGRfsqEqFZVgPpmjJdGo/ICnxFU9rbhCujdlb/+5d9e9cLpb nHEka6xTMxh5LfESYQoRLYUlfnhpipxQ+QdKNxFooXo7ZPAUCgHO0pO/6ah5bgqhl1yw dS3h5F7DM3M3aHPBaIeA0oAffcUDVDac5Gqb1ZtXyucxXVTldjEkA1yr29FoNxKG3ATg Cckw== X-Forwarded-Encrypted: i=1; AJvYcCWHLqom2ONEBQzEr9ATkecTrFUX82DA+LG3gyHQp9zdFCkADpfnZoIMcXZjg5F/+gZpI6DQ0Y8tipOQ+3Y=@vger.kernel.org X-Gm-Message-State: AOJu0YxyLE7lGcEd5/bTNosiG1Cs8kzBnDB4WimaharF2J33/D/5L2x3 kJXUloN2Ux9lWQ3LQkBtuH3dDqBZzrAcFqC+cR4ji3DySD9WsAMN8Ql4lDwz+hN3UfQclPG183Y vzl2GP9JAGfj4ISBi1HZnMW9p0GEWDbeJ9TlDuuIxaEK2u/sG1xPUYk5+EbbsbekrTco= X-Gm-Gg: AZuq6aIMkQce5sE9wjbCPNWR2XnvmMW5WS5ZGg8M0DJzN1D/H6cGvhpbSoZInJTK05Q 8KNAOyVhAhynSOT5HR730WmJi6qBoYgZJpjO8Rd85XNbHUKzPn5Hk7diDJ8QbEa49aKOc4FRmMd 5Jox5IDLqrnbM7AJ/HcppcBN5RMZj5AyHdudKvNvE4rHs6ANG5tH3bepLEnTrc+n3Rb8E2xmbRU NqXC5TGXmng5BMgpKtrGAban7YsJZK3gvNM8gqP8x52xbkEjNuzk+PjyOCCyaROtKab4kY59yoW bnQeBm2nlWpJiq4mNdE4ZUBLwISH+I/vJ7lPAkeBXtZqWjp+KY+WMVlRd6rTbGc4dwl3MgZ4btF 5HjxXKKxheqJTw356nVyNiTnfYphxATSXgHmNyXpnmh5gg9qY5jubC9OoHtoRnNgMkAP8CONYcf kLUrE= X-Received: by 2002:a05:620a:1a20:b0:8c9:ea8e:c55a with SMTP id af79cd13be357-8cb1fed996bmr108851185a.3.1770715967938; Tue, 10 Feb 2026 01:32:47 -0800 (PST) X-Received: by 2002:a05:620a:1a20:b0:8c9:ea8e:c55a with SMTP id af79cd13be357-8cb1fed996bmr108849485a.3.1770715967474; Tue, 10 Feb 2026 01:32:47 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8edacb18aesm499346866b.41.2026.02.10.01.32.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Feb 2026 01:32:46 -0800 (PST) Message-ID: <15b87c55-9dbe-4a49-b166-498908f174bc@oss.qualcomm.com> Date: Tue, 10 Feb 2026 10:32:43 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/4] mmc: sdhci-msm: Remove NULL check from devm_of_qcom_ice_get() To: manivannan.sadhasivam@oss.qualcomm.com, Bjorn Andersson , Konrad Dybcio , Abel Vesa , Adrian Hunter , Ulf Hansson , Manivannan Sadhasivam , "James E.J. Bottomley" , "Martin K. Petersen" Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org, linux-scsi@vger.kernel.org, Sumit Garg References: <20260210-qcom-ice-fix-v2-0-9c1ab5d6502c@oss.qualcomm.com> <20260210-qcom-ice-fix-v2-3-9c1ab5d6502c@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260210-qcom-ice-fix-v2-3-9c1ab5d6502c@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjEwMDA3OSBTYWx0ZWRfX4Z+ji6g2yM8s Kl/ddB653cwJrYu0yBw3rlgqeRtvknsZcJfkLat44z0h0hZupEZSWu5iONMDAbhSavWceLT9NqX EVT4WbPtJiKJOJUP19PF4Rbxh6Ggr0cV48FJURnvs0+Vbn0b8xgFZ9sU1Rk/jgUl3xZb04GVrV2 u6DvyeYeIPhjLYOCm34Hcs26KnGeTfGzjhML6nmYNDmmiULmvN2N0A4lu3049zER8NgGj2sGl5j xT5WKRnRHsSnSKwdVNyuSkCuxNgZawNXxfWMWj2CFSX+LOzTkmLBlR5iQOs2rrFi21LEZIsWpxu 6zNX30eRi3/JcSZJboUHUthbNYo2RHZ0Kytt8Zd21BKEeP62+p1A5vQJiBu0N5BQzz8gEONtWgI TKHNZ8dFEZFRFj0+jWHj29YDka9FATBVPofpg2IBtc3RWuJL3sr+hYN3QwuqHMJmWu7wOeJodqq gwNsWfG2Pyr0gPE88EA== X-Authority-Analysis: v=2.4 cv=KKZXzVFo c=1 sm=1 tr=0 ts=698afb40 cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=EUspDBNiAAAA:8 a=AC2hTCgHVLFjDka4hzMA:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-ORIG-GUID: FB4HnT7p1gB19D-hJzhHXnIhNYWUjLB5 X-Proofpoint-GUID: FB4HnT7p1gB19D-hJzhHXnIhNYWUjLB5 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-09_01,2026-02-09_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 lowpriorityscore=0 suspectscore=0 impostorscore=0 spamscore=0 adultscore=0 malwarescore=0 priorityscore=1501 phishscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602100079 On 2/10/26 7:56 AM, Manivannan Sadhasivam via B4 Relay wrote: > From: Manivannan Sadhasivam > > Now since the devm_of_qcom_ice_get() API never returns NULL, remove the > NULL check and also simplify the error handling. > > Signed-off-by: Manivannan Sadhasivam > --- Reviewed-by: Konrad Dybcio Konrad