From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF039C33CA2 for ; Wed, 8 Jan 2020 17:45:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BA94020705 for ; Wed, 8 Jan 2020 17:45:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="MloR51gX" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727842AbgAHRpf (ORCPT ); Wed, 8 Jan 2020 12:45:35 -0500 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:20660 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727145AbgAHRpe (ORCPT ); Wed, 8 Jan 2020 12:45:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1578505532; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vAbrCkrIuQhAIxDIFRpXY9taZ5SfRby6+FX1Mi+Hdt4=; b=MloR51gXRDflbWqF9O2S0KYwn1whGXK1Hy3bWnhjfqls8KPEvJerHfty1wKiAPIqJ5yl5J Ns5nuRMsB+YCgOJ2WwgnYzyCZ41Fq2+8xQ0DK1g9yKMW05mEBGxCxRRUgermXWzDl/YtA0 HbJ0qToLqOqOUmUy6WKrbrn1Oyj72PA= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-394-cXVHUq7RMeOkObaa5ziBBQ-1; Wed, 08 Jan 2020 12:45:31 -0500 X-MC-Unique: cXVHUq7RMeOkObaa5ziBBQ-1 Received: by mail-wm1-f69.google.com with SMTP id c4so1104235wmb.8 for ; Wed, 08 Jan 2020 09:45:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=vAbrCkrIuQhAIxDIFRpXY9taZ5SfRby6+FX1Mi+Hdt4=; b=Pn9pG+Um4kGdYxbC/4T0awzZU2rzGNpWUKw93wbHqVk4bvuCw32/3e93rz2Oynk5g7 P0fjBNjmAo27YfTpt6cIdKR8ppEPJ0SHTuIQs4fk9H4hPXwnQrg08SBVq4Z/KYYu9YQa BjHYc7nZd2RngpHfbiM0upQ6re/hhjQF2Pagy4l/Vubvj9hbuilQCpQyd4sJaRfwcN4K Nxd8L6GeWCD521UqvD+jrwKC5lCa7+Gu/Zh9Km3w7x93wR36mS/VTsJOUixzjcLrzDWE S2V+NeBAvouHBk5bHbj1nkiTPPeYXyP5E0TJw/L0ZaF0TVWFxdshHB9ZfXZ9QD4KIT3u 8esw== X-Gm-Message-State: APjAAAWzsj1MY956SVdENlnudmmDrgU4Dfuu+vb8iQzAf3Z8H1QsRDEP vLCuqB2LoR5ModgZEQb96OJT6jIyYRQiSH7T90qk6/Q32OaGbcMKh7ZsBczCNEOVT5F8ECKlH8k DjnY6zlhF5mpFETeelOTFTTp+ X-Received: by 2002:a05:600c:1009:: with SMTP id c9mr5552200wmc.162.1578505529997; Wed, 08 Jan 2020 09:45:29 -0800 (PST) X-Google-Smtp-Source: APXvYqxUOQXtzLAkEHEjUID+HnRc2XOSMUnPPe6lslm3LAC2FtlfT9P1+XCgvOpBL4apTaLuisYbSw== X-Received: by 2002:a05:600c:1009:: with SMTP id c9mr5552179wmc.162.1578505529762; Wed, 08 Jan 2020 09:45:29 -0800 (PST) Received: from ?IPv6:2001:b07:6468:f312:c6d:4079:b74c:e329? ([2001:b07:6468:f312:c6d:4079:b74c:e329]) by smtp.gmail.com with ESMTPSA id p17sm4658551wmk.30.2020.01.08.09.45.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Jan 2020 09:45:29 -0800 (PST) Subject: Re: [PATCH RESEND v2 01/17] KVM: Remove kvm_read_guest_atomic() To: Peter Xu , kvm@vger.kernel.org, linux-kernel@vger.kernel.org Cc: "Dr . David Alan Gilbert" , Christophe de Dinechin , Sean Christopherson , "Michael S . Tsirkin" , Jason Wang , Vitaly Kuznetsov References: <20191221014938.58831-1-peterx@redhat.com> <20191221014938.58831-2-peterx@redhat.com> From: Paolo Bonzini Message-ID: <15bc02b7-595d-2564-b1f9-a4a8aae37252@redhat.com> Date: Wed, 8 Jan 2020 18:45:28 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: <20191221014938.58831-2-peterx@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21/12/19 02:49, Peter Xu wrote: > Remove kvm_read_guest_atomic() because it's not used anywhere. > > Signed-off-by: Peter Xu > --- > include/linux/kvm_host.h | 2 -- > virt/kvm/kvm_main.c | 11 ----------- > 2 files changed, 13 deletions(-) > > diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h > index d41c521a39da..2ea1ea79befd 100644 > --- a/include/linux/kvm_host.h > +++ b/include/linux/kvm_host.h > @@ -730,8 +730,6 @@ void kvm_get_pfn(kvm_pfn_t pfn); > > int kvm_read_guest_page(struct kvm *kvm, gfn_t gfn, void *data, int offset, > int len); > -int kvm_read_guest_atomic(struct kvm *kvm, gpa_t gpa, void *data, > - unsigned long len); > int kvm_read_guest(struct kvm *kvm, gpa_t gpa, void *data, unsigned long len); > int kvm_read_guest_cached(struct kvm *kvm, struct gfn_to_hva_cache *ghc, > void *data, unsigned long len); > diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c > index 13efc291b1c7..7ee28af9eb48 100644 > --- a/virt/kvm/kvm_main.c > +++ b/virt/kvm/kvm_main.c > @@ -2039,17 +2039,6 @@ static int __kvm_read_guest_atomic(struct kvm_memory_slot *slot, gfn_t gfn, > return 0; > } > > -int kvm_read_guest_atomic(struct kvm *kvm, gpa_t gpa, void *data, > - unsigned long len) > -{ > - gfn_t gfn = gpa >> PAGE_SHIFT; > - struct kvm_memory_slot *slot = gfn_to_memslot(kvm, gfn); > - int offset = offset_in_page(gpa); > - > - return __kvm_read_guest_atomic(slot, gfn, data, offset, len); > -} > -EXPORT_SYMBOL_GPL(kvm_read_guest_atomic); > - > int kvm_vcpu_read_guest_atomic(struct kvm_vcpu *vcpu, gpa_t gpa, > void *data, unsigned long len) > { > Reviewed-by: Paolo Bonzini