From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=185.171.202.116 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794924160; b=agll1JlZFHOpb60yI33aIrqwjluCvYeruoYRv5q+PmWiqV/GHMTsGBneCclYOv4Yvpqw PyO1aHSG6W3PKWzLeSz4NmLabMlCopoGbcgSrsda2xmWyoHPzCQvYvMwX4QhXkngnLY/6 APL4jTljZTtlb88htDJqk8wCbguqokJA1Yi6ENgxmjEcWnwjh7P/10XQY7/ZNpdA5d1Jp WHQUZ9v1+AV577TTrXRPauXjUL+ciKhrLrGo+xA8Zq/LnD+IaEzo6Nd99JuGx9qC30+Lh 00J1aOZ8OsC+u8xub/OA2VfxxV0nx0opTsqRlYCls2JTfnylBeHpfvkDQJC05S00HpQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794924160; h=DMARC-Filter:Received:Received:Received:DKIM-Signature:Message-ID: Date:MIME-Version:User-Agent:Subject:To:Cc:References:From: Content-Language:In-Reply-To:Content-Type:Content-Transfer-Encoding: X-Last-TLS-Session-Version; bh=b04uqxVDpz8zEbV+fF30g6nJC0Jr18R4LW3IW7YULo4=; b=t0AOhCsvJRJ18qL1Kr4fv8ig7L6A412yQStWbH2UGe7DBKszy6/SelFWCuitRREHkYDv /Cr2ctZWzrMBlh9RHHmkXDgWI3a1nvmwsqhOpcIKyN104lciqFvwlYg8s07PzECB/YTuJ DD1H6i3+PXh+Q6fVu7mf19+noWLNEuRlMs+012WbB7JfL5Ps6Q3FU9+TBlMzM3LlaKnJu P/EwcFD3A6SulXrccUim5yRUfvwCHw1NxCEx1OK3+ju+gQ3AmKpNi18ky4oHyDQi9v6Vj i9QU2WeL+rquN84heUAXd9EoUKNuZllRaDxuq95EelF/5a+JVNUz3o3NFI5NJXOtZiQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=dkim header.b=QELhkOKf; arc=none smtp.remote-ip=185.171.202.116 Received: from smtpout-04.galae.net (smtpout-04.galae.net [185.171.202.116]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3B189606A89A; Tue, 17 Nov 2026 14:02:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 3B189606A89A Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=dkim header.b=QELhkOKf Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-04.galae.net (Postfix) with ESMTPS id E99A8C79A97; Tue, 17 Nov 2026 14:02:41 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 7EBC75FC81; Tue, 17 Nov 2026 14:02:37 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id B5C5C11BC0026; Tue, 17 Nov 2026 15:02:23 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1794924154; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:content-language:in-reply-to:references; bh=b04uqxVDpz8zEbV+fF30g6nJC0Jr18R4LW3IW7YULo4=; b=QELhkOKfXX1Gqrl+qpI1IL9xiHqLyRWue2LR5252YbNJgsRXa3ObMYeKely38VyTFi+jHK yHUn9G6xDAbHxtAvCGHAGJHb9dtMBj2b2eMncpbs64NaVr7rzrS0dd04j1XZa4gXg/RzhB YrRV7RUfUJwtHvoEKB1x+NxcFM1dPzR13+tE7XrCdDeFei2VtL8RMHr5D141NNwzdFHtIU oxoMk+gwxi+peG0RMQ1ATC481Zcp87Ud10cVzjCIcneIiRf8lG25GSw5dl+1BS6bmLTiaz 4naqOINCK/l56AbLPt4lLLkgIIEBKLOvqAcOMA1aJfx2gDen974Nj0Ym9zgp2A== Message-ID: <15c2236a-cd41-4f8d-b6ee-bb56f98f9916@bootlin.com> Date: Tue, 17 Nov 2026 15:02:22 +0100 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 06/10] drm: writeback: rename drm_writeback_connector_init_with_encoder() To: Dmitry Baryshkov , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , John Harrison , Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , =?UTF-8?Q?Christian_K=C3=B6nig?= , Liviu Dudau , Laurent Pinchart , Tomi Valkeinen , Kieran Bingham , Geert Uytterhoeven , Magnus Damm , Dave Stevenson , =?UTF-8?Q?Ma=C3=ADra_Canal?= , Raspberry Pi Kernel Maintenance , Mihail Atanassov , Eric Anholt , Rob Clark , Brian Starkey Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, Chaoyi Chen References: <20261111-wb-drop-encoder-v8-0-62948ed87d13@oss.qualcomm.com> <20261111-wb-drop-encoder-v8-6-62948ed87d13@oss.qualcomm.com> From: Louis Chauvet Content-Language: en-US In-Reply-To: <20261111-wb-drop-encoder-v8-6-62948ed87d13@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Last-TLS-Session-Version: TLSv1.3 On 11/11/26 01:42, Dmitry Baryshkov wrote: > Rename drm_writeback_connector_init_with_encoder() to > drm_writeback_connector_init() and adapt its interface to follow > drmm_writeback_connector_init(). Drop references to the "custom encoder" > from the documentation since it's now the only way to specify the > encoder to the writeback connector. > > Reviewed-by: Chaoyi Chen Reviewed-by: Louis Chauvet > Signed-off-by: Dmitry Baryshkov > --- > .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_wb.c | 10 +++++----- > .../drm/arm/display/komeda/komeda_wb_connector.c | 8 ++++---- > drivers/gpu/drm/arm/malidp_mw.c | 8 ++++---- > drivers/gpu/drm/drm_writeback.c | 21 +++++++++------------ > drivers/gpu/drm/renesas/rcar-du/rcar_du_writeback.c | 10 +++++----- > drivers/gpu/drm/vc4/vc4_txp.c | 8 ++++---- > include/drm/drm_writeback.h | 10 +++++----- > 7 files changed, 36 insertions(+), 39 deletions(-) > > diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_wb.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_wb.c > index e0ef23f692d4..dde02b2b018b 100644 > --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_wb.c > +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_wb.c > @@ -262,11 +262,11 @@ int amdgpu_dm_wb_connector_init(struct amdgpu_display_manager *dm, > > drm_connector_helper_add(&wbcon->base.base, &amdgpu_dm_wb_conn_helper_funcs); > > - res = drm_writeback_connector_init_with_encoder(&dm->adev->ddev, &wbcon->base, > - &wbcon->encoder, > - &amdgpu_dm_wb_connector_funcs, > - amdgpu_dm_wb_formats, > - ARRAY_SIZE(amdgpu_dm_wb_formats)); > + res = drm_writeback_connector_init(&dm->adev->ddev, &wbcon->base, > + &amdgpu_dm_wb_connector_funcs, > + &wbcon->encoder, > + amdgpu_dm_wb_formats, > + ARRAY_SIZE(amdgpu_dm_wb_formats)); > if (res) { > drm_encoder_cleanup(&wbcon->encoder); > return res; > diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c b/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c > index 7b795e1c5705..ea4589b00ee0 100644 > --- a/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c > +++ b/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c > @@ -186,10 +186,10 @@ static int komeda_wb_connector_add(struct komeda_kms_dev *kms, > return err; > } > > - err = drm_writeback_connector_init_with_encoder(&kms->base, wb_conn, > - wb_encoder, > - &komeda_wb_connector_funcs, > - formats, n_formats); > + err = drm_writeback_connector_init(&kms->base, wb_conn, > + &komeda_wb_connector_funcs, > + wb_encoder, > + formats, n_formats); > komeda_put_fourcc_list(formats); > if (err) { > drm_encoder_cleanup(wb_encoder); > diff --git a/drivers/gpu/drm/arm/malidp_mw.c b/drivers/gpu/drm/arm/malidp_mw.c > index 889d0d1db85d..3669d10540bf 100644 > --- a/drivers/gpu/drm/arm/malidp_mw.c > +++ b/drivers/gpu/drm/arm/malidp_mw.c > @@ -239,10 +239,10 @@ int malidp_mw_connector_init(struct drm_device *drm) > return ret; > } > > - ret = drm_writeback_connector_init_with_encoder(drm, &malidp->mw_connector, > - &malidp->mw_encoder, > - &malidp_mw_connector_funcs, > - formats, n_formats); > + ret = drm_writeback_connector_init(drm, &malidp->mw_connector, > + &malidp_mw_connector_funcs, > + &malidp->mw_encoder, > + formats, n_formats); > kfree(formats); > if (ret) { > drm_encoder_cleanup(&malidp->mw_encoder); > diff --git a/drivers/gpu/drm/drm_writeback.c b/drivers/gpu/drm/drm_writeback.c > index 683da368e339..89c36f1414ce 100644 > --- a/drivers/gpu/drm/drm_writeback.c > +++ b/drivers/gpu/drm/drm_writeback.c > @@ -165,8 +165,7 @@ static void delete_writeback_properties(struct drm_device *dev) > } > > /** > - * __drm_writeback_connector_init - Initialize a writeback connector with > - * a custom encoder > + * __drm_writeback_connector_init - Initialize a writeback connector > * > * @dev: DRM device > * @wb_connector: Writeback connector to initialize > @@ -241,8 +240,7 @@ static int __drm_writeback_connector_init(struct drm_device *dev, > } > > /** > - * drm_writeback_connector_init_with_encoder - Initialize a writeback connector with > - * a custom encoder > + * drm_writeback_connector_init - Initialize a writeback connector > * > * @dev: DRM device > * @wb_connector: Writeback connector to initialize > @@ -269,11 +267,11 @@ static int __drm_writeback_connector_init(struct drm_device *dev, > * > * Returns: 0 on success, or a negative error code > */ > -int drm_writeback_connector_init_with_encoder(struct drm_device *dev, > - struct drm_writeback_connector *wb_connector, > - struct drm_encoder *enc, > - const struct drm_connector_funcs *con_funcs, > - const u32 *formats, int n_formats) > +int drm_writeback_connector_init(struct drm_device *dev, > + struct drm_writeback_connector *wb_connector, > + const struct drm_connector_funcs *con_funcs, > + struct drm_encoder *enc, > + const u32 *formats, int n_formats) > { > struct drm_connector *connector = &wb_connector->base; > int ret; > @@ -290,7 +288,7 @@ int drm_writeback_connector_init_with_encoder(struct drm_device *dev, > > return ret; > } > -EXPORT_SYMBOL(drm_writeback_connector_init_with_encoder); > +EXPORT_SYMBOL(drm_writeback_connector_init); > > /** > * drm_writeback_connector_cleanup - Cleanup the writeback connector > @@ -320,8 +318,7 @@ static void drm_writeback_connector_cleanup(struct drm_device *dev, > } > > /** > - * drmm_writeback_connector_init - Initialize a writeback connector with > - * a custom encoder > + * drmm_writeback_connector_init - Initialize a writeback connector > * > * @dev: DRM device > * @wb_connector: Writeback connector to initialize > diff --git a/drivers/gpu/drm/renesas/rcar-du/rcar_du_writeback.c b/drivers/gpu/drm/renesas/rcar-du/rcar_du_writeback.c > index a1271fec9874..a88408124758 100644 > --- a/drivers/gpu/drm/renesas/rcar-du/rcar_du_writeback.c > +++ b/drivers/gpu/drm/renesas/rcar-du/rcar_du_writeback.c > @@ -217,11 +217,11 @@ int rcar_du_writeback_init(struct rcar_du_device *rcdu, > drm_connector_helper_add(&wb_conn->base, > &rcar_du_wb_conn_helper_funcs); > > - ret = drm_writeback_connector_init_with_encoder(&rcdu->ddev, wb_conn, > - encoder, > - &rcar_du_wb_conn_funcs, > - writeback_formats, > - ARRAY_SIZE(writeback_formats)); > + ret = drm_writeback_connector_init(&rcdu->ddev, wb_conn, > + &rcar_du_wb_conn_funcs, > + encoder, > + writeback_formats, > + ARRAY_SIZE(writeback_formats)); > if (ret) > drm_encoder_cleanup(encoder); > > diff --git a/drivers/gpu/drm/vc4/vc4_txp.c b/drivers/gpu/drm/vc4/vc4_txp.c > index 642953cba25f..6ffc54d23d48 100644 > --- a/drivers/gpu/drm/vc4/vc4_txp.c > +++ b/drivers/gpu/drm/vc4/vc4_txp.c > @@ -601,10 +601,10 @@ static int vc4_txp_bind(struct device *dev, struct device *master, void *data) > > drm_connector_helper_add(&txp->connector.base, > &vc4_txp_connector_helper_funcs); > - ret = drm_writeback_connector_init_with_encoder(drm, &txp->connector, > - encoder, > - &vc4_txp_connector_funcs, > - drm_fmts, ARRAY_SIZE(drm_fmts)); > + ret = drm_writeback_connector_init(drm, &txp->connector, > + &vc4_txp_connector_funcs, > + encoder, > + drm_fmts, ARRAY_SIZE(drm_fmts)); > if (ret) > return ret; > > diff --git a/include/drm/drm_writeback.h b/include/drm/drm_writeback.h > index 879ca103320c..958466a05e60 100644 > --- a/include/drm/drm_writeback.h > +++ b/include/drm/drm_writeback.h > @@ -137,11 +137,11 @@ drm_connector_to_writeback(struct drm_connector *connector) > return container_of(connector, struct drm_writeback_connector, base); > } > > -int drm_writeback_connector_init_with_encoder(struct drm_device *dev, > - struct drm_writeback_connector *wb_connector, > - struct drm_encoder *enc, > - const struct drm_connector_funcs *con_funcs, const u32 *formats, > - int n_formats); > +int drm_writeback_connector_init(struct drm_device *dev, > + struct drm_writeback_connector *wb_connector, > + const struct drm_connector_funcs *con_funcs, > + struct drm_encoder *enc, > + const u32 *formats, int n_formats); > > int drmm_writeback_connector_init(struct drm_device *dev, > struct drm_writeback_connector *wb_connector, >