From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S937881AbcISIQC (ORCPT ); Mon, 19 Sep 2016 04:16:02 -0400 Received: from mail-bl2nam02on0061.outbound.protection.outlook.com ([104.47.38.61]:14684 "EHLO NAM02-BL2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S936533AbcISIPy (ORCPT ); Mon, 19 Sep 2016 04:15:54 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Christian.Koenig@amd.com; Subject: Re: [PATCH] drm/amd/powerplay/smumgr: mark symbols static where possible To: Arnd Bergmann , Baoyou Xie References: <1474270119-8500-1-git-send-email-baoyou.xie@linaro.org> <2392100.i5YbeLyK7H@wuerfel> CC: , , , , , , , , , , , , , , From: =?UTF-8?Q?Christian_K=c3=b6nig?= Message-ID: <15c872e1-8931-68ca-846e-c909e6e3d5af@amd.com> Date: Mon, 19 Sep 2016 09:59:56 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <2392100.i5YbeLyK7H@wuerfel> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [2a02:908:1251:7981:e5d2:5583:7841:2f5c] X-ClientProxiedBy: AM4PR02CA0005.eurprd02.prod.outlook.com (10.165.239.143) To CY4PR12MB1302.namprd12.prod.outlook.com (10.168.168.139) X-MS-Office365-Filtering-Correlation-Id: b0cd54ec-d52b-41fe-4e93-08d3e062fa72 X-Microsoft-Exchange-Diagnostics: 1;CY4PR12MB1302;2:bOAAd3W1Ei4AIk1NTobZEXa/NyuE+o7xQI2XJH5Q1KFkEF0cbEBx7MI3qsSIRzUJkua22hbdaB2xP2+LBCEAy1TyBu4WihxWmHqoe61UtJaTDZVkDsHTFTDDxUKdcWT522LjC5vAPEFjeiUIUYSJfLcYakDCj6TZCwqgWUt1GQFmPe3eLP2o93hVW9Q8fY4R;3:WnYr169mVboTtrarrnGtFq1Dt2bWxRkYoZzXR/dU7CgLP/GXRyTSXTDpD0D02w0sGdbjMV0HyCaOvsjO9rcYJ6dkk96w5YvEvIrqlOvkVJiUZPL3l0Ol0Nu+YAi0KwNl X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY4PR12MB1302; X-Microsoft-Exchange-Diagnostics: 1;CY4PR12MB1302;25:L9xO9uvketu2Axlkyysh/0zpycOsTtgG923XsSaghfUjtysqDAov4GWKgob+aKQQRbeO3wMh1d7leBJkc9MkiHabUA6pTaiMSC0M1abLM5vb/IyJNocoZ2ViXXe3qQtjky6Lpq8RFLqXbVx4eTbMut1v3dgPUjU8/VJimadRBxAMjB+TDHckF2oV3oKP+g+OpyQa64+m6EBSALMd2X/LGa0nDgpegda56wuYmWMoI4FK/q/mQdIVIcdaUuz6XCQuVnXj/v1FBznONtxrnJZphCjpbjXih/i7113/kpxDNdpRr14IEq9F528GZWiT+ZyPBIWplIsO28QTsy2K5KXoBeR/fWjpufUOBJMh5kbb/Gs9iEPItf/9dL8/XFRhe0r4fjg1t2yjkfm24S5JN8yhOGA+6wcWC/CJ4971cmS9ZvMFYys3fWzWYsO8Uem8ZzXMTMitqNNtYXSnm1DD2u9oqEEtMxSU+ngOSW55QeSfQ+44Z2k4mYfZ/OrDR/vAddl3PggZtIGL83H3GbO9cVsSsow2EdeFXQqIwsGx4F7um39JtyubjtaxqiEhyYnVfRPRfpj3Gh7OK5gqcLEDjAg0llfQ3ErO5ZAUpSBEGYRll852Qm+Q2/WrV0cFhQ5SaPGCcNyqNddFhQKv88L6QEPDfv/LVqQb2DSOQFc5uKHsFBdA/jc9GeujnVU0EWalWaeHlBF2u4urhQXqjftcZ5VCbJ1rqMbUl5OZjcr03Eom+7N8KVz5/m34Evrh0q/KTlhA X-Microsoft-Exchange-Diagnostics: 1;CY4PR12MB1302;31:KhY2tzL00qK7aHxwxTxWcdFePY6mqWPBpqHCvrZ1LV0fpTbltJ36tYPaUjo8ht3Jp6gKCIAmBPhAS0IqYJG3r7ApbUqseH8erwozvFG8jJatEQivFbpRAnunF+s6J6zdKRfQ8mjBSOlhTe/Z+ACcYWHAGh5t6LOw7IHjOAYH+tB8giXJzMtlvjad/A5jfzLj9e1T96uxzdQ/m2PG5wUjdP8aECtkw5QXp//Fcm6XpEY=;20:aHV+TJNKnOdLFZZS4Bs+Q0vsDj7Rl+Sris/9unPH/UIbdHjUSnYkW9ICb8Mk9laMPfI/aTB1g71g0Rx9lX+kfFF/D/cbdELsuxoF6CzSh2bObmgBzjPkUsyQ9lOP0es6y66tpZZIYU64DvBKVlqGhVvzyqZuOFN1p34f5FgqtZQTIVyM2etALw0FLeJIZDpoa/VqfsRxe3EIX0lU97r9sXlJkiDfuRRIvkJEvUccwiIrCMv6LsyO2R4ucSM0J29zpa4nKHbD6+Ea6jwzjqR8ISq1dq1HSIllHeKXyxAlMdORlDQBeeiYgECaQKbXlCZc8shJUIu/LY/d1Nv8peJJttgdWR3l8oGJMy0QxRILhZUoW/v3RM7cQVCp0uMDt47pOgr7VoLlvH0xZ5N6fR1ics9TsAYUmm/W/3dIOzIYgbH4uTYAmGRvV5B16iqlk0VUpDzUExhxGLQPdcAIrTKqZ/RzUIoXzI4v/uDWq3Qe4h+hbsR/R7jVUnQzmqAmd0jD X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6055026);SRVR:CY4PR12MB1302;BCL:0;PCL:0;RULEID:;SRVR:CY4PR12MB1302; X-Microsoft-Exchange-Diagnostics: 1;CY4PR12MB1302;4:FQQPQsmAA2jQx+IXi33LjTqSLhlZmXUXsp927pPLMVrpX/65Js/EoEIOCF4O1W49k5sxHoJzdwwcZ/QbJuost1oj5A94UPIE4ZUNV/BWbLYhjzjqkei9IIU8THXsk2WzVLs4DBBX4PjHCAuufHTWs+vDLy+jleOw93jjPpk9BdmBmaZWPOT5YL2CFqV5nhwzYz0met7EPaT7qCtuB1ZX6iMH3Zfcx6YJJ4En0w9qbVPhOn0zl4f3Pulq3ZtfsjKxjGgkv/v6ctFWgWnEFh/tuYIobuC3M5/r5bpRr43iaS7ICo75PKFoRqJ0hm3Dixut1qKf1zOhS9ETdpq9QoN8NVrufeVKf+aeeeuyu3c4Xe90EYKqTQ2woYxSFCGU+KAjR/Q65+hCmjP00fehB0L0Hyj687FnK0oaTtfa3NL16Hg= X-Forefront-PRVS: 0070A8666B X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(7916002)(189002)(24454002)(199003)(377454003)(50986999)(54356999)(31696002)(97736004)(65826007)(5001770100001)(2906002)(76176999)(68736007)(4326007)(31686004)(81166006)(42186005)(86362001)(50466002)(5660300001)(101416001)(65806001)(7846002)(6116002)(4001350100001)(586003)(2950100001)(65956001)(19580405001)(83506001)(23746002)(305945005)(47776003)(19580395003)(77096005)(7736002)(33646002)(230700001)(64126003)(81156014)(8676002)(36756003)(189998001)(92566002)(105586002)(1706002)(106356001)(3826002);DIR:OUT;SFP:1101;SCL:1;SRVR:CY4PR12MB1302;H:[IPv6:2a02:908:1251:7981:e5d2:5583:7841:2f5c];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;CY4PR12MB1302;23:0sehgsafd69QfIFSznMcMatAmFtYPYR9hveXn?= =?Windows-1252?Q?qNctBZm28JkZJaGXmWEFWR9gtcM7E8FjXMSxi9m4Cf7jMrAZrESnMLUT?= =?Windows-1252?Q?pf3bvaRxLqdXdAwOSLLQBDrvRZJwv1F6nojDVTzlL9abN0QVTylvUwy3?= =?Windows-1252?Q?6sjZ+m99hRLnMQWSJ9NqoOm5+r6Wm53ySQytahhltDG7EUz+SDT/j76Z?= =?Windows-1252?Q?KK/bl9UgHVU6lP34TLUGKYhiLy3fG5F0bBz7HplpbsonA41NOtilsrPX?= =?Windows-1252?Q?Tyw42/maHfbd/f7uoT1PnBkl8cYX78446FpZ+JDHqkJZlix58UE6890k?= =?Windows-1252?Q?dtwu3pfwaFBygKGdR9G1MxLN7olIleMr63SdJxTDk8kim6SadGkNADjV?= =?Windows-1252?Q?ZhzqhsAe1ugscq54OeKy8HIkXJByx9t1U0/H9pt8UxnQwDDvPwjzCAAA?= =?Windows-1252?Q?+E8YZkecqlorK2uxIO9J6xZb8zkUV3UpUoLf4kxR4/nBH1tvwK48tig8?= =?Windows-1252?Q?iHmwty4SsVQTyA4J3hUYW+RPu4NMLXnq9UW4rkOXXA1f9i9hd20VvV7/?= =?Windows-1252?Q?5mD9Aasa2vUbjXBMJ+9FJeCqN8ryUf5BKIiESremMmNVdj7/aO9l16tK?= =?Windows-1252?Q?kgdBP9tPHJXsrjyjLnVGShpZ0f5MhuwoOQocyKJ4aUuM1FhhbNqzqvuG?= =?Windows-1252?Q?smUD4aSbO7/SQmw/O1Nf1veWU8nvtB0ltB3wE2y657gYGHTViguCTw3A?= =?Windows-1252?Q?rpdWKbFIaOET0yO3eG9t3B1Hg/mNp2G8pUVgropDoi1rq6TKu4Kgpjk5?= =?Windows-1252?Q?wiEJ7XvcnBxxxBqB4js9j8f41aOJoUZH9oCUz34ut3t/TwnjRhUnpWJl?= =?Windows-1252?Q?ymG6soB7COM/HZ4A7yMNfkDzqyLpMCJ6kuqblcjDuFWLSP9rg3lDAiYv?= =?Windows-1252?Q?TNnB5eRzcbRgHRBkrapvV/7a1jJMOJtiTuo0jQWRrrVACI6IWy8cfTH5?= =?Windows-1252?Q?c6SslH+8gbZBj/KCjdayGINf5KO037N7THjUB8G6TrTY0GgiSUcBXDmK?= =?Windows-1252?Q?ImP3i7s81X1Ys/Cr0wNAa/NXRw4g1NqKNa6aEzPm07IxhNGumyOeR+x0?= =?Windows-1252?Q?PkVDYB/vkRu8RPVN298vvQa3l+8Wgor2TKuz7FLenDSRbwC1loHyTRch?= =?Windows-1252?Q?CVokOwZTSKPpe9c97zOZqdUyIT2HvQL7Vj+l3IHMh0CMIzhKhz9iNzQ8?= =?Windows-1252?Q?ONlcptcEjz/J9MWdqREe8dD91RdKo0Vq0iA1jZkti2hhdioA/3BWWywX?= =?Windows-1252?Q?gFcs9MFLJzq5hThJJX4Sca8JNl9q6BWDc+mYE3xBj++Op5AYBytyl1/Q?= =?Windows-1252?Q?m2wRAMKZxEw?= X-Microsoft-Exchange-Diagnostics: 1;CY4PR12MB1302;6:H+kgRJTTXVSyHKRyP3zu4bAaX2UmKvhm4XBBdInbfNKKyBLni3RR4DDQ0v/lfgcvPmDXAH8g0taljx73L66Ga49Wcgx9aiL35bpZepiVwRFcrVTgQ8Adsbf6RqWoY/QJn2ginWesYQLpBCj50vpw5x/ScMiWikJh3eHJEkk4gSnnZF05jSCSLoaOMn7dCoUWbvVX0BW1zj3xv3KVZII+oizu6A6dDizHHEya1PgEnkO4wrQqhN5Bb6v0lVHC2JEMM+f9O3ct9rxn+BgHzpD99iuNrXnW5Qey+QjOgbvChSSJfO88FbzC2trdePjXHb9GCntZr2RD5NOcaaqFiknm1w==;5:DR1xDkk1WmT7dl8EBHAokJE/RT9FFKkuXpPInQSIEnTtDS9EhOFac7DXgVboXVH90C1fD+GZz71jlfUNW/rGjSN1QWrm8WETPKgi/iE2rYxmrsZYBqNAEdMyQZzZuB9Qvvf22SQdRsnUe6kWYOlH0g==;24:B/lOEceE/9tYZc1bcbcm04aH55blFyZjOvjPxXkWwHQopHtT9i61ocmqHtKNbbH8g5n7Lt17hA1YYGBcyb84K1U049rFMQAFzgKyUqcP254=;7:oFsqaCa++xQ7sXKVlFvWFpvuKNy7hRApoh7ZITuO4RQmpDGHknl/ItRvBA5odYNE0uUcdEJ+lr3V5dHiMR7ZX/g7QZd6uFvGjgXKuLhnDsB5vdN9PdcK/XWBKCVGi/AmZgYfBMBCz+BErYQC76/mVg1xbD3OYjO/6EB/1jVBlfih1nCMbmGZRTPOzF+rNYN1Xvf1C0uIZSVCEo6WmME5VJtbEtjbNFb0VWO2EuC78TsNu4DG8fYPu76aJNpZbRVuseeSF9aNAQfSc28cwmtFojXTpeAAFVUvGC5MYRf4wIIQkqL/qNlNVH7jmPg71Ac5 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;CY4PR12MB1302;20:5VabqkKv5LRpo7p+ryVMkAAJ4lvsF93IVdeT5rE5i+/PNFlWfZYz1oWQFDuVG+8Jzqba8v8ouou8egPSGNe+J2d+R0RfqTLcf0IbdSUKDF6Q5pRiwKSflwj1VpR3ZsJ3ub0QPbTX5vI0iha/BPs46B6GLiUJUK9D8PQZo1M+GlPih42o/XtAPc58OrotS5EsdAhZrypQS06DwAzmF+Sh59UY0q6F4e7iy9pQSeNh1JcW+TBgPFrviXeukp+CUGqT X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Sep 2016 08:00:07.2999 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR12MB1302 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 19.09.2016 um 09:34 schrieb Arnd Bergmann: > On Monday, September 19, 2016 3:28:39 PM CEST Baoyou Xie wrote: >> We get a few warnings when building kernel with W=1: >> drivers/gpu/drm/amd/amdgpu/../powerplay/smumgr/tonga_smumgr.c:146:5: warning: no previous prototype for 'tonga_program_jump_on_start' [-Wmissing-prototypes] >> drivers/gpu/drm/amd/amdgpu/../powerplay/smumgr/fiji_smumgr.c:816:5: warning: no previous prototype for 'fiji_save_vft_table' [-Wmissing-prototypes] >> drivers/gpu/drm/amd/amdgpu/../powerplay/smumgr/polaris10_smumgr.c:743:5: warning: no previous prototype for 'polaris10_avfs_event_mgr' [-Wmissing-prototypes] >> drivers/gpu/drm/amd/amdgpu/../powerplay/smumgr/iceland_smumgr.c:167:5: warning: no previous prototype for 'iceland_program_jump_on_start' [-Wmissing-prototypes] >> .... >> >> In fact, these functions are only used in the file in which they are >> declared and don't need a declaration, but can be made static. >> So this patch marks these functions with 'static'. >> >> Signed-off-by: Baoyou Xie >> > Hi Baoyou, > > All your drm/amd patches seem fine to me, but again (as with the nouveau > driver patches before), I think it would make more sense to consolidate > them, and do a small number of patches such as > > [PATCH 1/3] drm/amdgpu: add missing includes > [PATCH 2/3] drm/amdgpu: remove unused functions > [PATCH 3/3] drm/amdgpu: mark symbol static where possible > > This is all one big driver, No it isn't. The different parts are developed by different teams at AMD, so the splitting them up is rather welcome here. So please keep your style as it is, at least for the amdgpu driver. Regards, Christian. > and I see no value in splitting it up > per file within the driver. > > Arnd