From: Jonathan Cameron <jic23@kernel.org>
To: Daniel Baluta <daniel.baluta@intel.com>,
Lars-Peter Clausen <lars@metafoo.de>
Cc: Hartmut Knaack <knaack.h@gmx.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH 3/3] Documentation: iio: Add IIO software devices docs
Date: Sat, 23 Apr 2016 22:44:01 +0100 [thread overview]
Message-ID: <15c9a1f0-dffc-63a1-0bcb-2507ed513556@kernel.org> (raw)
In-Reply-To: <CAEnQRZAstpFdr8wwNaVacVzwdTZ2M_R-c=mo4gNUHBP67R6cZw@mail.gmail.com>
On 20/04/16 16:51, Daniel Baluta wrote:
> On Wed, Apr 20, 2016 at 6:44 PM, Lars-Peter Clausen <lars@metafoo.de> wrote:
>> On 04/20/2016 05:45 PM, Daniel Baluta wrote:
>>
>>> +
>>> +What: /config/iio/triggers/dummy
>>
>> s/triggers/devices
>
> :D, will fix in v2. Obviously, one problem of this RFC is that we
> have a lot of duplicate code between the triggers and devices
> in configfs support.
>
We could take this as is, and do the refactor as a follow up series
- kind of up to you really.
The series as a whole looks pretty good to me though a bit of tidying
up is needed in one or two corners. Will take a closer look....
next prev parent reply other threads:[~2016-04-23 21:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-20 15:45 [RFC PATCH 0/3] Introduce support for creating IIO devices via configfs Daniel Baluta
2016-04-20 15:45 ` [RFC PATCH 1/3] iio: Add " Daniel Baluta
2016-04-20 15:45 ` [RFC PATCH 2/3] iio: dummy: Convert IIO dummy to configfs Daniel Baluta
2016-04-24 11:36 ` Jonathan Cameron
2016-04-20 15:45 ` [RFC PATCH 3/3] Documentation: iio: Add IIO software devices docs Daniel Baluta
2016-04-20 15:44 ` Lars-Peter Clausen
2016-04-20 15:51 ` Daniel Baluta
2016-04-23 21:44 ` Jonathan Cameron [this message]
2016-04-24 11:36 ` Jonathan Cameron
2016-04-24 11:28 ` [RFC PATCH 0/3] Introduce support for creating IIO devices via configfs Jonathan Cameron
2016-04-25 7:38 ` Daniel Baluta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15c9a1f0-dffc-63a1-0bcb-2507ed513556@kernel.org \
--to=jic23@kernel.org \
--cc=daniel.baluta@intel.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®