From: Md Sadre Alam <quic_mdalam@quicinc.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: <broonie@kernel.org>, <robh@kernel.org>, <krzk+dt@kernel.org>,
<conor+dt@kernel.org>, <andersson@kernel.org>,
<konradybcio@kernel.org>, <miquel.raynal@bootlin.com>,
<richard@nod.at>, <vigneshr@ti.com>,
<manivannan.sadhasivam@linaro.org>, <vkoul@kernel.org>,
<nikita.shubin@maquefel.me>, <esben@geanix.com>,
<linux-arm-msm@vger.kernel.org>, <linux-spi@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-mtd@lists.infradead.org>, <quic_srichara@quicinc.com>,
<quic_varada@quicinc.com>
Subject: Re: [PATCH v10 1/8] spi: dt-bindings: Introduce qcom,spi-qpic-snand
Date: Mon, 23 Sep 2024 15:34:55 +0530 [thread overview]
Message-ID: <15cc4380-9ca7-c558-2aaf-7cc845c28854@quicinc.com> (raw)
In-Reply-To: <k3id2ywyghhmoiekehko7ear2nef5ygmizvkax5s6sdi2zhn5d@yfhgl5xte4dw>
On 9/23/2024 2:02 AM, Krzysztof Kozlowski wrote:
> On Sun, Sep 22, 2024 at 05:03:44PM +0530, Md Sadre Alam wrote:
>> Document the QPIC-SPI-NAND flash controller present in the IPQ SoCs.
>> It can work both in serial and parallel mode and supports typical
>> SPI-NAND page cache operations.
>>
>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> Signed-off-by: Md Sadre Alam <quic_mdalam@quicinc.com>
>> ---
>>
>> Change in [v10]
>>
>> * No change
>
> ...
>
>> +title: Qualcomm QPIC NAND controller
>> +
>> +maintainers:
>> + - Md sadre Alam <quic_mdalam@quicinc.com>
>> +
>> +description:
>> + The QCOM QPIC-SPI-NAND flash controller is an extended version of
>> + the QCOM QPIC NAND flash controller. It can work both in serial
>> + and parallel mode. It supports typical SPI-NAND page cache
>> + operations in single, dual or quad IO mode with pipelined ECC
>> + encoding/decoding using the QPIC ECC HW engine.
>> +
>> +allOf:
>> + - $ref: /schemas/spi/spi-controller.yaml#
>> +
>> +properties:
>> + compatible:
>> + enum:
>> + - qcom,spi-qpic-snand
>
> Recently it turned out that Qualcomm generic compatibles are not
> generic... That was odd, but to me it is a clear signal that something
> should not be called generic if it is not generic enough.
>
> Please switch to soc-specific compatibles (and drop my reviewed-by, so
> this will appear in my review queue).
Ok , will add in next revision.
>
> Best regards,
> Krzysztof
>
next prev parent reply other threads:[~2024-09-23 10:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-22 11:33 [PATCH v10 0/8] Add QPIC SPI NAND driver Md Sadre Alam
2024-09-22 11:33 ` [PATCH v10 1/8] spi: dt-bindings: Introduce qcom,spi-qpic-snand Md Sadre Alam
2024-09-22 20:32 ` Krzysztof Kozlowski
2024-09-23 10:04 ` Md Sadre Alam [this message]
2024-09-22 11:33 ` [PATCH v10 2/8] mtd: rawnand: qcom: cleanup qcom_nandc driver Md Sadre Alam
2024-09-22 11:33 ` [PATCH v10 3/8] mtd: rawnand: qcom: Add qcom prefix to common api Md Sadre Alam
2024-09-22 11:33 ` [PATCH v10 4/8] mtd: nand: Add qpic_common API file Md Sadre Alam
2024-09-22 11:33 ` [PATCH v10 5/8] mtd: rawnand: qcom: use FIELD_PREP and GENMASK Md Sadre Alam
2024-09-22 11:33 ` [PATCH v10 6/8] spi: spi-qpic: add driver for QCOM SPI NAND flash Interface Md Sadre Alam
2024-09-23 18:52 ` kernel test robot
2024-09-23 23:02 ` kernel test robot
2024-09-22 11:33 ` [PATCH v10 7/8] arm64: dts: qcom: ipq9574: Add SPI nand support Md Sadre Alam
2024-09-22 11:33 ` [PATCH v10 8/8] arm64: dts: qcom: ipq9574: Disable eMMC node Md Sadre Alam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15cc4380-9ca7-c558-2aaf-7cc845c28854@quicinc.com \
--to=quic_mdalam@quicinc.com \
--cc=andersson@kernel.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=esben@geanix.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=miquel.raynal@bootlin.com \
--cc=nikita.shubin@maquefel.me \
--cc=quic_srichara@quicinc.com \
--cc=quic_varada@quicinc.com \
--cc=richard@nod.at \
--cc=robh@kernel.org \
--cc=vigneshr@ti.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®