From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-266630-1521651468-5-1464189402160630021 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no ("Email failed DMARC policy for domain") X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, FREEMAIL_FORGED_FROMDOMAIN 0.249, FREEMAIL_FROM 0.001, HEADER_FROM_DIFFERENT_DOMAINS 0.25, RCVD_IN_DNSWL_MED -2.3, SPF_PASS -0.001, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='140.211.166.138', Host='smtp1.osuosl.org', Country='US', FromHeader='com', MailFrom='org' X-Spam-charsets: plain='us-ascii' X-IgnoreVacation: yes ("Email failed DMARC policy for domain") X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: driverdev-devel-bounces@linuxdriverproject.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1521651468; b=cjtXk6dJ+AXv+hgw9yka/IjogDiNr8Rl+jGIBM6GMibElty 8lYg+v8iaRR5/gyFIEqdnmuZhqPu8k2jtDW0H8TKv1vNz7eDxyKtfkyseXLaEYLs fn1kdhHyOFXIbYuDFW5XgRngobxy4b8dMqp97gU5RJN7w38jJQqWOukxNWiz+Pv8 /1Aux+Wmu2caO+zLk8g4cG2Tr3tTDLvKMvioZoj2pfWipLlBgozM6gABd1un/3BO BBUVzJ9NToO4tUPfZR9mT4YX43Zk+Jq94gi3VyI8N6dIzwZHdS0UP+qWPfYiFX9h NUQCbKvhKpKayMEzysnyGr3rEnsOgfwajCwvlYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=subject:to:references:from:message-id :date:mime-version:in-reply-to:list-id:list-unsubscribe :list-archive:list-post:list-help:list-subscribe:cc:content-type :content-transfer-encoding:sender; s=arctest; t=1521651468; bh=J ij/bmRnxfUwq0GoE4bnfsKkyNmkqW5H1XieL5LgZ/E=; b=EDrqdaJpz4ivsIyl7 jP2d1Kx9ACP2OX3ct8XyO6HPtNK7wDqGvDGyKPQStS9yF0PHk9f6RrJ2xA3Yntjz najSK4hb2OBEoealbYYNVzzBZFfCrqPIIfihDcQ9E9vUBxb0sK9/jmgWYCnoD2x3 IVbI6lQ52ACO/cZB5uYLUHgo6z/ZsACSMd4kGmlNw2iFWj1BA2hS7oIQ3PPkt5gZ 9NvSDDWsJFs0tDTj8Tt9YTKz/iOm7JstpBNl1VgVK/GyLs3gkPF/s+6YnBy4ccmo QqH1e6xdlUQe5ltin2hcfCZ0wsL6lSJf6R+Eoft2Qlq1iAYVAzV12dJbFzIOfUfs qhMOA== ARC-Authentication-Results: i=1; mx3.messagingengine.com; arc=none (no signatures found); dkim=fail (message has been altered, 2048-bit rsa key sha256) header.d=gmail.com header.i=@gmail.com header.b=V5rDHYf+ x-bits=2048 x-keytype=rsa x-algorithm=sha256 x-selector=20161025; dmarc=fail (p=none,has-list-id=yes,d=none) header.from=gmail.com; iprev=pass policy.iprev=140.211.166.138 (smtp1.osuosl.org); spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org smtp.helo=whitealder.osuosl.org; x-aligned-from=fail; x-google-dkim=fail (message has been altered, 2048-bit rsa key) header.d=1e100.net header.i=@1e100.net header.b=JinurUqg; x-ptr=fail x-ptr-helo=whitealder.osuosl.org x-ptr-lookup=smtp1.osuosl.org; x-return-mx=pass smtp.domain=linuxdriverproject.org smtp.result=pass smtp_is_org_domain=yes header.domain=gmail.com header.result=pass header_is_org_domain=yes; x-tls=pass version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128; x-vs=clean score=-100 state=0 Authentication-Results: mx3.messagingengine.com; arc=none (no signatures found); dkim=fail (message has been altered, 2048-bit rsa key sha256) header.d=gmail.com header.i=@gmail.com header.b=V5rDHYf+ x-bits=2048 x-keytype=rsa x-algorithm=sha256 x-selector=20161025; dmarc=fail (p=none,has-list-id=yes,d=none) header.from=gmail.com; iprev=pass policy.iprev=140.211.166.138 (smtp1.osuosl.org); spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org smtp.helo=whitealder.osuosl.org; x-aligned-from=fail; x-google-dkim=fail (message has been altered, 2048-bit rsa key) header.d=1e100.net header.i=@1e100.net header.b=JinurUqg; x-ptr=fail x-ptr-helo=whitealder.osuosl.org x-ptr-lookup=smtp1.osuosl.org; x-return-mx=pass smtp.domain=linuxdriverproject.org smtp.result=pass smtp_is_org_domain=yes header.domain=gmail.com header.result=pass header_is_org_domain=yes; x-tls=pass version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128; x-vs=clean score=-100 state=0 X-ME-VSCategory: clean X-Remote-Delivered-To: driverdev-devel@osuosl.org X-Google-Smtp-Source: AG47ELtZktgvVTZ5Wd+8saYie/ofA3J+T7jX1uSRAP7HpjK+LK25Jk6Ts0KbSeOdGZr6was1GyKkLQ== Subject: Re: [PATCH v2] staging: bcm2835-audio: Release resources on module_exit() To: Andy Shevchenko References: <63ee611d-9fd7-a67a-45aa-229cc4a83ed2@gmail.com> <20180313193414.11535-1-k.marinushkin@gmail.com> <1a59a938-0381-49f4-dfd9-c7a52bdb0eae@gmail.com> From: Kirill Marinushkin Message-ID: <15cc84cc-a887-7473-d64c-00c23e930e0d@gmail.com> Date: Wed, 21 Mar 2018 17:58:06 +0100 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.24 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Stefan Wahren , devel@driverdev.osuosl.org, Florian Fainelli , Scott Branden , Greg Kroah-Hartman , Linux Kernel Mailing List , Eric Anholt , Michael Zoran , bcm-kernel-feedback-list , linux-rpi-kernel@lists.infradead.org, Ray Jui , linux-arm Mailing List Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On 03/21/18 16:03, Andy Shevchenko wrote: > On Thu, Mar 15, 2018 at 7:57 AM, Kirill Marinushkin > wrote: >> On 03/13/18 22:23, Andy Shevchenko wrote: >>> On Tue, Mar 13, 2018 at 9:34 PM, Kirill Marinushkin >>> wrote: >>>> In the current implementation, `rmmod snd_bcm2835` does not release >>>> resources properly. It causes an oops when trying to list sound devices. >>>> >>>> This commit fixes it. >>> Nice catch! >>> >>> See my comments below. >>> >>>> static void snd_devm_unregister_child(struct device *dev, void *res) >>>> { >>>> struct device *childdev = *(struct device **)res; >>>> + struct bcm2835_chip *chip = dev_get_drvdata(childdev); >>>> + struct snd_card *card = chip->card; >>>> + >>>> + snd_card_free(card); >>>> + dev_set_drvdata(childdev, NULL); >>> AFAIU this is done by device core. >> Maybe you are right. But I don't know, which function in the device core does it. >> It is safe to have this line. So, I suggest to keep it. > Please, remove. > If you don't know, perhaps you need to spend more time on doing homework? You are right, I actually should pay more attention to this detail. I will remove this line and send as a patch v3 > % git grep -n -w dev_set_drvdata -- drivers/base/dd.c > drivers/base/dd.c:469: dev_set_drvdata(dev, NULL); > drivers/base/dd.c:499: dev_set_drvdata(dev, NULL); > drivers/base/dd.c:902: dev_set_drvdata(dev, NULL); > > Last one is the point of your interest. > _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel