From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 542B6C5479D for ; Thu, 5 Jan 2023 03:34:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230086AbjAEDeM (ORCPT ); Wed, 4 Jan 2023 22:34:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38614 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230059AbjAEDeJ (ORCPT ); Wed, 4 Jan 2023 22:34:09 -0500 Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D9D4B485B6; Wed, 4 Jan 2023 19:34:08 -0800 (PST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id CCB9B32009B8; Wed, 4 Jan 2023 22:34:04 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Wed, 04 Jan 2023 22:34:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sholland.org; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1672889644; x= 1672976044; bh=J5dtluVJN/sDCz5O/tnIQDUHTV9zIL4n+5iOhogQdAc=; b=f q2f0L04VWkCVzGLPpVpe6pu2vwvu11ugBpr1YE5NsGVWfNamFZTtA6mb8RB7obcI dKiKjqO/7zNxppLTWA1WRgGri6Lmz7dHUdF1Jroo1bDq7kogE4xfTvKubRGwmdwM AhDHzlSTCS4aW5KGxdc7zgfNHR50lbaxDz+Ay1j/5JgkOZKC+5JqIz6GjZbqL6Nb PCRFaa4IQorYDTcKT0IYchcNKTpN9IeDMfIiPWmS8/VzrgZZLeORErEcRXw0mbLS 8mCTnvSfjw/CiDEJn90jQittQ5FwGHk9/9RQiBIkbcHY5n3otPYXs0WhN4NjYqRS vhW6b8N6B/nIsAnn9fPxQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1672889644; x= 1672976044; bh=J5dtluVJN/sDCz5O/tnIQDUHTV9zIL4n+5iOhogQdAc=; b=Q O+QQMzzT6VCvmRtb8h9gVIM9Y7MBT8BBuNHuVMAZTqP3jXCUcw3wGAFCw19LOYHz BrFvURAIwm43NbnQ0F0D5XsN1zm8VKC6Xlf3YweUJxVoRwOo1foK3E5mtBg/304j D1ZzFR3dcGl2IlYefSabtAj8R59DaQO7VvcgyDZR38vmzackopGpHUAjeF/1mmfK QyMKzicWxlH/q8IXJ1mmR2HQ4VB2NQGV/2E49+53/LC3yCa5wqYc9xWO6N26K2AW cg/mXu7+/t1OWrQlHGhIEKFPWtQrH0VaHQwrnMFG5KPGx3YbYUOkAq7ZbOIOFYxy /jHoz5fvBEWwlBGBMf6Hg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrjeejgdeiudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefkffggfgfvvehfhffujggtgfesthejredttdefjeenucfhrhhomhepufgrmhhu vghlucfjohhllhgrnhguuceoshgrmhhuvghlsehshhholhhlrghnugdrohhrgheqnecugg ftrfgrthhtvghrnhepheettdefgeeuudelvdffleejheejueeludduiedvkeffgeetueev vdelvdetfeejnecuffhomhgrihhnpehkvghrnhgvlhdrohhrghenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehsrghmuhgvlhesshhhohhllhgr nhgurdhorhhg X-ME-Proxy: Feedback-ID: i0ad843c9:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 4 Jan 2023 22:34:02 -0500 (EST) Message-ID: <15cd1727-eedd-d476-e52c-2234cf66a5c9@sholland.org> Date: Wed, 4 Jan 2023 21:34:02 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux ppc64le; rv:102.0) Gecko/20100101 Thunderbird/102.3.3 Content-Language: en-US To: Masahiro Yamada Cc: linux-kernel@vger.kernel.org, Christopher Schramm , Nathan Chancellor , Nick Desaulniers , Nicolas Schier , linux-kbuild@vger.kernel.org References: <20230104140459.1147626-1-masahiroy@kernel.org> From: Samuel Holland Subject: Re: [PATCH] kbuild: readd -w option when vmlinux.o or Module.symver is missing In-Reply-To: <20230104140459.1147626-1-masahiroy@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/4/23 08:04, Masahiro Yamada wrote: > Commit 63ffe00d8c93 ("kbuild: Fix running modpost with musl libc") > accidentally turned the unresolved symbol warnings into errors when > vmlinux.o (for in-tree builds) or Module.symver (for external module > builds) is missing. > > In those cases, unresolved symbols are expected, but the -w option > is not set because 'missing-input' is referenced before set. > > Move $(missing-input back to the original place. This should be fine > for musl libc because vmlinux.o and -w are not added at the same time. > > With this change, -w may be passed twice, but it is not a big deal. > > Link: https://lore.kernel.org/all/b56a03b8-2a2a-f833-a5d2-cdc50a7ca2bb@cschramm.eu/ > Fixes: 63ffe00d8c93 ("kbuild: Fix running modpost with musl libc") > Reported-by: Christopher Schramm > Signed-off-by: Masahiro Yamada > --- > > scripts/Makefile.modpost | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) Sorry for the breakage. This works fine for me, with or without vmlinux.o. Tested-by: Samuel Holland