From: Keerthy <j-keerthy@ti.com>
To: <linus.walleij@linaro.org>
Cc: <linux-gpio@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<t-kristo@ti.com>
Subject: Re: [PATCH v2] gpio: davinci: Assign first bank regs for unbanked case
Date: Fri, 24 Nov 2017 12:54:50 +0530 [thread overview]
Message-ID: <15cfc870-272e-0e40-31a5-7dc1c348fe11@ti.com> (raw)
In-Reply-To: <1510312397-29040-1-git-send-email-j-keerthy@ti.com>
On Friday 10 November 2017 04:43 PM, Keerthy wrote:
> As per the re-design assign the first bank regs for unbanked
> irq case. This was missed out in the original patch.
Linus,
A gentle ping.
- Keerthy
>
> Signed-off-by: Keerthy <j-keerthy@ti.com>
> Fixes: b5cf3fd827d2e1 ("gpio: davinci: Redesign driver to accommodate ngpios in one gpio chip")
> ---
>
> Changes in v2:
>
> * Fixed $Author
>
> drivers/gpio/gpio-davinci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c
> index f75d844..e4b3d7d 100644
> --- a/drivers/gpio/gpio-davinci.c
> +++ b/drivers/gpio/gpio-davinci.c
> @@ -383,7 +383,7 @@ static int gpio_irq_type_unbanked(struct irq_data *data, unsigned trigger)
> u32 mask;
>
> d = (struct davinci_gpio_controller *)irq_data_get_irq_handler_data(data);
> - g = (struct davinci_gpio_regs __iomem *)d->regs;
> + g = (struct davinci_gpio_regs __iomem *)d->regs[0];
> mask = __gpio_mask(data->irq - d->base_irq);
>
> if (trigger & ~(IRQ_TYPE_EDGE_FALLING | IRQ_TYPE_EDGE_RISING))
>
next prev parent reply other threads:[~2017-11-24 7:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-10 11:13 Keerthy
2017-11-24 7:24 ` Keerthy [this message]
2017-11-30 14:42 ` Linus Walleij
2017-12-01 4:40 ` Keerthy
2017-12-01 5:29 ` Keerthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15cfc870-272e-0e40-31a5-7dc1c348fe11@ti.com \
--to=j-keerthy@ti.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®