From: "David Hildenbrand (Arm)" <david@kernel.org>
To: Anshuman Khandual <anshuman.khandual@arm.com>, linux-mm@kvack.org
Cc: andriy.shevchenko@linux.intel.com, usama.arif@linux.dev,
hughd@google.com, willy@infradead.org, ryan.roberts@arm.com,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V3] mm: Standardize printing for pgtable entries
Date: Thu, 13 Aug 2026 12:13:48 +0200 [thread overview]
Message-ID: <15d1edae-b9b2-45d9-8246-8d07fbf08bd6@kernel.org> (raw)
In-Reply-To: <20260709044334.1741263-1-anshuman.khandual@arm.com>
On 7/9/26 06:43, Anshuman Khandual wrote:
> From: "David Hildenbrand (Arm)" <david@kernel.org>
>
> Bad page map reporting currently stores page table entry values in an
> unsigned long long and prints them with fixed 64-bit-oriented format
> strings. This is inconsistent across call sites and does not work well for
> architectures where page table entry values are not naturally represented
> as 64-bit values, such as 32-bit or 128-bit entries.
>
> Introduce a common helper to convert raw page table entry values into a
> fixed-width hexadecimal string based on the actual entry size. Use it for
> bad page map reporting and for dumping the page table walk in
> __print_bad_page_map_pgtable().
>
> Pass page table entry values to the reporting path as raw bytes together
> with their size, instead of forcing them through an unsigned long long.
> It keeps the printed output consistent and avoids truncation or misleading
> formatting for non-64-bit page table entries.
>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: linux-mm@kvack.org
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: David Hildenbrand (Arm) <david@kernel.org>
> Co-developed-by: Anshuman Khandual <anshuman.khandual@arm.com>
> Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com>
> ---
From the discussion I conclude that this patch is good to go now. I wrote it,
Anshuman cleaned it up.
LGTM
(adding my own ACK/RB is weird ;) )
--
Cheers,
David
prev parent reply other threads:[~2026-08-13 10:13 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-09 4:43 Anshuman Khandual
2026-07-09 7:40 ` Andy Shevchenko
2026-07-09 9:12 ` David Hildenbrand (Arm)
2026-07-09 10:09 ` Andy Shevchenko
2026-07-09 10:19 ` David Hildenbrand (Arm)
2026-07-09 9:15 ` Petr Mladek
2026-07-09 10:11 ` Andy Shevchenko
2026-07-09 10:13 ` Andy Shevchenko
2026-07-09 10:24 ` David Hildenbrand (Arm)
2026-07-09 10:43 ` Andy Shevchenko
2026-07-09 11:12 ` Anshuman Khandual
2026-07-09 11:54 ` Andy Shevchenko
2026-07-10 0:08 ` Andrew Morton
2026-07-10 3:10 ` Anshuman Khandual
2026-07-10 3:32 ` Andrew Morton
2026-07-10 8:16 ` David Hildenbrand (Arm)
2026-07-11 4:58 ` Matthew Wilcox
2026-07-13 2:37 ` Anshuman Khandual
2026-07-13 9:30 ` David Hildenbrand (Arm)
2026-07-13 11:36 ` Andy Shevchenko
2026-07-13 12:31 ` David Hildenbrand (Arm)
2026-07-13 12:34 ` Matthew Wilcox
2026-07-13 12:37 ` David Hildenbrand (Arm)
2026-07-13 16:06 ` Andy Shevchenko
2026-07-27 12:50 ` Anshuman Khandual
2026-08-07 0:56 ` Andy Shevchenko
2026-08-13 10:13 ` David Hildenbrand (Arm) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15d1edae-b9b2-45d9-8246-8d07fbf08bd6@kernel.org \
--to=david@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=anshuman.khandual@arm.com \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ryan.roberts@arm.com \
--cc=usama.arif@linux.dev \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®