From: Bart Van Assche <bvanassche@acm.org>
To: Finn Thain <fthain@linux-m68k.org>,
"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Daniel Palmer <daniel@0x0f.com>,
Michael Schmitz <schmitzmic@gmail.com>,
stable@kernel.org, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: wd33c93: Don't use stale scsi_pointer value
Date: Thu, 3 Oct 2024 09:57:10 -0700 [thread overview]
Message-ID: <15d49b6b-3654-4cad-b770-be36a406e356@acm.org> (raw)
In-Reply-To: <09e11a0a54e6aa2a88bd214526d305aaf018f523.1727926187.git.fthain@linux-m68k.org>
On 10/2/24 8:29 PM, Finn Thain wrote:
> diff --git a/drivers/scsi/wd33c93.c b/drivers/scsi/wd33c93.c
> index a44b60c9004a..dd1fef9226f2 100644
> --- a/drivers/scsi/wd33c93.c
> +++ b/drivers/scsi/wd33c93.c
> @@ -831,7 +831,7 @@ wd33c93_intr(struct Scsi_Host *instance)
> /* construct an IDENTIFY message with correct disconnect bit */
>
> hostdata->outgoing_msg[0] = IDENTIFY(0, cmd->device->lun);
> - if (scsi_pointer->phase)
> + if (WD33C93_scsi_pointer(cmd)->phase)
> hostdata->outgoing_msg[0] |= 0x40;
>
> if (hostdata->sync_stat[cmd->device->id] == SS_FIRST) {
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
next prev parent reply other threads:[~2024-10-03 16:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-03 3:29 Finn Thain
2024-10-03 7:07 ` Michael Schmitz
2024-10-03 16:57 ` Bart Van Assche [this message]
2024-10-04 2:08 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15d49b6b-3654-4cad-b770-be36a406e356@acm.org \
--to=bvanassche@acm.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=daniel@0x0f.com \
--cc=fthain@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=schmitzmic@gmail.com \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®