From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S938365AbdEXGUW (ORCPT ); Wed, 24 May 2017 02:20:22 -0400 Received: from smtp2.provo.novell.com ([137.65.250.81]:58231 "EHLO smtp2.provo.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934927AbdEXGUT (ORCPT ); Wed, 24 May 2017 02:20:19 -0400 Subject: Re: [Ocfs2-devel] [PATCH v2] ocfs2: fix a static checker warning To: Gang He , mfasheh@versity.com, jlbec@evilplan.org Cc: linux-kernel@vger.kernel.org, ocfs2-devel@oss.oracle.com References: <1495516634-1952-1-git-send-email-ghe@suse.com> From: Eric Ren Message-ID: <15d5493a-26a4-65a0-0421-d6c921b73bb6@suse.com> Date: Wed, 24 May 2017 14:17:46 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 In-Reply-To: <1495516634-1952-1-git-send-email-ghe@suse.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/23/2017 01:17 PM, Gang He wrote: > This patch will fix a static code checker warning, which looks > like below, > fs/ocfs2/inode.c:179 ocfs2_iget() > warn: passing zero to 'ERR_PTR' > > this warning was caused by the > commit d56a8f32e4c6 ("ocfs2: check/fix inode block for online file check"). > after apply this patch, the error return value will not be NULL(zero). > > Signed-off-by: Gang He Looks good to me. Reviewed-by: Eric Ren > --- > fs/ocfs2/inode.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/ocfs2/inode.c b/fs/ocfs2/inode.c > index 382401d..1a1e007 100644 > --- a/fs/ocfs2/inode.c > +++ b/fs/ocfs2/inode.c > @@ -136,7 +136,7 @@ struct inode *ocfs2_ilookup(struct super_block *sb, u64 blkno) > struct inode *ocfs2_iget(struct ocfs2_super *osb, u64 blkno, unsigned flags, > int sysfile_type) > { > - int rc = 0; > + int rc = -ESTALE; > struct inode *inode = NULL; > struct super_block *sb = osb->sb; > struct ocfs2_find_inode_args args;