mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paolo Abeni <pabeni@redhat.com>
To: Aahil Awatramani <aahila@google.com>,
	David Dillow <dave@thedillows.org>,
	 Mahesh Bandewar <maheshb@google.com>,
	Jay Vosburgh <j.vosburgh@gmail.com>,
	Hangbin Liu <liuhangbin@gmail.com>,
	 Andy Gospodarek <andy@greyhouse.net>,
	"David S . Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	 Jakub Kicinski <kuba@kernel.org>,
	Martin KaFai Lau <martin.lau@kernel.org>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	Daniel Borkmann <daniel@iogearbox.net>,
	 netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v6] bonding: Add independent control state machine
Date: Thu, 01 Feb 2024 11:15:40 +0100	[thread overview]
Message-ID: <15d7f2941394e04d45f98aa6d095b1e07262655c.camel@redhat.com> (raw)
In-Reply-To: <20240129202741.3424902-1-aahila@google.com>

On Mon, 2024-01-29 at 20:27 +0000, Aahil Awatramani wrote:
> Add support for the independent control state machine per IEEE
> 802.1AX-2008 5.4.15 in addition to the existing implementation of the
> coupled control state machine.
> 
> Introduces two new states, AD_MUX_COLLECTING and AD_MUX_DISTRIBUTING in
> the LACP MUX state machine for separated handling of an initial
> Collecting state before the Collecting and Distributing state. This
> enables a port to be in a state where it can receive incoming packets
> while not still distributing. This is useful for reducing packet loss when
> a port begins distributing before its partner is able to collect.

If I read the code correctly, the transition
AD_MUX_COLLECTING_DISTRIBUTING -> AD_MUX_DISTRIBUTING is not possible,
am I correct?

Any chance we can have some coverage via self-tests?

Thanks,

Paolo


  reply	other threads:[~2024-02-01 10:15 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-29 20:27 Aahil Awatramani
2024-02-01 10:15 ` Paolo Abeni [this message]
2024-02-01 14:43   ` Jay Vosburgh
2024-02-01 14:52     ` Paolo Abeni
2024-02-01 16:21 ` Jiri Pirko
2024-02-01 18:45   ` Aahil Awatramani
2024-02-02  7:17     ` Jiri Pirko
2024-02-02 17:59       ` Aahil Awatramani

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=15d7f2941394e04d45f98aa6d095b1e07262655c.camel@redhat.com \
    --to=pabeni@redhat.com \
    --cc=aahila@google.com \
    --cc=andy@greyhouse.net \
    --cc=daniel@iogearbox.net \
    --cc=dave@thedillows.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=j.vosburgh@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=liuhangbin@gmail.com \
    --cc=maheshb@google.com \
    --cc=martin.lau@kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®