From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C9E823CCFC0 for ; Fri, 3 Apr 2026 16:06:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775232394; cv=none; b=GccCnRPL4IXnbVbaQib14LNgbH2rR7WxuERjIfQy24Czn4hx808/NsBPyYp1RHcqVyojLUXVO6q0MkT2koJfyERhKmWpOcCeF5J0vLEaaMSNpMl+18zWB2d/Y+SFjhxmatf06FGqsIY6n4e+9vQVX7PdZkPPHoGqLCfQYfxRzhk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775232394; c=relaxed/simple; bh=xQBPZREomER8ilLHH+NLd8Q+ITnzkaC4RtwK1iEadt0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=NDXBJQYNP/1vMWG4ZTlLlHxT6mM61MXZCcp/hca0m9lQimNvwvaGt0/GDBBeoM8cRPBjKxEWUXse2+1oCOiybp5+fz52EwyJs7Jl6rsOd0msZa6fJM0EO53U/v6yvaEP2pIzLbcXfWmTtWKfRGVSYSHogTzViHZ99AkGO2beTsA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=UfiYMppm; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="UfiYMppm" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-4888375f735so17540945e9.3 for ; Fri, 03 Apr 2026 09:06:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1775232387; x=1775837187; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=r5HNxQIi8JAaOPklyHHiUQC1mXkMBZvxx//VBNeSE4M=; b=UfiYMppmoPNvddsnwKLjK9pg5cMF+y0FrJ/xXV+ylpkMnloy5EwUIoXp7Q1hUx8llg 6y64DrBwFfhc2KdJJuK/dpUM9ElroQgtynAWmeqhpmWEVoVRgFvQQYXy/Nqc3ZqHf8uQ fSah33ke9gOJC/2cboCPPMMkaqYCkXoeyvANxlCHM09UdnDuzpv8SPSHAgnQNz+Vd1vf l8oJYPXqxEU3Y/Mzc0bjbsR6JnXC2jMcCMIvR2JbgCyvdUMgcZ3zHjKfz6hyS8PqoUS5 E1syKbq3F+UdZ3zUd6nLsW6A+yYvkJTl6RD6K6yaM31nNdN196okgSMieATbqIUTOXMI Rg3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775232387; x=1775837187; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=r5HNxQIi8JAaOPklyHHiUQC1mXkMBZvxx//VBNeSE4M=; b=ACsJmles/ZxkxCJsohXpxitiCYFwVs+KI5USPyEuZ7boqNQBWUIQWv28Rsfc6OwrOz 3k7SSsWINZi1VPJ3P8Hw9R88eKxdnhE3yEhKUkS5BACJu9da3Oqpx+Fn3m3YuXghhrGs 9DkK0Flt07B5NqELRs6KMyS2FNQvzlAsT9qjPBZLD3TizI4r/439AFeajwWoZHluOIEk gao+xH1nHtI+8NYGwUjM8dYe08noalfnp0+vY9div3JT2tm1LVAh7DQVxNi0zHnpBd3R Q5C0htAFYIgx3BaVm165Tnip6rWJTkypI1dnbLH5/fbwwIGz3t6R9P9UKPhTN64lIDsi Ri3Q== X-Forwarded-Encrypted: i=1; AJvYcCUVuP8R+1KbnwcjdD7FvMMERCyeOb+JAZ9XqzFr3Mxiw6rZe4j8n6akn8WeJFEccbP268HnILNjxnTtslI=@vger.kernel.org X-Gm-Message-State: AOJu0YyCZ1XaV/NFYKOO1F8qs9uJdFu6QjpJCNhYmwa0LHMdr/KYTGVx qQp+QR8TdnU+KCjAeC6FXVqHk50A/FGh6+iJ1xvjN3RyTr2bzVpgyNFCOcL/Pw1KjeA= X-Gm-Gg: ATEYQzzDwPyDyrdiwg69uvbi0RV05SmpgQijjQRiGsBQw4e9soxQWBe41sv/Xn4DhWc Tl7glDidLIvjrFuK2koRYLNZVkTOrXAZ/SYDxa380fIiKG3M33T/tVxjdRTnhdvC4FmGEgsNShS sTg+/YbDdiU1yh66cfaaW+QxMHW2gkwJpz8vnnOGHJwL50JMo9Z7f6uB4hT/0nTaGZuYl5ir2qe +r5W2a1wjHogitulaBxV7mNB5shr7BfO+kEE3gabl6y70WeWsOB81uJvgLrBmaaeOOi5fVso1/b dvNSwblEvHzEKgUkS48Zqu2xcaa09mWj8aqZc41fcUuza7XrgvSSLFO3Y2ZXzYl7Mbu3dls9mth Opv5TKNzuVV7x6TW9w4vN8z7rlHzTUHGDpI0i0V9pagHp3oHHWFgJGxRLkkRgeN+BEw2biehIad t5ei1WUjXBAUxNTF4IXCYKukbQsReuA8KHVODIN2+UrWuEgi4ZEu7g8AODWiugZo09WnA= X-Received: by 2002:a05:600c:4f11:b0:486:f9aa:2b57 with SMTP id 5b1f17b1804b1-488997b3aa5mr59619705e9.16.1775232387122; Fri, 03 Apr 2026 09:06:27 -0700 (PDT) Received: from ?IPV6:2001:a61:13a0:6901:49a0:3a9e:c592:7d89? ([2001:a61:13a0:6901:49a0:3a9e:c592:7d89]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4887e952b0bsm256313355e9.12.2026.04.03.09.06.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Apr 2026 09:06:26 -0700 (PDT) Message-ID: <15d8dc67-1f2d-4df3-a7ee-2d093dd9a1c5@suse.com> Date: Fri, 3 Apr 2026 18:06:21 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] USB: cdc-acm: Add support for second ACM channel on more Nokia phones To: =?UTF-8?B?0KDRi9C20L7QsiDQpNGR0LTQvtGA?= , Oliver Neukum , "linux-kernel@vger.kernel.org" Cc: "gregkh@linuxfoundation.org" , "linux-usb@vger.kernel.org" References: <7ae48e14-0228-4bd9-91df-306dcd12896c@suse.com> <7dcc9837-52e8-4760-b710-403d464f908f@outlook.com> Content-Language: en-US From: Oliver Neukum In-Reply-To: <7dcc9837-52e8-4760-b710-403d464f908f@outlook.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi, On 03.04.26 15:20, Рыжов Фёдор wrote: > Nokia phones have two kinds of model names: "commercial" (for example, "X3-02") and "type identifier" (my X3-02 is "RM-639"). There are cases when different phones (with different RM codes) were released under one commercial name. They look and work very similarly, but may have difference in memory amount, radio bands, SIM operator lock, region-specific SARs, etc. For example, T-Mobile branded Lumia 710 is "RM-809", but "global version" has code "RM-803". > > Different RM-models have different incompatible firmwares. They also have different USB PIDs. That's why there are multiple lines with same model name. Thank you for this response. This is important information. Hence I'd like to request that you add a general comment to the driver with your patch giving exactly this explanation for device appearing twice. Right in front of the declaration would be best. We really should make sure we do not lose such information. Regards Oliver