mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Manivannan Sadhasivam <mani@kernel.org>,
	Krishna Chaitanya Chundru <krishna.chundru@oss.qualcomm.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/8] arm64: dts: qcom: Add t-power-on-us property for PCIe root ports
Date: Mon, 21 Sep 2026 13:44:50 +0200	[thread overview]
Message-ID: <15daa9f3-162c-43fd-b22e-0194b82f602c@oss.qualcomm.com> (raw)
In-Reply-To: <fbtundyvbywomj67ee3jyogqhgrvndrjqctvkb7ttp7iy7pkvq@xocvzaiq7zmg>

On 9/21/26 1:34 PM, Manivannan Sadhasivam wrote:
> On Mon, Sep 21, 2026 at 04:40:43PM +0530, Krishna Chaitanya Chundru wrote:
>>
>>
>> On 9/21/2026 2:09 PM, Konrad Dybcio wrote:
>>> On 9/11/26 8:50 AM, Krishna Chaitanya Chundru wrote:
>>>> The Qualcomm PCIe host controller driver added support for parsing the
>>>> -power-on-us property[1] from each Root Port node and programming it as
>>>> art of host initialization (PCI: qcom: Program T_POWER_ON) [2]. Prior to
>>>> this, T_POWER_ON was expected to be programmed correctly in hardware or
>>>> by the bootloader, but not all targets support this, which can lead to an
>>>> incorrectly calculated LTR_L1.2_THRESHOLD in aspm.c and improper L1.2 exit
>>>> behavior.
>>> This is a good problem description. Does it have observable effects
>>> that could also be mentioned here, beyond perhaps lspci reporting
>>> an odd value?
>> we haven't seen direct problem till now, but we might seen some issue due to
>> incorrect LTR_L1.2_THRESHOLD value.
> 
> Can you specify what issue can be seen without this series? I'd assume the
> link will fail to enter L1.2 and will result in slightly more power drain as
> the link can only enter L1.1.

Would that produce an explicit warning message somewhere?

i.e. can I reasonably be able to tell I'm missing this change and
I need it?

(if not, this is of course not a blocker, but the answer to that
question is always worth sharing)

Konrad

  reply	other threads:[~2026-09-21 11:44 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-11  6:50 Krishna Chaitanya Chundru
2026-09-11  6:50 ` [PATCH 1/8] arm64: dts: qcom: kodiak: " Krishna Chaitanya Chundru
2026-10-16 10:32   ` Konrad Dybcio
2026-09-11  6:50 ` [PATCH 2/8] arm64: dts: qcom: lemans: " Krishna Chaitanya Chundru
2026-09-11  6:50 ` [PATCH 3/8] arm64: dts: qcom: monaco: " Krishna Chaitanya Chundru
2026-09-11  6:50 ` [PATCH 4/8] arm64: dts: qcom: hamoa: " Krishna Chaitanya Chundru
2026-09-11  6:50 ` [PATCH 5/8] arm64: dts: qcom: glymur: " Krishna Chaitanya Chundru
2026-09-11  6:50 ` [PATCH 6/8] arm64: dts: qcom: talos: Add t-power-on-us property for PCIe root port Krishna Chaitanya Chundru
2026-09-11  6:50 ` [PATCH 7/8] arm64: dts: qcom: sm8750: " Krishna Chaitanya Chundru
2026-09-11  6:50 ` [PATCH 8/8] arm64: dts: qcom: kaanapali: " Krishna Chaitanya Chundru
2026-09-21  8:39 ` [PATCH 0/8] arm64: dts: qcom: Add t-power-on-us property for PCIe root ports Konrad Dybcio
2026-09-21 11:10   ` Krishna Chaitanya Chundru
2026-09-21 11:34     ` Manivannan Sadhasivam
2026-09-21 11:44       ` Konrad Dybcio [this message]
2026-09-21 11:54         ` Manivannan Sadhasivam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=15daa9f3-162c-43fd-b22e-0194b82f602c@oss.qualcomm.com \
    --to=konrad.dybcio@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konradybcio@kernel.org \
    --cc=krishna.chundru@oss.qualcomm.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mani@kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®