mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sheng Yong <shengyong2021@gmail.com>
To: Vlastimil Babka <vbabka@suse.cz>,
	akpm@linux-foundation.org, willy@infradead.org
Cc: linux-kernel@vger.kernel.org, linux-mm@archiver.kernel.org,
	Sheng Yong <shengyong1@xiaomi.com>
Subject: Re: [PATCH v2] lib/iov_iter: fix to increase non slab folio refcount
Date: Wed, 2 Apr 2025 21:36:49 +0800	[thread overview]
Message-ID: <15dfe0c4-c1cb-4146-ab06-cd36b7412b2e@gmail.com> (raw)
In-Reply-To: <b2c07fdf-5ab1-4a65-9ce2-38638b7c718e@suse.cz>

On 4/1/25 23:22, Vlastimil Babka wrote:
> On 4/1/25 16:47, Sheng Yong wrote:
>> From: Sheng Yong <shengyong1@xiaomi.com>
[...]
>>
>> Fixes: b9c0e49abfca ("mm: decline to manipulate the refcount on a slab page")
> 
> Sigh. That went to v6.14
> 
> mm-hotfixes and Cc: stable then?

Hi, Vlastimil,

Shall I resend this patch with Cc: tag to the stable list?

thanks,
sheng

> 
>> Signed-off-by: Sheng Yong <shengyong1@xiaomi.com>
> 
> Acked-by: Vlastimil Babka <vbabka@suse.cz>
> 
> Thanks.
> 
>> ---
>>   lib/iov_iter.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>> ---
>> v2:
>>    * update commit message
>>    * update coding style
>>
>> diff --git a/lib/iov_iter.c b/lib/iov_iter.c
>> index 8c7fdb7d8c8f..bc9391e55d57 100644
>> --- a/lib/iov_iter.c
>> +++ b/lib/iov_iter.c
>> @@ -1191,7 +1191,7 @@ static ssize_t __iov_iter_get_pages_alloc(struct iov_iter *i,
>>   			return -ENOMEM;
>>   		p = *pages;
>>   		for (int k = 0; k < n; k++) {
>> -			struct folio *folio = page_folio(page);
>> +			struct folio *folio = page_folio(page + k);
>>   			p[k] = page + k;
>>   			if (!folio_test_slab(folio))
>>   				folio_get(folio);
> 


  reply	other threads:[~2025-04-02 13:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-01 14:47 Sheng Yong
2025-04-01 15:12 ` Matthew Wilcox
2025-04-01 15:22 ` Vlastimil Babka
2025-04-02 13:36   ` Sheng Yong [this message]
2025-04-02 13:45     ` Vlastimil Babka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=15dfe0c4-c1cb-4146-ab06-cd36b7412b2e@gmail.com \
    --to=shengyong2021@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@archiver.kernel.org \
    --cc=shengyong1@xiaomi.com \
    --cc=vbabka@suse.cz \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®