From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DF39A48B369 for ; Wed, 19 Aug 2026 16:42:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787157766; cv=none; b=FWGaYA/3eNYvAhjpSAulJdfoDT++GaA2kbM3zJsRplLgVmV1jKFMkBXN879YZyp0+AvLQC1F5QaKlUaszif403ARNAyqLNXnBBBniaCooP/VJzfwZwn/oHeaE8YEYmoUp8unUyzBiz2AV5z0JJ0bsRly1TvUUOCJvCmAKlxlxjQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787157766; c=relaxed/simple; bh=dnnJsqU4mxv4k6GlZLXQBcd/tcabPrF8oyB8KzBmS/k=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=n3/BUEHL1aP4TfXygqhzLOkzJo4NeYlsRIrV2jeh759NZ4gvRTWpUwUQvOrL2hTEEGCH71oiBIKL3J35zpwMV7qDQ9IT39gxN/JdfErgEWOTFqD5t/7kDBZUAJo6G6m2Nq/wcL6lgz5/wQkO1HoBjbKInbqnHRoj7okl1ngciEM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=AuzZPY9+; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=V7GJlQfq; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="AuzZPY9+"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="V7GJlQfq" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67JF2f5j191535 for ; Wed, 19 Aug 2026 16:42:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= qRihAgXtPmtMUikBEdmJ4hML3Ufb8kUSAwFw3nA/UW4=; b=AuzZPY9+vKgh7Tdn vYf+rDryj3mhfQwdxiDxsygpfGYWymmAP02vTjmSl+uBQ92np7H8OOrs4hXg8hT9 p8JQoP1nNvOwl1xvsEBGvz4ZTxcr1mbNhDetYjOuItIZ2syVc5KVP+f20dmshNKE anAfp1G2Zxo5g0Scvw1YI1LI6AC51irdDCMt6d+VcNZOZqzpK/yuAJPBb5+0ppni U+m+DBTMu+3rv4UAZhdK2Tnfwe/otXMtgKkPVjFxcVKq1EyYqMuiXflBRlPOz27I K+vMkpbDog4XfhxSWCh5FYQmtSw9v92xegr5OfZbIxxaJeD/qmwyD5P4A9ycmwTK C6ZtBA== Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g5esc0j65-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 19 Aug 2026 16:42:44 +0000 (GMT) Received: by mail-pg1-f199.google.com with SMTP id 41be03b00d2f7-cb11535e6a1so1017062a12.0 for ; Wed, 19 Aug 2026 09:42:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1787157763; x=1787762563; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=qRihAgXtPmtMUikBEdmJ4hML3Ufb8kUSAwFw3nA/UW4=; b=V7GJlQfqBniUVLyRmuHYFQDNiNHB0ScTGUKSb+AjUwfSrNuOY+1YOs3fFTNQx45ou8 FaLLcUzjvuKvtYNZOWZlwwBXp56SDfrM7zzzF3bQj2l+O4MdWQX8hiS8PPakHlzm6C+L RDKYzcdUzEZz1tbJ2gI8P8S0u6KykWUc8YImoRcN1AaLVKdv52Oz6JQHmYPo2dupEXvu iM5zUEWXrDLqBaYX50Sfa7/cPchQJcEkEiaYwheAhqNP0C51f5opPuc/JsSWsaIFY4ep tVeq8IatXVmlmq3ej5XJxVP6B4K5DTd2gW6ACLtWEwsmSijT52iDH0aqp1uHVdudrIJL Zxnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787157763; x=1787762563; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=qRihAgXtPmtMUikBEdmJ4hML3Ufb8kUSAwFw3nA/UW4=; b=UHcOAj8UsujwjlAsdVX5hCE+1xKS/bvKwnOresBZszQrOybT6Di2pMvbCmqinlJ/DR yOz8t/dpW42Sp0WRqmyQ8Hj6b/arrQko1Pj0UwBCnT+38yhvR5GaC6TcL7gmvXlYIsjC zSWoxIe8OW41dNUaAGluzbbd06nXAn5CDWdoW0I964iE4N8/WQwHljZICXzlf6Nahi8n RpdC56r4fsFlWDBQINgQA868eVbEHKp1VxfSHqBZ+Up+3TBs2COtVJsVk3Y4HaI3yPr5 455MurBAVoEQZ/eRGPfFTaY2/n3doLmwR8IMEX+UXZLlWCbRwdtl2NCWgz3TP2+6NvfP mBIA== X-Forwarded-Encrypted: i=1; AHgh+RrjCgn8XtbibQM7KI8eOZ0PilCRTdd76Kd0r5IedAG4nDZC7cjzJtvexBHyR3pi38m4pYezSkcqalwT9nc=@vger.kernel.org X-Gm-Message-State: AOJu0Yzfortaq5kB6yAHOdpL9ZFcAqrIeSsb2l+2oFuDrX9qN9wWnlPN 6WCcqk2+yA86o6Qf7OcKOfQy7mz6luvRKpoWIXWLkFfMx+hkvT5Qe1IdsMzKNjlYjdxwHHjMeGd kDnjb6od6X0KuL6cDE0Hid/26kIHrHeLa8d8CTmZQ00T/KxDuYbMqyBq6dLHEYq1noDM4dipuYd o= X-Gm-Gg: AR+sD10g2dxnmah+2k/X90fx+nH9T8UBUAi9W1rrYOU9HsDL5PF5726J6eZlJbk2SjA vSLw0SYB2Vd/sldjKflZR0l2pDojlthtbl2IUxVny701phiEmj/ibrPVstXFQR6P3f1ej/odU17 BnWOBlPb74L62RNlKXAAvmYFBIsoXJQ19BNa4jSd5eHa4V1lq0G7jYl7cebFuBBCXlydACzQLcR e4EdjmBu6fxkkD0SNVsnayyG8PFX3ZSB8TTcT5gWBE/nZcLplojfG76laZOOBNe0VJp+GhonBPz Kj1aLOHMG40jZy7vpZU/6o1az254qaC5DAUZ1j+sa8goVIEwze6TlfeUFZmhjIjC9pCzY63IPfC 7xXQtf71xHmpi5VwtLs33HGFle4qApfdE X-Received: by 2002:a05:6a00:2e9c:b0:846:bc81:3e29 with SMTP id d2e1a72fcca58-851d381a661mr9382981b3a.2.1787157763448; Wed, 19 Aug 2026 09:42:43 -0700 (PDT) X-Received: by 2002:a05:6a00:2e9c:b0:846:bc81:3e29 with SMTP id d2e1a72fcca58-851d381a661mr9382902b3a.2.1787157762897; Wed, 19 Aug 2026 09:42:42 -0700 (PDT) Received: from [192.168.0.6] ([49.204.111.201]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-851d33b635bsm881060b3a.26.2026.08.19.09.42.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 Aug 2026 09:42:42 -0700 (PDT) Message-ID: <15e37bb5-db13-4c09-b5c5-a9e92030eb60@oss.qualcomm.com> Date: Wed, 19 Aug 2026 22:12:36 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/2] spi: qcom-geni: Use GPIO to notify master of SPI target activity To: Konrad Dybcio , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andy Gross , Bjorn Andersson Cc: chandana.chiluveru@oss.qualcomm.com, Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, linux-spi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260818-use_gpio_to_notify_master_of_spi_target_activity-v3-0-e1c9e0dabbda@oss.qualcomm.com> <20260818-use_gpio_to_notify_master_of_spi_target_activity-v3-2-e1c9e0dabbda@oss.qualcomm.com> <09f10e30-f613-4a22-941c-1db63b190186@oss.qualcomm.com> Content-Language: en-US From: Praveen Talari In-Reply-To: <09f10e30-f613-4a22-941c-1db63b190186@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: byomzRGAwjkxp2UTXAFnCGsmFNkENZzk X-Proofpoint-Spam-Info: AW1haW4tMjYwODE5MDEzMCBTYWx0ZWRfXzxPdUKDNMtdC XIr9lrZ2c4X/yE39T/QgrPMwwizosWyUCcRW6bh8ywGG0EOsAFslg6/KMHrPo27R+tu3Mf6xpOK tBwA8BMihqvaNh4TlR6Z0fbs74T/dos= X-Proofpoint-ORIG-GUID: byomzRGAwjkxp2UTXAFnCGsmFNkENZzk X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODE5MDEzMCBTYWx0ZWRfX0MGaAnQmo3wU 1Heo80Va7kBEJqk48L3BVIb7/Iej///AmSGeCqcATx3NWPiV263DFKSSHVPdUvGviPaKHWSr6Pw L+KqYAdb5DvYgUgSpS9pdXHFjEgDxw/LGqiFf5tC+o2Gd3uUeAg+l8ov72gI9c9L6cdG5tZe6kP UZFMOh1VyWSUDQIxuMWg23SPOtZlffEUFxMBWsPa18+GzYKBTIdS510LyrYX4ZP4DPvf4FweFNY /aQ+wHxDouN7Q7ChbemCfrpdqHFNqco7OWcvJPo6llsl0X4d5yu/7kuS/3Pq2FfZd99wMQH6rKa TtSgqHQt5KcJ3LeTYImZx93jzu58wB91mXo+skXcoIA5YaZhaxvS3Hq9Dc+athNUjD7MBJXipms Dl9vKcJvE4mAIF3slNupf7Fb/G19GdVZ9Pa6mnw12C3Wo/N+vDrkhfaEHS1jvdUg+yl6vQcAmYZ dTT4cd6TNBhAONyej7w== X-Authority-Analysis: v=2.4 cv=b6uCJNGx c=1 sm=1 tr=0 ts=6a85dd04 cx=c_pps a=Oh5Dbbf/trHjhBongsHeRQ==:117 a=HCveIaAj3rmBjkKtjFsTTQ==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=C9Icw_Sg0KBB5CD6VC8A:9 a=QEXdDO2ut3YA:10 a=_Vgx9l1VpLgwpw_dHYaR:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-19_04,2026-08-19_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 malwarescore=0 lowpriorityscore=0 priorityscore=1501 suspectscore=0 spamscore=0 clxscore=1015 bulkscore=0 adultscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608190130 Hi konrad On 19-08-2026 19:30, Konrad Dybcio wrote: > On 8/18/26 3:38 PM, Praveen Talari wrote: >> When operating in SPI target mode, the GENI controller relies on an >> external GPIO to notify the SPI master about the target's active state. >> >> Add support for an optional ready GPIO that is asserted when a target >> transfer begins and deasserted when the transfer completes, is aborted, >> or hits a timeout. This allows the target to explicitly signal its >> availability to the master and ensures the GPIO is released in all error >> and completion paths, preventing the master from observing a stale or >> incorrect target-ready indication. > [...] > >> + if (spi->target && mas->target_gpio) >> + gpiod_set_value(mas->target_gpio, 0); > FWIW it seems like the gpiod APIs can eat nullptrs Oh, let me review and update. > > [...] > >> @@ -1131,8 +1144,16 @@ static int spi_geni_probe(struct platform_device *pdev) >> init_completion(&mas->rx_reset_done); >> spin_lock_init(&mas->lock); >> >> - if (spi->target) >> + if (spi->target) { >> spi->target_abort = spi_geni_target_abort; >> + mas->target_gpio = devm_gpiod_get_index_optional(dev, "ready", 0, >> + GPIOD_OUT_LOW); > Is there a reason for the get_index_ variant specifically? There is no specific reason. i just had choosen with index. > > i.e. why not just devm_gpiod_get_optional()? Yes, we can use it. Thanks, Praveen Talari > > Konrad