From: Arturas Moskvinas <arturas.moskvinas@gmail.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: linus.walleij@linaro.org, u.kleine-koenig@pengutronix.de,
andriy.shevchenko@linux.intel.com, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] gpio: 74x164: Enable output pins after registers are reset
Date: Thu, 29 Feb 2024 14:23:47 +0200 [thread overview]
Message-ID: <15e6e45f-7398-4703-8154-35e769bac94a@gmail.com> (raw)
In-Reply-To: <CAMRc=MfTo7MnfMhRQsjeFsLv3yjEtP0C3ytqACN+nuGw0Sr-Bg@mail.gmail.com>
On 2/29/24 10:54, Bartosz Golaszewski wrote:
> On Thu, Feb 29, 2024 at 9:47 AM Arturas Moskvinas
> <arturas.moskvinas@gmail.com> wrote:
>> Chip outputs are enabled[1] before actual reset is performed[2] which might
>> cause pin output value to flip flop if previous pin value was set to 1 in chip.
>> Change fixes that behavior by making sure chip is fully reset before all outputs
>> are enabled.
>>
> Use imperative mood in commit messages - make it: "Fix that behavior
> by making sure ...".
Chip outputs are enabled[1] before actual reset is performed[2] which might
cause pin output value to flip flop if previous pin value was set to 1
in chip.
Fix that behavior by making sure chip is fully reset before all outputs are
enabled.
Bartosz, does this look better?
Arturas Moskvinas
next prev parent reply other threads:[~2024-02-29 12:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-29 8:45 Arturas Moskvinas
2024-02-29 8:54 ` Bartosz Golaszewski
2024-02-29 12:23 ` Arturas Moskvinas [this message]
2024-02-29 13:25 ` Bartosz Golaszewski
[not found] ` <f9e90eb2-60e5-4ae8-9f3f-92922294e981@gmail.com>
2024-02-29 17:39 ` Bartosz Golaszewski
2024-02-29 18:25 ` Andy Shevchenko
2024-02-29 10:45 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15e6e45f-7398-4703-8154-35e769bac94a@gmail.com \
--to=arturas.moskvinas@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®