mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Edgecombe, Rick P" <rick.p.edgecombe@intel.com>
To: "Lutomirski, Andy" <luto@kernel.org>,
	"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
	"thomas.lendacky@amd.com" <thomas.lendacky@amd.com>,
	"Reshetova, Elena" <elena.reshetova@intel.com>,
	"kirill.shutemov@linux.intel.com"
	<kirill.shutemov@linux.intel.com>,
	"mingo@redhat.com" <mingo@redhat.com>, "Christopherson,,
	Sean" <seanjc@google.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"tglx@linutronix.de" <tglx@linutronix.de>,
	"Cui, Dexuan" <decui@microsoft.com>,
	"Yamahata, Isaku" <isaku.yamahata@intel.com>,
	"mikelley@microsoft.com" <mikelley@microsoft.com>,
	"hpa@zytor.com" <hpa@zytor.com>,
	"peterz@infradead.org" <peterz@infradead.org>,
	"bp@alien8.de" <bp@alien8.de>,
	"sathyanarayanan.kuppuswamy@linux.intel.com" 
	<sathyanarayanan.kuppuswamy@linux.intel.com>,
	"x86@kernel.org" <x86@kernel.org>
Subject: Re: [PATCH] x86/mm/cpa: Warn if set_memory_XXcrypted() fails
Date: Thu, 26 Oct 2023 01:45:15 +0000	[thread overview]
Message-ID: <15e8b03ef471514d9347e8bffba4fdfa1ef4f3d7.camel@intel.com> (raw)
In-Reply-To: <29564bbe-b7a0-fcc5-47ee-093a032a11b6@amd.com>

On Wed, 2023-10-25 at 13:03 -0500, Tom Lendacky wrote:
> 
> Reviewed-by: Tom Lendacky <thomas.lendacky@amd.com>

Thanks!
> > 
> 
> Under SEV, when making a page private/encrypted and the hypervisor
> does 
> not assign the page to the guest (encrypted), but says it did, then
> when 
> SEV tries to perform the PVALIDATE in the enc_status_change_finish()
> call, 
> a nested page fault (#NPF) will be generated and exit to the
> hypervisor. 
> Until the hypervisor assigns the page to the guest, the guest will
> not be 
> able to make forward progress in regards to updating or using that
> page.

Yea, mismatches between guest page tables and EPT/NPT can be trouble
for TDX as well.

> 
> And if the hypervisor returns an error when changing the page state,
> then, 
> yes, the guest will terminate.

I guess those callbacks could be changed to return an error after all
these fixes then, if you want.

  reply	other threads:[~2023-10-26  1:45 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-24 23:48 Rick Edgecombe
2023-10-25 18:03 ` Tom Lendacky
2023-10-26  1:45   ` Edgecombe, Rick P [this message]
2023-10-26 13:43     ` Tom Lendacky
2023-10-25 18:10 ` Kuppuswamy Sathyanarayanan
2023-10-26  2:04   ` Edgecombe, Rick P
2023-10-26 13:37     ` Tom Lendacky
2023-10-26 22:07       ` Edgecombe, Rick P
2023-10-26  0:35 ` Michael Kelley (LINUX)
2023-10-26  1:40   ` Edgecombe, Rick P
     [not found]     ` <BYAPR21MB1688E43151404FFB435ACF41D7DCA@BYAPR21MB1688.namprd21.prod.outlook.com>
     [not found]       ` <3936d8f9abaf8eba98963a13ad75024931aeb930.camel@intel.com>
2023-10-27 17:08         ` Michael Kelley (LINUX)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=15e8b03ef471514d9347e8bffba4fdfa1ef4f3d7.camel@intel.com \
    --to=rick.p.edgecombe@intel.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=decui@microsoft.com \
    --cc=elena.reshetova@intel.com \
    --cc=hpa@zytor.com \
    --cc=isaku.yamahata@intel.com \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=mikelley@microsoft.com \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=sathyanarayanan.kuppuswamy@linux.intel.com \
    --cc=seanjc@google.com \
    --cc=tglx@linutronix.de \
    --cc=thomas.lendacky@amd.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®