From: Marc Zyngier <maz@kernel.org>
To: kvmarm@lists.cs.columbia.edu,
Alexandru Elisei <alexandru.elisei@arm.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, Nishanth Menon <nm@ti.com>,
Santosh Shilimkar <ssantosh@kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
Jason Cooper <jason@lakedaemon.net>,
Thomas Gleixner <tglx@linutronix.de>,
Tero Kristo <t-kristo@ti.com>
Cc: will@kernel.org, catalin.marinas@arm.com
Subject: Re: [PATCH 1/2] irqchip/ti-sci: Simplify with dev_err_probe()
Date: Sun, 13 Sep 2020 18:05:17 +0100 [thread overview]
Message-ID: <160001658182.6915.14152547552697841903.b4-ty@kernel.org> (raw)
In-Reply-To: <20200902174615.24695-1-krzk@kernel.org>
On Wed, 2 Sep 2020 19:46:14 +0200, Krzysztof Kozlowski wrote:
> Common pattern of handling deferred probe can be simplified with
> dev_err_probe(). Less code and the error value gets printed.
>
> There is also no need to assign NULL to 'intr->sci' as it is part of
> devm-allocated memory.
Applied to irq/irqchip-next, thanks!
[1/2] irqchip/ti-sci: Simplify with dev_err_probe()
commit: ea6c25e6057c0b7c18337696be84b8f9751f19ec
Patch #2 didn't make a lot of sense, so not applied.
Cheers,
M.
--
Without deviation from the norm, progress is not possible.
next prev parent reply other threads:[~2020-09-13 17:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-02 17:46 Krzysztof Kozlowski
2020-09-02 17:46 ` [PATCH 2/2] irqchip/ti-sci-inta: Fix kerneldoc Krzysztof Kozlowski
2020-09-13 15:34 ` Marc Zyngier
2020-09-13 17:05 ` Marc Zyngier [this message]
2020-10-11 17:57 ` [tip: irq/core] irqchip/ti-sci: Simplify with dev_err_probe() tip-bot2 for Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=160001658182.6915.14152547552697841903.b4-ty@kernel.org \
--to=maz@kernel.org \
--cc=alexandru.elisei@arm.com \
--cc=catalin.marinas@arm.com \
--cc=jason@lakedaemon.net \
--cc=krzk@kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=ssantosh@kernel.org \
--cc=t-kristo@ti.com \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®