From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14A6DC43461 for ; Mon, 14 Sep 2020 15:07:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B488C20829 for ; Mon, 14 Sep 2020 15:07:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600096066; bh=V3/far4j5J/ompVAq3Gu1Xzbic6PsatK795CwgtYLtw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=OvRbqwCj8vpmJdHHur8PoeHAo7ylsVtPuxjQXxOj0ge/3VQINxyN8+zJt/cyDQstn +Xm3Gdr8Sx6HzzxrPyQtVmJF6FvsH37Y5DMvZrN5Hs4oE3U+MsfT/nJwebDECcdxiK WOZP7HZB3rXlOQcFxCoUD2CgJzA+TWNUItubpSMQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726179AbgINPHo (ORCPT ); Mon, 14 Sep 2020 11:07:44 -0400 Received: from mail.kernel.org ([198.145.29.99]:58738 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726028AbgINPHf (ORCPT ); Mon, 14 Sep 2020 11:07:35 -0400 Received: from localhost.localdomain (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B52CA20829; Mon, 14 Sep 2020 15:07:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600096055; bh=V3/far4j5J/ompVAq3Gu1Xzbic6PsatK795CwgtYLtw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=IvLNo2OdWWgeMdGtk0Ym99FxTC82IleK73rFwU+2z0OWokNTygXXjHcdI8TdvkHCM /8hxRe2eU5LHkBi2JWgRHb6mirJrDewWw3BeyZy8FPsm4sOX1/sMaYGVWtyNkv3fPh Htklbwaj+1QdGw9M8FVvTwquub29NbefPUy/Bjds= From: Will Deacon To: Gavin Shan , linux-arm-kernel@lists.infradead.org Cc: catalin.marinas@arm.com, kernel-team@android.com, Will Deacon , shan.gavin@gmail.com, linux-kernel@vger.kernel.org, anshuman.khandual@arm.com, mark.rutland@arm.com Subject: Re: [PATCH v2] arm64/mm: Refactor {pgd, pud, pmd, pte}_ERROR() Date: Mon, 14 Sep 2020 16:07:28 +0100 Message-Id: <160008622201.2014428.16589477357188793973.b4-ty@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200913234730.23145-1-gshan@redhat.com> References: <20200913234730.23145-1-gshan@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 14 Sep 2020 09:47:30 +1000, Gavin Shan wrote: > The function __{pgd, pud, pmd, pte}_error() are introduced so that > they can be called by {pgd, pud, pmd, pte}_ERROR(). However, some > of the functions could never be called when the corresponding page > table level isn't enabled. For example, __{pud, pmd}_error() are > unused when PUD and PMD are folded to PGD. > > This removes __{pgd, pud, pmd, pte}_error() and call pr_err() from > {pgd, pud, pmd, pte}_ERROR() directly, similar to what x86/powerpc > are doing. With this, the code looks a bit simplified either. Applied to arm64 (for-next/misc), thanks! [1/1] arm64/mm: Refactor {pgd, pud, pmd, pte}_ERROR() https://git.kernel.org/arm64/c/2cf660eb81e9 Cheers, -- Will https://fixes.arm64.dev https://next.arm64.dev https://will.arm64.dev