From: Moshe Shemesh <moshe@mellanox.com>
To: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Jiri Pirko <jiri@mellanox.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Moshe Shemesh <moshe@mellanox.com>
Subject: [PATCH net-next RFC v5 11/15] devlink: Add enable_remote_dev_reset generic parameter
Date: Fri, 18 Sep 2020 19:06:47 +0300 [thread overview]
Message-ID: <1600445211-31078-12-git-send-email-moshe@mellanox.com> (raw)
In-Reply-To: <1600445211-31078-1-git-send-email-moshe@mellanox.com>
The enable_remote_dev_reset devlink param flags that the host admin
allows device resets that can be initiated by other hosts. This
parameter is useful for setups where a device is shared by different
hosts, such as multi-host setup. Once the user set this parameter to
false, the driver should NACK any attempt to reset the device while the
driver is loaded.
Signed-off-by: Moshe Shemesh <moshe@mellanox.com>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
---
Documentation/networking/devlink/devlink-params.rst | 6 ++++++
include/net/devlink.h | 4 ++++
net/core/devlink.c | 5 +++++
3 files changed, 15 insertions(+)
diff --git a/Documentation/networking/devlink/devlink-params.rst b/Documentation/networking/devlink/devlink-params.rst
index d075fd090b3d..54c9f107c4b0 100644
--- a/Documentation/networking/devlink/devlink-params.rst
+++ b/Documentation/networking/devlink/devlink-params.rst
@@ -108,3 +108,9 @@ own name.
* - ``region_snapshot_enable``
- Boolean
- Enable capture of ``devlink-region`` snapshots.
+ * - ``enable_remote_dev_reset``
+ - Boolean
+ - Enable device reset by remote host. When cleared, the device driver
+ will NACK any attempt of other host to reset the device. This parameter
+ is useful for setups where a device is shared by different hosts, such
+ as multi-host setup.
diff --git a/include/net/devlink.h b/include/net/devlink.h
index f09f55a47d09..8ab5ac5c365f 100644
--- a/include/net/devlink.h
+++ b/include/net/devlink.h
@@ -445,6 +445,7 @@ enum devlink_param_generic_id {
DEVLINK_PARAM_GENERIC_ID_FW_LOAD_POLICY,
DEVLINK_PARAM_GENERIC_ID_RESET_DEV_ON_DRV_PROBE,
DEVLINK_PARAM_GENERIC_ID_ENABLE_ROCE,
+ DEVLINK_PARAM_GENERIC_ID_ENABLE_REMOTE_DEV_RESET,
/* add new param generic ids above here*/
__DEVLINK_PARAM_GENERIC_ID_MAX,
@@ -482,6 +483,9 @@ enum devlink_param_generic_id {
#define DEVLINK_PARAM_GENERIC_ENABLE_ROCE_NAME "enable_roce"
#define DEVLINK_PARAM_GENERIC_ENABLE_ROCE_TYPE DEVLINK_PARAM_TYPE_BOOL
+#define DEVLINK_PARAM_GENERIC_ENABLE_REMOTE_DEV_RESET_NAME "enable_remote_dev_reset"
+#define DEVLINK_PARAM_GENERIC_ENABLE_REMOTE_DEV_RESET_TYPE DEVLINK_PARAM_TYPE_BOOL
+
#define DEVLINK_PARAM_GENERIC(_id, _cmodes, _get, _set, _validate) \
{ \
.id = DEVLINK_PARAM_GENERIC_ID_##_id, \
diff --git a/net/core/devlink.c b/net/core/devlink.c
index 71aeda259e6a..565fa786d01f 100644
--- a/net/core/devlink.c
+++ b/net/core/devlink.c
@@ -3458,6 +3458,11 @@ static const struct devlink_param devlink_param_generic[] = {
.name = DEVLINK_PARAM_GENERIC_ENABLE_ROCE_NAME,
.type = DEVLINK_PARAM_GENERIC_ENABLE_ROCE_TYPE,
},
+ {
+ .id = DEVLINK_PARAM_GENERIC_ID_ENABLE_REMOTE_DEV_RESET,
+ .name = DEVLINK_PARAM_GENERIC_ENABLE_REMOTE_DEV_RESET_NAME,
+ .type = DEVLINK_PARAM_GENERIC_ENABLE_REMOTE_DEV_RESET_TYPE,
+ },
};
static int devlink_param_generic_verify(const struct devlink_param *param)
--
2.17.1
next prev parent reply other threads:[~2020-09-18 16:15 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-18 16:06 [PATCH net-next RFC v5 00/15] Add devlink reload action and limit level options Moshe Shemesh
2020-09-18 16:06 ` [PATCH net-next RFC v5 01/15] devlink: Add reload action option to devlink reload command Moshe Shemesh
2020-09-23 18:25 ` Jakub Kicinski
2020-09-24 19:01 ` Moshe Shemesh
2020-09-24 20:38 ` Jakub Kicinski
2020-09-18 16:06 ` [PATCH net-next RFC v5 02/15] devlink: Add reload action limit level Moshe Shemesh
2020-09-23 18:36 ` Jakub Kicinski
2020-09-24 19:29 ` Moshe Shemesh
2020-09-24 20:45 ` Jakub Kicinski
2020-09-18 16:06 ` [PATCH net-next RFC v5 03/15] devlink: Add reload action stats Moshe Shemesh
2020-09-23 18:42 ` Jakub Kicinski
2020-09-24 19:31 ` Moshe Shemesh
2020-09-18 16:06 ` [PATCH net-next RFC v5 04/15] devlink: Add reload actions stats to dev get Moshe Shemesh
2020-09-23 18:50 ` Jakub Kicinski
2020-09-24 19:34 ` Moshe Shemesh
2020-09-18 16:06 ` [PATCH net-next RFC v5 05/15] net/mlx5: Add functions to set/query MFRL register Moshe Shemesh
2020-09-18 16:06 ` [PATCH net-next RFC v5 06/15] net/mlx5: Set cap for pci sync for fw update event Moshe Shemesh
2020-09-18 16:06 ` [PATCH net-next RFC v5 07/15] net/mlx5: Handle sync reset request event Moshe Shemesh
2020-09-18 16:06 ` [PATCH net-next RFC v5 08/15] net/mlx5: Handle sync reset now event Moshe Shemesh
2020-09-18 16:06 ` [PATCH net-next RFC v5 09/15] net/mlx5: Handle sync reset abort event Moshe Shemesh
2020-09-18 16:06 ` [PATCH net-next RFC v5 10/15] net/mlx5: Add support for devlink reload action fw activate Moshe Shemesh
2020-09-18 16:06 ` Moshe Shemesh [this message]
2020-09-18 16:06 ` [PATCH net-next RFC v5 12/15] net/mlx5: Add devlink param enable_remote_dev_reset support Moshe Shemesh
2020-09-18 16:06 ` [PATCH net-next RFC v5 13/15] net/mlx5: Add support for fw live patch event Moshe Shemesh
2020-09-18 16:06 ` [PATCH net-next RFC v5 14/15] net/mlx5: Add support for devlink reload action limit level no reset Moshe Shemesh
2020-09-18 16:06 ` [PATCH net-next RFC v5 15/15] devlink: Add Documentation/networking/devlink/devlink-reload.rst Moshe Shemesh
2020-09-23 13:44 ` [PATCH net-next RFC v5 00/15] Add devlink reload action and limit level options Moshe Shemesh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1600445211-31078-12-git-send-email-moshe@mellanox.com \
--to=moshe@mellanox.com \
--cc=davem@davemloft.net \
--cc=jiri@mellanox.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®