mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paul Mackerras <paulus@samba.org>
To: petkan@users.sourceforge.net
Cc: greg@kroah.com, linux-kernel@vger.kernel.org
Subject: [PATCH] small fix to pegasus.c
Date: Mon, 31 Mar 2003 10:10:39 +1000 (EST)	[thread overview]
Message-ID: <16007.34687.590218.260862@nanango.paulus.ozlabs.org> (raw)

Using cpu_to_le16p on a __u8 variable is wrong, and gives a compile
warning on PPC.  It's better to use cpu_to_le16 in this case.  Here is
a patch to fix it.  Please apply.

Paul.

diff -urN linux-2.5/drivers/usb/net/pegasus.c pmac-2.5/drivers/usb/net/pegasus.c
--- linux-2.5/drivers/usb/net/pegasus.c	2003-03-21 19:48:22.000000000 +1100
+++ pmac-2.5/drivers/usb/net/pegasus.c	2003-03-21 20:49:46.000000000 +1100
@@ -233,7 +233,7 @@
 
 	pegasus->dr.bRequestType = PEGASUS_REQT_WRITE;
 	pegasus->dr.bRequest = PEGASUS_REQ_SET_REG;
-	pegasus->dr.wValue = cpu_to_le16p(&data);
+	pegasus->dr.wValue = cpu_to_le16(data);
 	pegasus->dr.wIndex = cpu_to_le16p(&indx);
 	pegasus->dr.wLength = cpu_to_le16(1);
 	pegasus->ctrl_urb->transfer_buffer_length = 1;

             reply	other threads:[~2003-03-31  0:05 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-03-31  0:10 Paul Mackerras [this message]
2003-04-05  0:14 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=16007.34687.590218.260862@nanango.paulus.ozlabs.org \
    --to=paulus@samba.org \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=petkan@users.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®