From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A8D4C4727E for ; Tue, 22 Sep 2020 00:07:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2704423A74 for ; Tue, 22 Sep 2020 00:07:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600733233; bh=yc4ZdBYVnhX0vOR1hst8S+NVO/p2/2pfSEqt6t7Tv84=; h=Date:From:To:Cc:In-Reply-To:References:Subject:List-ID:From; b=lJkChtVZm26kPnkDcqA4TsBuM+tVab8c13FEBgIIXHm8NmLjcEux18ZoiennQQuLm ld0jl0hDcpjj8ZoXBfLNIrrjHZ5Tbt/YbBSWRPs+v9lvALGb8cbM8kd+Q7oiEH65kQ ql8MlmnRI9E9FS0Qw2HZzHBcyoovHwK1MM03z2hU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729088AbgIVAHM (ORCPT ); Mon, 21 Sep 2020 20:07:12 -0400 Received: from mail.kernel.org ([198.145.29.99]:40972 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729018AbgIVAHL (ORCPT ); Mon, 21 Sep 2020 20:07:11 -0400 Received: from localhost (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1EEFD207C4; Tue, 22 Sep 2020 00:07:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600733230; bh=yc4ZdBYVnhX0vOR1hst8S+NVO/p2/2pfSEqt6t7Tv84=; h=Date:From:To:Cc:In-Reply-To:References:Subject:From; b=MnrqwCOcaARBJsHVQTM5D8H32R5hvnl5+CWPWoCgPsRWL5gPn+rF6x7ejg73TwMoD OacvCb7fFnimO2lvnqo1aOKWSMJskTzubZbb+Bg+OIjtdaq+65xOFe2QgZ54s0pEcK oiBooqFp45WNvRma/yXEUPRbx3z8H+J3gikvCnvU= Date: Tue, 22 Sep 2020 01:06:18 +0100 From: Mark Brown To: Aswath Govindraju Cc: Vignesh R , linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, Sekhar Nori In-Reply-To: <20200910122624.8769-1-a-govindraju@ti.com> References: <20200910122624.8769-1-a-govindraju@ti.com> Subject: Re: [PATCH] Revert "spi: omap2-mcspi: Switch to readl_poll_timeout()" Message-Id: <160073317818.6418.1953400870521393245.b4-ty@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 10 Sep 2020 17:56:24 +0530, Aswath Govindraju wrote: > This reverts commit 13d515c796adc49a49b0cd2212ccd7f43a37fc5a. > > The amount of time spent polling for the MCSPI_CHSTAT bits to be set on > AM335x-icev2 platform is less than 1us (about 0.6us) in most cases, with > or without using DMA. So, in most cases the function need not sleep. > Also, setting the sleep_usecs to zero would not be optimal here because > ktime_add_us() used in readl_poll_timeout() is slower compared to the > direct addition used after the revert. So, it is sub-optimal to use > readl_poll_timeout in this case. > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next Thanks! [1/1] spi: omap2-mcspi: Improve performance waiting for CHSTAT commit: 7b1d96813317358312440d0d07abbfbeb0ef8d22 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark