From: Stefan Wahren <stefan.wahren@i2se.com>
To: Alexey Khoroshilov <khoroshilov@ispras.ru>,
Jonathan Cameron <jic23@kernel.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-kernel@vger.kernel.org, ldv-project@linuxtesting.org,
linux-iio@vger.kernel.org, lee.jones@linaro.org
Subject: Re: [PATCH] iio: mxs-lradc: fix error handling in mxs_lradc_probe()
Date: Mon, 26 Dec 2016 23:04:04 +0100 (CET) [thread overview]
Message-ID: <1600801097.88831.1482789844722@email.1und1.de> (raw)
In-Reply-To: <1482531319-26935-1-git-send-email-khoroshilov@ispras.ru>
> Alexey Khoroshilov <khoroshilov@ispras.ru> hat am 23. Dezember 2016 um 23:15 geschrieben:
>
>
> During transition to using devm_input_allocate_device()
> goto to resource deallocation block was replaced by return
> in case of error in iio_device_register().
> That is wrong since resources are left undeallocated.
>
> Found by Linux Driver Verification project (linuxtesting.org).
>
> Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
> Fixes: 962ed43a3eac ("iio: mxs-lradc: remove mxs_lradc_ts_unregister")
Acked-by: Stefan Wahren <stefan.wahren@i2se.com>
But since Ksenija's patch series [1] (which doesn't have this issue) this patch is only relevant for stable.
Thanks
[1] - http://marc.info/?l=linux-iio&m=148131774219426&w=2
next prev parent reply other threads:[~2016-12-26 22:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-23 22:15 Alexey Khoroshilov
2016-12-26 22:04 ` Stefan Wahren [this message]
2016-12-30 19:09 ` Jonathan Cameron
2016-12-30 20:16 ` Stefan Wahren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1600801097.88831.1482789844722@email.1und1.de \
--to=stefan.wahren@i2se.com \
--cc=dmitry.torokhov@gmail.com \
--cc=jic23@kernel.org \
--cc=khoroshilov@ispras.ru \
--cc=ldv-project@linuxtesting.org \
--cc=lee.jones@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®