From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E199AC4741F for ; Mon, 28 Sep 2020 19:36:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A61EB20773 for ; Mon, 28 Sep 2020 19:36:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601321803; bh=avMUC3kTZk7zxs9fhpfwAK4zwmvKYLPb4GVi4AxrNHs=; h=Date:From:To:Cc:In-Reply-To:References:Subject:List-ID:From; b=JI+grhMRg3rTD+F6aaFAJ7PtqDvQkB5RpolzTiS2BMX0e8O2rfKmSvMTrKrg8qWq8 4tPZV+3t/lVdifoPIY+zQ3cZm6+RB4X1UfRuX8mws/jdD3re8tC2WrTxEoCdLyOcsr Hx8e/rq7YXfat70Ydr2LMk/E9pM9BdZ88t/ynIWc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726865AbgI1Tgn (ORCPT ); Mon, 28 Sep 2020 15:36:43 -0400 Received: from mail.kernel.org ([198.145.29.99]:36842 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726442AbgI1Tgm (ORCPT ); Mon, 28 Sep 2020 15:36:42 -0400 Received: from localhost (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 840992080C; Mon, 28 Sep 2020 19:36:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601321802; bh=avMUC3kTZk7zxs9fhpfwAK4zwmvKYLPb4GVi4AxrNHs=; h=Date:From:To:Cc:In-Reply-To:References:Subject:From; b=Tsd85f4XkEUved/61Tmbq7UNmtEdGnexaaHuXNEUVtcfdypgJMBYchC65Ld9U39qB Dok3OqP7pe2dpFxCqOQI4k5fw/ty745hezLq6PKkEbo5NgPUS++HyfnPECJkHUxaBq BQz5YMf0g0eck3wg4HzRHf5eGB6agBhnv48OcT0U= Date: Mon, 28 Sep 2020 20:35:45 +0100 From: Mark Brown To: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, Michael Walle Cc: Vladimir Oltean , Sascha Hauer , Krzysztof Kozlowski In-Reply-To: <20200928085500.28254-1-michael@walle.cc> References: <20200928085500.28254-1-michael@walle.cc> Subject: Re: [PATCH v3] spi: fsl-dspi: fix NULL pointer dereference Message-Id: <160132174502.55568.11234605078950751454.b4-ty@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 28 Sep 2020 10:55:00 +0200, Michael Walle wrote: > Since commit 530b5affc675 ("spi: fsl-dspi: fix use-after-free in remove > path") this driver causes a kernel oops: > > [ 1.891065] Unable to handle kernel NULL pointer dereference at virtual address 0000000000000080 > [..] > [ 2.056973] Call trace: > [ 2.059425] dspi_setup+0xc8/0x2e0 > [ 2.062837] spi_setup+0xcc/0x248 > [ 2.066160] spi_add_device+0xb4/0x198 > [ 2.069918] of_register_spi_device+0x250/0x370 > [ 2.074462] spi_register_controller+0x4f4/0x770 > [ 2.079094] dspi_probe+0x5bc/0x7b0 > [ 2.082594] platform_drv_probe+0x5c/0xb0 > [ 2.086615] really_probe+0xec/0x3c0 > [ 2.090200] driver_probe_device+0x60/0xc0 > [ 2.094308] device_driver_attach+0x7c/0x88 > [ 2.098503] __driver_attach+0x60/0xe8 > [ 2.102263] bus_for_each_dev+0x7c/0xd0 > [ 2.106109] driver_attach+0x2c/0x38 > [ 2.109692] bus_add_driver+0x194/0x1f8 > [ 2.113538] driver_register+0x6c/0x128 > [ 2.117385] __platform_driver_register+0x50/0x60 > [ 2.122105] fsl_dspi_driver_init+0x24/0x30 > [ 2.126302] do_one_initcall+0x54/0x2d0 > [ 2.130149] kernel_init_freeable+0x1ec/0x258 > [ 2.134520] kernel_init+0x1c/0x120 > [ 2.138018] ret_from_fork+0x10/0x34 > [ 2.141606] Code: 97e0b11d aa0003f3 b4000680 f94006e0 (f9404000) > [ 2.147723] ---[ end trace 26cf63e6cbba33a8 ]--- > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next Thanks! [1/1] spi: fsl-dspi: fix NULL pointer dereference commit: 6e3837668e00fb914ac2b43158ef51b027ec385c All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark