From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99178C4363D for ; Fri, 2 Oct 2020 21:07:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 537FE206DD for ; Fri, 2 Oct 2020 21:07:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601672850; bh=NKFI118U37/X9R8l+JOxUct5ebC+vaZYVVVjk9c/ckI=; h=Date:From:To:Cc:In-Reply-To:References:Subject:List-ID:From; b=LDppsOs4red7MkLFHzEYVfOb+0jhxcUqBExgzrHEmrmwElPsTt9tXDneCZPwBXoAb JkwoBWjyLR0AzEG5p8IGhvppAJr2qg86UahpTFn4ioPAMdWme5SsC9SZNmQUuc5RkL ETYBX7LAvYsDuNDeacj4WsO0j0pBaSMN7ZwjDVoE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725681AbgJBVH3 (ORCPT ); Fri, 2 Oct 2020 17:07:29 -0400 Received: from mail.kernel.org ([198.145.29.99]:60052 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725283AbgJBVH3 (ORCPT ); Fri, 2 Oct 2020 17:07:29 -0400 Received: from localhost (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EC27E206C9; Fri, 2 Oct 2020 21:07:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601672848; bh=NKFI118U37/X9R8l+JOxUct5ebC+vaZYVVVjk9c/ckI=; h=Date:From:To:Cc:In-Reply-To:References:Subject:From; b=bjTGLVDn6xhBExBz4e3JQS6szJkptVXkmfG99KJoRX2A+3KYBSVsCJZYg43Kc8YdC e9X8qfN8/C2DsntJOkmS/QTU4CUFrGdzSxb9IZB1kihoIZmQHqhqE7BeHte7TaOpDO EDdeEdBelu1SlJPDfJL75b5mFbJJ3Apu9NmD2yXY= Date: Fri, 02 Oct 2020 22:06:28 +0100 From: Mark Brown To: alsa-devel@alsa-project.org, Brent Lu Cc: =?utf-8?q?linux-kernel=40vger=2Ekernel=2Eorg=2C_Kai_Vehmanen_=3Ckai=2Eve?=@vger.kernel.org, =?utf-8?q?hmanen=40linux=2Eintel=2Ecom=3E=2C_Pierre-Louis_Bossart_=3Cpierre?=@vger.kernel.org, =?utf-8?q?-louis=2Ebossart=40linux=2Eintel=2Ecom=3E=2C_Takashi_Iwai_=3Ctiwa?=@vger.kernel.org, =?utf-8?q?i=40suse=2Ecom=3E=2C_Guennadi_Liakhovetski_=3Cguennadi=2Eliakhove?=@vger.kernel.org, =?utf-8?q?tski=40linux=2Eintel=2Ecom=3E=2C_Liam_Girdwood_=3Clgirdwood=40gma?=@vger.kernel.org, =?utf-8?q?il=2Ecom=3E=2C_Amadeusz_S=C5=82awi=C5=84ski_=3Camadeuszx=2Eslawin?=@vger.kernel.org, =?utf-8?q?ski=40linux=2Eintel=2Ecom=3E?=@vger.kernel.org In-Reply-To: <1594818110-786-1-git-send-email-brent.lu@intel.com> References: <1594818110-786-1-git-send-email-brent.lu@intel.com> Subject: Re: [PATCH] ASoC: hdac_hdmi: remove cancel_work_sync in runtime suspend Message-Id: <160167211500.21762.13369928255363041989.b4-ty@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 15 Jul 2020 21:01:50 +0800, Brent Lu wrote: > A deadlock is identified when there are three contexts running at the > same time: > - a HDMI jack work which is calling snd_soc_dapm_sync(). > - user space is calling snd_pcm_release() to close pcm device. > - pm is calling runtime suspend function of HDMI codec driver. > > By removing the clear_dapm_works() invocation in the > hdac_hdmi_runtime_suspend() function, the snd_pcm_release() could > always returns from dapm_power_widgets() function call without > blocking the hdac_hdmi_jack_dapm_work() work thread or being blocked > by the hdac_hdmi_runtime_suspend() function. The purpose of the jack > work is to enable/disable the dapm jack pin so it's not necessary to > cancel the work in runtime suspend function which is usually called > when pcm device is closed. Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: hdac_hdmi: remove cancel_work_sync in runtime suspend commit: cec6e41ce094affad3b5f9f5e5aa1f81c66ce682 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark