From: "tip-bot2 for Maulik Shah" <tip-bot2@linutronix.de>
To: linux-tip-commits@vger.kernel.org
Cc: Maulik Shah <mkshah@codeaurora.org>,
Marc Zyngier <maz@kernel.org>, Stephen Boyd <swboyd@chromium.org>,
Douglas Anderson <dianders@chromium.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Linus Walleij <linus.walleij@linaro.org>, x86 <x86@kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: [tip: irq/core] pinctrl: qcom: Set IRQCHIP_SET_TYPE_MASKED and IRQCHIP_MASK_ON_SUSPEND flags
Date: Sun, 11 Oct 2020 17:57:23 -0000 [thread overview]
Message-ID: <160243904378.7002.14160679629987199021.tip-bot2@tip-bot2> (raw)
In-Reply-To: <1601267524-20199-2-git-send-email-mkshah@codeaurora.org>
The following commit has been merged into the irq/core branch of tip:
Commit-ID: c5f72aeb659eb2f809b9531d759651514d42aa3a
Gitweb: https://git.kernel.org/tip/c5f72aeb659eb2f809b9531d759651514d42aa3a
Author: Maulik Shah <mkshah@codeaurora.org>
AuthorDate: Mon, 28 Sep 2020 10:01:59 +05:30
Committer: Marc Zyngier <maz@kernel.org>
CommitterDate: Tue, 06 Oct 2020 11:23:13 +01:00
pinctrl: qcom: Set IRQCHIP_SET_TYPE_MASKED and IRQCHIP_MASK_ON_SUSPEND flags
Both IRQCHIP_SET_TYPE_MASKED and IRQCHIP_MASK_ON_SUSPEND flags are already
set for msmgpio's parent PDC irqchip but GPIO interrupts do not get masked
during suspend or during setting irq type since genirq checks irqchip flag
of msmgpio irqchip which forwards these calls to its parent PDC irqchip.
Add irqchip specific flags for msmgpio irqchip to mask non wakeirqs during
suspend and mask before setting irq type. Masking before changing type make
sures any spurious interrupt is not detected during this operation.
Fixes: e35a6ae0eb3a ("pinctrl/msm: Setup GPIO chip in hierarchy")
Signed-off-by: Maulik Shah <mkshah@codeaurora.org>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Tested-by: Stephen Boyd <swboyd@chromium.org>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Link: https://lore.kernel.org/r/1601267524-20199-2-git-send-email-mkshah@codeaurora.org
---
drivers/pinctrl/qcom/pinctrl-msm.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/pinctrl/qcom/pinctrl-msm.c b/drivers/pinctrl/qcom/pinctrl-msm.c
index a2567e7..1c23f5c 100644
--- a/drivers/pinctrl/qcom/pinctrl-msm.c
+++ b/drivers/pinctrl/qcom/pinctrl-msm.c
@@ -1243,6 +1243,8 @@ static int msm_gpio_init(struct msm_pinctrl *pctrl)
pctrl->irq_chip.irq_release_resources = msm_gpio_irq_relres;
pctrl->irq_chip.irq_set_affinity = msm_gpio_irq_set_affinity;
pctrl->irq_chip.irq_set_vcpu_affinity = msm_gpio_irq_set_vcpu_affinity;
+ pctrl->irq_chip.flags = IRQCHIP_MASK_ON_SUSPEND |
+ IRQCHIP_SET_TYPE_MASKED;
np = of_parse_phandle(pctrl->dev->of_node, "wakeup-parent", 0);
if (np) {
next prev parent reply other threads:[~2020-10-11 17:57 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-28 4:31 [PATCH v6 0/6] irqchip: qcom: pdc: Introduce irq_set_wake call Maulik Shah
2020-09-28 4:31 ` [PATCH v6 1/6] pinctrl: qcom: Set IRQCHIP_SET_TYPE_MASKED and IRQCHIP_MASK_ON_SUSPEND flags Maulik Shah
2020-10-11 17:57 ` tip-bot2 for Maulik Shah [this message]
2020-09-28 4:32 ` [PATCH v6 2/6] pinctrl: qcom: Use return value from irq_set_wake() call Maulik Shah
2020-10-11 17:57 ` [tip: irq/core] " tip-bot2 for Maulik Shah
2020-09-28 4:32 ` [PATCH v6 3/6] genirq/PM: Introduce IRQCHIP_ENABLE_WAKEUP_ON_SUSPEND flag Maulik Shah
2020-09-28 21:12 ` Doug Anderson
2020-09-29 20:18 ` Thomas Gleixner
2020-10-11 17:57 ` [tip: irq/core] " tip-bot2 for Maulik Shah
2020-09-28 4:32 ` [PATCH v6 4/6] pinctrl: qcom: Set " Maulik Shah
2020-10-11 17:57 ` [tip: irq/core] " tip-bot2 for Maulik Shah
2020-09-28 4:32 ` [PATCH v6 5/6] irqchip: qcom-pdc: " Maulik Shah
2020-10-11 17:57 ` [tip: irq/core] irqchip/qcom-pdc: " tip-bot2 for Maulik Shah
2020-09-28 4:32 ` [PATCH v6 6/6] irqchip: qcom-pdc: Reset PDC interrupts during init Maulik Shah
2020-10-11 17:57 ` [tip: irq/core] irqchip/qcom-pdc: " tip-bot2 for Maulik Shah
2020-10-01 8:13 ` [PATCH v6 0/6] irqchip: qcom: pdc: Introduce irq_set_wake call Stephen Boyd
2020-10-06 10:29 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=160243904378.7002.14160679629987199021.tip-bot2@tip-bot2 \
--to=tip-bot2@linutronix.de \
--cc=bjorn.andersson@linaro.org \
--cc=dianders@chromium.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=maz@kernel.org \
--cc=mkshah@codeaurora.org \
--cc=swboyd@chromium.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®