From: "tip-bot2 for Anson Huang" <tip-bot2@linutronix.de>
To: linux-tip-commits@vger.kernel.org
Cc: Anson Huang <Anson.Huang@nxp.com>, Marc Zyngier <maz@kernel.org>,
x86 <x86@kernel.org>, LKML <linux-kernel@vger.kernel.org>
Subject: [tip: irq/core] irqchip/imx-irqsteer: Use dev_err_probe() to simplify error handling
Date: Sun, 11 Oct 2020 17:57:40 -0000 [thread overview]
Message-ID: <160243906065.7002.1771330576771757675.tip-bot2@tip-bot2> (raw)
In-Reply-To: <1597126576-18383-2-git-send-email-Anson.Huang@nxp.com>
The following commit has been merged into the irq/core branch of tip:
Commit-ID: e0c45b107fc94c5a7a230b25cdbecab004ab1ed5
Gitweb: https://git.kernel.org/tip/e0c45b107fc94c5a7a230b25cdbecab004ab1ed5
Author: Anson Huang <Anson.Huang@nxp.com>
AuthorDate: Tue, 11 Aug 2020 14:16:16 +08:00
Committer: Marc Zyngier <maz@kernel.org>
CommitterDate: Sun, 13 Sep 2020 17:38:52 +01:00
irqchip/imx-irqsteer: Use dev_err_probe() to simplify error handling
dev_err_probe() can reduce code size, uniform error handling and record the
defer probe reason etc., use it to simplify the code.
Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/1597126576-18383-2-git-send-email-Anson.Huang@nxp.com
---
drivers/irqchip/irq-imx-irqsteer.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/irqchip/irq-imx-irqsteer.c b/drivers/irqchip/irq-imx-irqsteer.c
index 290531e..1edf769 100644
--- a/drivers/irqchip/irq-imx-irqsteer.c
+++ b/drivers/irqchip/irq-imx-irqsteer.c
@@ -158,12 +158,9 @@ static int imx_irqsteer_probe(struct platform_device *pdev)
}
data->ipg_clk = devm_clk_get(&pdev->dev, "ipg");
- if (IS_ERR(data->ipg_clk)) {
- ret = PTR_ERR(data->ipg_clk);
- if (ret != -EPROBE_DEFER)
- dev_err(&pdev->dev, "failed to get ipg clk: %d\n", ret);
- return ret;
- }
+ if (IS_ERR(data->ipg_clk))
+ return dev_err_probe(&pdev->dev, PTR_ERR(data->ipg_clk),
+ "failed to get ipg clk\n");
raw_spin_lock_init(&data->lock);
next prev parent reply other threads:[~2020-10-11 17:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-11 6:16 [PATCH V2 1/2] irqchip/imx-intmux: " Anson Huang
2020-08-11 6:16 ` [PATCH V2 2/2] irqchip/imx-irqsteer: " Anson Huang
2020-10-11 17:57 ` tip-bot2 for Anson Huang [this message]
2020-09-13 17:05 ` [PATCH V2 1/2] irqchip/imx-intmux: " Marc Zyngier
2020-10-11 17:57 ` [tip: irq/core] " tip-bot2 for Anson Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=160243906065.7002.1771330576771757675.tip-bot2@tip-bot2 \
--to=tip-bot2@linutronix.de \
--cc=Anson.Huang@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=maz@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®